Skip to content

rustdoc_missing_doc_code_examples: lint on macro_rules macros - #154696

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
lolbinarycat:rustdoc-missing_doc_code_examples-macro_rules
Apr 3, 2026
Merged

rustdoc_missing_doc_code_examples: lint on macro_rules macros#154696
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
lolbinarycat:rustdoc-missing_doc_code_examples-macro_rules

Conversation

@lolbinarycat

@lolbinarycatlolbinarycat commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

part of #154640

accidentally built this on top of #154644, but since that PR is already approved it should be fine if we just wait for it to be merged.

r? @GuillaumeGomez

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in GUI tests.

cc @GuillaumeGomez

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 1, 2026
@lolbinarycatlolbinarycat changed the title Rustdoc missing doc code examples macro rulesrustdoc_missing_doc_code_examples: lint on macro_rules macrosApr 1, 2026
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Looks good to me, thanks! r=me once first PR is merged and this one passes CI. ;)

@lolbinarycat
lolbinarycatforce-pushed the rustdoc-missing_doc_code_examples-macro_rules branch from 34e07d5 to 6fd96ddCompareApril 1, 2026 21:06
@lolbinarycat

Copy link
Copy Markdown
ContributorAuthor

@bors r=GuillaumeGomez

@rust-bors

rust-borsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6fd96dd has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
Rollup of 6 pull requests
Successful merges:
- #154696 (rustdoc_missing_doc_code_examples: lint on macro_rules macros)
- #154698 (Improve workings of the `desc` query modifier and custom query cycle handlers)
- #154713 (Stop compiling when we get resolving crate failure)
- #154736 (Add a regression test for the duplicated `crate` keyword in path suggestions)
- #154739 (ci: update upload-artifact action to v7)
- #154741 (Enforce `#![warn(unreachable_pub)]` in compiletest source)
Failed merges:
- #154605 (Make `span_suggestions` always verbose)
@rust-bors
rust-borsBot merged commit 7a74013 into rust-lang:mainApr 3, 2026
15 of 22 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Apr 3, 2026
rust-timer added a commit that referenced this pull request Apr 3, 2026
Rollup merge of #154696 - lolbinarycat:rustdoc-missing_doc_code_examples-macro_rules, r=GuillaumeGomez
rustdoc_missing_doc_code_examples: lint on macro_rules macros
part of #154640
accidentally built this on top of #154644, but since that PR is already approved it should be fine if we just wait for it to be merged.
r? @GuillaumeGomez
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lolbinarycat@rustbot@rust-log-analyzer@GuillaumeGomez