Uh oh!
There was an error while loading. Please reload this page.
fix compilation of time/hermit.rs - #154706
Merged
Merged
Conversation
rust-lang#154518 has broken compiling std for Hermit by unwrapping an `i32`. This commit converts the `i32` to an `io::Result` before unwrapping.
Mark-Simulacrum
commented
Apr 4, 2026
Member
@bors r+ rollup |
Contributor
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 4, 2026
…uwer Rollup of 6 pull requests Successful merges: - #147552 ([Debugger Visualizers] Optimize lookup behavior) - #154052 (float: Fix panic at max exponential precision) - #154706 (fix compilation of time/hermit.rs) - #154707 (Make `substr_range` and `subslice_range` return the new `Range` type) - #154767 (triagebot: roll library reviewers for `{coretests,alloctests}`) - #154797 (bootstrap: Include shorthand aliases in x completions)
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Apr 5, 2026
Rollup merge of #154706 - hermit-os:time-hermit, r=Mark-Simulacrum fix compilation of time/hermit.rs #154518 has broken compiling std for Hermit by unwrapping an `i32`. This PR converts the `i32` to an `io::Result` before unwrapping. Closes#154626. Closeshermit-os/hermit-rs#965. r? @Mark-Simulacrum
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 5, 2026
…uwer Rollup of 6 pull requests Successful merges: - rust-lang/rust#147552 ([Debugger Visualizers] Optimize lookup behavior) - rust-lang/rust#154052 (float: Fix panic at max exponential precision) - rust-lang/rust#154706 (fix compilation of time/hermit.rs) - rust-lang/rust#154707 (Make `substr_range` and `subslice_range` return the new `Range` type) - rust-lang/rust#154767 (triagebot: roll library reviewers for `{coretests,alloctests}`) - rust-lang/rust#154797 (bootstrap: Include shorthand aliases in x completions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#154518 has broken compiling std for Hermit by unwrapping an
i32.This PR converts the
i32to anio::Resultbefore unwrapping.Closes#154626.
Closeshermit-os/hermit-rs#965.
r? @Mark-Simulacrum