Skip to content

Panic in Hermit clock_gettime - #154518

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
stepancheg:hermit-panic
Mar 30, 2026
Merged

Panic in Hermit clock_gettime#154518
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
stepancheg:hermit-panic

Conversation

@stepancheg

@stepanchegstepancheg commented Mar 28, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Follow-up to #154234.

r? @Mark-Simulacrum

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 28, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Mar 28, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

Thanks!

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📋 Only open, non-draft PRs can be approved.

@stepancheg
stepancheg marked this pull request as ready for review March 28, 2026 22:14
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2026
@stepancheg

stepancheg commented Mar 28, 2026

Copy link
Copy Markdown
ContributorAuthor

Forgot to publish; fixed now.

@Mark-Simulacrum

Mark-Simulacrum commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 27242aa has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154559- JonathanBrouwer:rollup-Iut0qjN, r=JonathanBro…
80ad557
…uwer
Rollup of 11 pull requests
Successful merges:
- #154074 (don't drop arguments' temporaries in `dbg!`)
- #154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer)
- #154540 (Fix invalid type suggestion for item nested in function)
- #154549 (Add regression test for recursive lazy type alias normalization ICE)
- #153373 (Fix LegacyKeyValueFormat report from docker build: powerpc)
- #154322 (feat: reimplement `hash_map!` macro)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154518 (Panic in Hermit clock_gettime)
- #154530 (update zulip link in `std` documentation)
@rust-bors
rust-borsBot merged commit 95acbdf into rust-lang:mainMar 30, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 30, 2026
rust-timer added a commit that referenced this pull request Mar 30, 2026
@rust-timer
Unrolled build for#154518
4557462
Rollup merge of #154518 - stepancheg:hermit-panic, r=Mark-Simulacrum
Panic in Hermit clock_gettime
Follow-up to #154234.
r? @Mark-Simulacrum
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 30, 2026
@bors
Auto merge of #154559 - JonathanBrouwer:rollup-Iut0qjN, r=JonathanBro…
0ba7958
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#154074 (don't drop arguments' temporaries in `dbg!`)
- rust-lang/rust#154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer)
- rust-lang/rust#154540 (Fix invalid type suggestion for item nested in function)
- rust-lang/rust#154549 (Add regression test for recursive lazy type alias normalization ICE)
- rust-lang/rust#153373 (Fix LegacyKeyValueFormat report from docker build: powerpc)
- rust-lang/rust#154322 (feat: reimplement `hash_map!` macro)
- rust-lang/rust#154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- rust-lang/rust#154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16)
- rust-lang/rust#154508 (Fix ambiguous parsing in bootstrap.py)
- rust-lang/rust#154518 (Panic in Hermit clock_gettime)
- rust-lang/rust#154530 (update zulip link in `std` documentation)
@Wyvern

Wyvern commented Mar 31, 2026

Copy link
Copy Markdown

this commit broke hermit target build.
ref #154626

mkroening added a commit to hermit-os/rust that referenced this pull request Apr 2, 2026
@mkroening
fix compilation of time/hermit.rs
3d55f38
rust-lang#154518 has broken compiling std for Hermit by unwrapping an `i32`.
This commit converts the `i32` to an `io::Result` before unwrapping.
@mkroeningmkroening mentioned this pull request Apr 2, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 4, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154706- hermit-os:time-hermit, r=Mark-Simu…
ccac77a
…lacrum
fix compilation of time/hermit.rs
rust-lang#154518 has broken compiling std for Hermit by unwrapping an `i32`.
This PR converts the `i32` to an `io::Result` before unwrapping.
Closesrust-lang#154626.
Closeshermit-os/hermit-rs#965.
r? @Mark-Simulacrum
rust-timer added a commit that referenced this pull request Apr 5, 2026
@rust-timer
Unrolled build for#154706
17b3f93
Rollup merge of #154706 - hermit-os:time-hermit, r=Mark-Simulacrum
fix compilation of time/hermit.rs
#154518 has broken compiling std for Hermit by unwrapping an `i32`.
This PR converts the `i32` to an `io::Result` before unwrapping.
Closes#154626.
Closeshermit-os/hermit-rs#965.
r? @Mark-Simulacrum
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Apr 5, 2026
@JonathanBrouwer
Rollup merge of #154706 - hermit-os:time-hermit, r=Mark-Simulacrum
4a71a75
fix compilation of time/hermit.rs
rust-lang/rust#154518 has broken compiling std for Hermit by unwrapping an `i32`.
This PR converts the `i32` to an `io::Result` before unwrapping.
Closesrust-lang/rust#154626.
Closeshermit-os/hermit-rs#965.
r? @Mark-Simulacrum
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #154559 - JonathanBrouwer:rollup-Iut0qjN, r=JonathanBro…
f44d3ac
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#154074 (don't drop arguments' temporaries in `dbg!`)
- rust-lang/rust#154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer)
- rust-lang/rust#154540 (Fix invalid type suggestion for item nested in function)
- rust-lang/rust#154549 (Add regression test for recursive lazy type alias normalization ICE)
- rust-lang/rust#153373 (Fix LegacyKeyValueFormat report from docker build: powerpc)
- rust-lang/rust#154322 (feat: reimplement `hash_map!` macro)
- rust-lang/rust#154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- rust-lang/rust#154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16)
- rust-lang/rust#154508 (Fix ambiguous parsing in bootstrap.py)
- rust-lang/rust#154518 (Panic in Hermit clock_gettime)
- rust-lang/rust#154530 (update zulip link in `std` documentation)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@stepancheg@Mark-Simulacrum@Wyvern@rustbot