rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links` by tonywu6 · Pull Request #156022 · rust-lang/rust

tonywu6 · 2026-05-01T00:58:46Z

Fix some minor issues with how the rustdoc::broken_intra_doc_links lint labels unresolved items:

a469a4a For unresolved "extern prelude" links like ::unresolved::item
- Previously: no item named `` in scope
- Now: no item named `unresolved` in scope
eeb96fa Some malformed paths are now accounted for, for example:
- std:::path
  - Previously: no item named `std:` in scope
  - Now: has invalid path separator
- std::::path
  - Previously: no item named `` in scope
  - Now: has invalid path separator

This PR is broken down into a few commits with their own descriptions, which I hope makes reviewing easier!

- Add a check while trying to resolve parents, so that for links like [`::unresolved::path`], rustdoc will say: "no item named `unresolved` in scope" instead of: "no item named `` in scope" - Update corresponding test

rustbot · 2026-05-01T00:58:51Z

r? @lolbinarycat

rustbot has assigned @lolbinarycat.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 9 candidates
Random selection from GuillaumeGomez, fmease, lolbinarycat, notriddle

lolbinarycat

First commit is pretty good, latter commits seem to make a lot of changes that are not strictly needed.

View changes since this review

rustbot · 2026-05-08T19:54:44Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

- Check whether an unresolved path is in fact invalid. This prevents rustdoc from emitting nonsensical diagnostics like: - "no item named `std:` in scope" - "no item named `` in scope" Instead rustdoc will now say "has invalid path separator" (the same message from `MalformedGenerics::InvalidPathSeparator`) This is done by checking whether each path segment is empty or contains extra ":" after it's been split by the path separator "::". - Add a dedicated test `tests/rustdoc-ui/intra-doc/invalid-path-separator.rs` for this. - Some unrelated test snapshots have been updated because of this new check.

lolbinarycat

Looking good! Just one last thing.

(also, i'd like if the last commit's message mentioned variant_count somewhere, but it's not required)

View changes since this review

Replace a hardcoded constant with `mem::variant_count` to keep in-sync with the `ResolutionFailure` enum.

tonywu6 · 2026-05-11T09:55:08Z

@rustbot ready

lolbinarycat · 2026-05-11T18:43:31Z

@bors r+ rollup

Thanks!

rust-bors · 2026-05-11T18:43:35Z

📌 Commit 1892ccf has been approved by lolbinarycat

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links` Fix some minor issues with how the `rustdoc::broken_intra_doc_links` lint labels unresolved items: - [`a469a4a`] For unresolved "extern prelude" links like `::unresolved::item` - Previously: ```no item named `` in scope``` - Now: ```no item named `unresolved` in scope``` - [`eeb96fa`] Some malformed paths are now accounted for, for example: - `std:::path` - Previously: ```no item named `std:` in scope``` - Now: `has invalid path separator` - `std::::path` - Previously: ```no item named `` in scope``` - Now: `has invalid path separator` This PR is broken down into a few commits with their own descriptions, which I hope makes reviewing easier! Fixesrust-lang#141095 [`a469a4a`]: rust-lang@a469a4a [`eeb96fa`]: rust-lang@eeb96fa

…uwer Rollup of 11 pull requests Successful merges: - #156448 (miri subtree update) - #155023 (Introduce move expressions (`move($expr)`) ) - #156429 (Simplify `intrinsic::raw_eq` in MIR when possible) - #147672 (LLBC-linker: Do not strip debug symbols for the nvptx target anymore) - #155169 (jsondoclint: simplify code using idiomatic Rust) - #155184 ( Have arrays' `drop_glue` just unsize and call the slice version) - #156022 (rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links`) - #156442 (Show intrinsics::gpu in docs) - #156461 (LLVM 23: Specify `returnaddress` intrinsic return type) - #156462 (LLVM 23: Accept float (instead of hex) literals in codegen tests) - #156466 (Refactor `CheckAttrVisitor` so rustfmt can format it.)

Rollup merge of #156022 - tonywu6:main, r=lolbinarycat rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links` Fix some minor issues with how the `rustdoc::broken_intra_doc_links` lint labels unresolved items: - [`a469a4a`] For unresolved "extern prelude" links like `::unresolved::item` - Previously: ```no item named `` in scope``` - Now: ```no item named `unresolved` in scope``` - [`eeb96fa`] Some malformed paths are now accounted for, for example: - `std:::path` - Previously: ```no item named `std:` in scope``` - Now: `has invalid path separator` - `std::::path` - Previously: ```no item named `` in scope``` - Now: `has invalid path separator` This PR is broken down into a few commits with their own descriptions, which I hope makes reviewing easier! Fixes#141095 [`a469a4a`]: a469a4a [`eeb96fa`]: eeb96fa

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#156448 (miri subtree update) - rust-lang/rust#155023 (Introduce move expressions (`move($expr)`) ) - rust-lang/rust#156429 (Simplify `intrinsic::raw_eq` in MIR when possible) - rust-lang/rust#147672 (LLBC-linker: Do not strip debug symbols for the nvptx target anymore) - rust-lang/rust#155169 (jsondoclint: simplify code using idiomatic Rust) - rust-lang/rust#155184 ( Have arrays' `drop_glue` just unsize and call the slice version) - rust-lang/rust#156022 (rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links`) - rust-lang/rust#156442 (Show intrinsics::gpu in docs) - rust-lang/rust#156461 (LLVM 23: Specify `returnaddress` intrinsic return type) - rust-lang/rust#156462 (LLVM 23: Accept float (instead of hex) literals in codegen tests) - rust-lang/rust#156466 (Refactor `CheckAttrVisitor` so rustfmt can format it.)

rustdoc: correctly display unresolved item for "extern prelude" paths
a469a4a
- Add a check while trying to resolve parents, so that for links like [`::unresolved::path`], rustdoc will say: "no item named `unresolved` in scope" instead of: "no item named `` in scope" - Update corresponding test

rustbot assigned lolbinarycat May 1, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 1, 2026

lolbinarycat requested changes May 8, 2026
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2026

tonywu6 force-pushed the main branch from 657f989 to 0ac4399Compare May 9, 2026 19:40

lolbinarycat reviewed May 9, 2026
View reviewed changes

Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated

rustdoc: adjustment in collect_intra_doc_links
8012b9b
Replace a hardcoded constant with `mem::variant_count` to keep in-sync with the `ResolutionFailure` enum.

tonywu6 commented May 10, 2026
View reviewed changes

Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated

tonywu6 force-pushed the main branch from 0ac4399 to 8012b9bCompare May 10, 2026 07:48

rustdoc: change lint message to "invalid path separator" for consistency
1892ccf

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 11, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2026

This was referenced May 11, 2026
Rollup of 8 pull requests #156470
Closed
Rollup of 11 pull requests #156473
Merged

rust-borsBot merged commit cc43452 into rust-lang:mainMay 12, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone May 12, 2026

Navigation Menu

Uh oh!

Uh oh!

rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links` - #156022

rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links`#156022
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
tonywu6:main

tonywu6 commented May 1, 2026•
edited by rustbot
Loading

Uh oh!

rustbot commented May 1, 2026

Uh oh!

lolbinarycat left a comment •
edited by rustbot
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented May 8, 2026

Uh oh!

lolbinarycat left a comment •
edited by rustbot
Loading

Uh oh!

Uh oh!

Uh oh!

tonywu6 commented May 11, 2026

Uh oh!

lolbinarycat commented May 11, 2026

Uh oh!

rust-borsBot commented May 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

tonywu6 commented May 1, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 1, 2026

Uh oh!

lolbinarycat left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented May 8, 2026

Uh oh!

lolbinarycat left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tonywu6 commented May 11, 2026

Uh oh!

lolbinarycat commented May 11, 2026

Uh oh!

rust-borsBot commented May 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tonywu6 commented May 1, 2026•
edited by rustbot
Loading

lolbinarycat left a comment •
edited by rustbot
Loading

lolbinarycat left a comment •
edited by rustbot
Loading