Skip to content

LLVM 23: Accept float (instead of hex) literals in codegen tests - #156462

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TimNN:flit
May 12, 2026
Merged

LLVM 23: Accept float (instead of hex) literals in codegen tests#156462
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TimNN:flit

Conversation

@TimNN

@TimNNTimNN commented May 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

llvm/llvm-project#190649 changes how float constants are printed in LLVM IR.

@rustbot label llvm-main

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2026
@rustbot

rustbot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rustbotrustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label May 11, 2026
@nikic

nikic commented May 11, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-borsBot commented May 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit fdcbe90 has been approved by nikic

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 11, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#156462- TimNN:flit, r=nikic
ef7d205
LLVM 23: Accept float (instead of hex) literals in codegen tests
llvm/llvm-project#190649 changes how float constants are printed in LLVM IR.
@rustbot label llvm-main
This was referenced May 11, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request May 11, 2026
@bors
Auto merge of#156473- JonathanBrouwer:rollup-pTqyZ43, r=JonathanBro…
aa31d6d
…uwer
Rollup of 11 pull requests
Successful merges:
- #156448 (miri subtree update)
- #155023 (Introduce move expressions (`move($expr)`) )
- #156429 (Simplify `intrinsic::raw_eq` in MIR when possible)
- #147672 (LLBC-linker: Do not strip debug symbols for the nvptx target anymore)
- #155169 (jsondoclint: simplify code using idiomatic Rust)
- #155184 ( Have arrays' `drop_glue` just unsize and call the slice version)
- #156022 (rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links`)
- #156442 (Show intrinsics::gpu in docs)
- #156461 (LLVM 23: Specify `returnaddress` intrinsic return type)
- #156462 (LLVM 23: Accept float (instead of hex) literals in codegen tests)
- #156466 (Refactor `CheckAttrVisitor` so rustfmt can format it.)
@rust-bors
rust-borsBot merged commit 311605c into rust-lang:mainMay 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone May 12, 2026
@TimNN
TimNN deleted the flit branch May 12, 2026 05:23
@ZequanWuZequanWu mentioned this pull request May 12, 2026
Closed
WhySoBad pushed a commit to WhySoBad/miri that referenced this pull request May 13, 2026
@bors
Auto merge of #156473 - JonathanBrouwer:rollup-pTqyZ43, r=JonathanBro…
046b2b5
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#156448 (miri subtree update)
- rust-lang/rust#155023 (Introduce move expressions (`move($expr)`) )
- rust-lang/rust#156429 (Simplify `intrinsic::raw_eq` in MIR when possible)
- rust-lang/rust#147672 (LLBC-linker: Do not strip debug symbols for the nvptx target anymore)
- rust-lang/rust#155169 (jsondoclint: simplify code using idiomatic Rust)
- rust-lang/rust#155184 ( Have arrays' `drop_glue` just unsize and call the slice version)
- rust-lang/rust#156022 (rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links`)
- rust-lang/rust#156442 (Show intrinsics::gpu in docs)
- rust-lang/rust#156461 (LLVM 23: Specify `returnaddress` intrinsic return type)
- rust-lang/rust#156462 (LLVM 23: Accept float (instead of hex) literals in codegen tests)
- rust-lang/rust#156466 (Refactor `CheckAttrVisitor` so rustfmt can format it.)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #156473 - JonathanBrouwer:rollup-pTqyZ43, r=JonathanBro…
bcbaf79
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#156448 (miri subtree update)
- rust-lang/rust#155023 (Introduce move expressions (`move($expr)`) )
- rust-lang/rust#156429 (Simplify `intrinsic::raw_eq` in MIR when possible)
- rust-lang/rust#147672 (LLBC-linker: Do not strip debug symbols for the nvptx target anymore)
- rust-lang/rust#155169 (jsondoclint: simplify code using idiomatic Rust)
- rust-lang/rust#155184 ( Have arrays' `drop_glue` just unsize and call the slice version)
- rust-lang/rust#156022 (rustdoc: Fix cosmetic issues when reporting unresolved paths in `broken_intra_doc_links`)
- rust-lang/rust#156442 (Show intrinsics::gpu in docs)
- rust-lang/rust#156461 (LLVM 23: Specify `returnaddress` intrinsic return type)
- rust-lang/rust#156462 (LLVM 23: Accept float (instead of hex) literals in codegen tests)
- rust-lang/rust#156466 (Refactor `CheckAttrVisitor` so rustfmt can format it.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JohnTitorJohnTitor

Labels

llvm-mainMarks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TimNN@rustbot@nikic@JohnTitor