Uh oh!
There was an error while loading. Please reload this page.
platform support: add SNaN erratum to MIPS targets - #157288
Merged
Merged
Conversation
rustbot
commented
Jun 2, 2026
Collaborator
r? @ehuss rustbot has assigned @ehuss. Use Why was this reviewer chosen?The reviewer was selected based on:
|
RalfJung
commented
Jun 2, 2026
MemberAuthor
Cc @rust-lang/opsem |
ehuss
commented
Jun 2, 2026
Contributor
@RalfJung Is there a MIPS maintainer or someone else who could review the technical side? The edits themselves look fine to me. |
RalfJung
commented
Jun 2, 2026
MemberAuthor
Turns out a bunch of these targets have maintainers listed: |
chenx97
suggested changes
Jun 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
RalfJung
commented
Jun 7, 2026
MemberAuthor
Could one of the MIPS folks please confirm that this all looks correct now? :) |
Cyanoxygen
approved these changes
Jun 9, 2026
ehuss
commented
Jun 10, 2026
Contributor
Thanks for the reviews! @bors r=ehuss,chenx97,Cyanoxygen rollup |
Contributor
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jun 10, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
Rollup of 4 pull requests Successful merges: - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157691 (Move symbol hiding code to a new file)
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
Rollup of 4 pull requests Successful merges: - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157691 (Move symbol hiding code to a new file)
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
Rollup of 4 pull requests Successful merges: - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157691 (Move symbol hiding code to a new file)
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
Rollup of 4 pull requests Successful merges: - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157691 (Move symbol hiding code to a new file)
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
Rollup of 4 pull requests Successful merges: - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157691 (Move symbol hiding code to a new file)
JonathanBrouwer
commented
Jun 10, 2026
Member
@bors try jobs=aarch64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
platform support: add SNaN erratum to MIPS targets try-job: aarch64-msvc-1
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 10, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
Contributor
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
…uwer Rollup of 14 pull requests Successful merges: - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157013 (Ensure inferred let pattern types are well-formed) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust …) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
…uwer Rollup of 14 pull requests Successful merges: - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157013 (Ensure inferred let pattern types are well-formed) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust …) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 10, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jun 10, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 10, 2026
Rollup of 23 pull requests Successful merges: - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157611 (Update `browser-ui-test` version to `0.24.0`) - #157620 (Add a strategy FnMut to inject behavior into the flush cycle) - #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157719 (resolve: Partially revert "Remove a special case for dummy imports") - #156497 (fix-155516: Don't suggest wrong unwrap expect) - #156583 (Support defaults for static EIIs) - #157013 (Ensure inferred let pattern types are well-formed) - #157230 (borrowck: avoid ICE describing fields on generic params) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157384 (Add `#[rustc_dump_generics]` attribute) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157697 (Add more tests that exercise the well-formedness checking of lazy type aliases) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 11, 2026
Rollup of 23 pull requests Successful merges: - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157611 (Update `browser-ui-test` version to `0.24.0`) - #157620 (Add a strategy FnMut to inject behavior into the flush cycle) - #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157719 (resolve: Partially revert "Remove a special case for dummy imports") - #156497 (fix-155516: Don't suggest wrong unwrap expect) - #156583 (Support defaults for static EIIs) - #157013 (Ensure inferred let pattern types are well-formed) - #157230 (borrowck: avoid ICE describing fields on generic params) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157384 (Add `#[rustc_dump_generics]` attribute) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157697 (Add more tests that exercise the well-formedness checking of lazy type aliases) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jun 11, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jun 11, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jun 11, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Jun 11, 2026
…7,Cyanoxygen platform support: add SNaN erratum to MIPS targets See issue rust-lang#68925. For now we can't do much better than just documenting this.
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 11, 2026
Rollup of 31 pull requests Successful merges: - #141030 (Expand free alias types during variance computation) - #154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - #155527 (Replace printables table with `unicode_data.rs` tables) - #156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157611 (Update `browser-ui-test` version to `0.24.0`) - #157620 (Add a strategy FnMut to inject behavior into the flush cycle) - #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - #157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157719 (resolve: Partially revert "Remove a special case for dummy imports") - #155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - #155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - #155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - #156497 (fix-155516: Don't suggest wrong unwrap expect) - #156583 (Support defaults for static EIIs) - #157013 (Ensure inferred let pattern types are well-formed) - #157196 (Only suggest reborrowing a moved value where the reborrow is valid) - #157230 (borrowck: avoid ICE describing fields on generic params) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - #157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)
Uh oh!
There was an error while loading. Please reload this page.
LaneAsade pushed a commit
to LaneAsade/rust
that referenced
this pull request
Jun 11, 2026
Rollup of 31 pull requests Successful merges: - rust-lang#141030 (Expand free alias types during variance computation) - rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - rust-lang#155527 (Replace printables table with `unicode_data.rs` tables) - rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend) - rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend) - rust-lang#157601 (Emit error for unused target expression in glob and list delegations) - rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`) - rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle) - rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions) - rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports") - rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect) - rust-lang#156583 (Support defaults for static EIIs) - rust-lang#157013 (Ensure inferred let pattern types are well-formed) - rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid) - rust-lang#157230 (borrowck: avoid ICE describing fields on generic params) - rust-lang#157288 (platform support: add SNaN erratum to MIPS targets) - rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - rust-lang#157691 (Move symbol hiding code to a new file) - rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - rust-lang#157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - rust-lang#157699 (Arg splat experiment - hir FnDecl impl)
LaneAsade pushed a commit
to LaneAsade/rust
that referenced
this pull request
Jun 11, 2026
Rollup of 31 pull requests Successful merges: - rust-lang#141030 (Expand free alias types during variance computation) - rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - rust-lang#155527 (Replace printables table with `unicode_data.rs` tables) - rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend) - rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend) - rust-lang#157601 (Emit error for unused target expression in glob and list delegations) - rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`) - rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle) - rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions) - rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports") - rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect) - rust-lang#156583 (Support defaults for static EIIs) - rust-lang#157013 (Ensure inferred let pattern types are well-formed) - rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid) - rust-lang#157230 (borrowck: avoid ICE describing fields on generic params) - rust-lang#157288 (platform support: add SNaN erratum to MIPS targets) - rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - rust-lang#157691 (Move symbol hiding code to a new file) - rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - rust-lang#157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - rust-lang#157699 (Arg splat experiment - hir FnDecl impl)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
Rollup of 31 pull requests Successful merges: - rust-lang/rust#141030 (Expand free alias types during variance computation) - rust-lang/rust#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - rust-lang/rust#155527 (Replace printables table with `unicode_data.rs` tables) - rust-lang/rust#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - rust-lang/rust#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - rust-lang/rust#157282 (Fix post-monomorphization error note race in the parallel frontend) - rust-lang/rust#157352 (Make the retained dep graph deterministic under the parallel frontend) - rust-lang/rust#157601 (Emit error for unused target expression in glob and list delegations) - rust-lang/rust#157611 (Update `browser-ui-test` version to `0.24.0`) - rust-lang/rust#157620 (Add a strategy FnMut to inject behavior into the flush cycle) - rust-lang/rust#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - rust-lang/rust#157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - rust-lang/rust#157647 (Start using comptime for reflection intrinsics and their wrapper functions) - rust-lang/rust#157719 (resolve: Partially revert "Remove a special case for dummy imports") - rust-lang/rust#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - rust-lang/rust#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - rust-lang/rust#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - rust-lang/rust#156497 (fix-155516: Don't suggest wrong unwrap expect) - rust-lang/rust#156583 (Support defaults for static EIIs) - rust-lang/rust#157013 (Ensure inferred let pattern types are well-formed) - rust-lang/rust#157196 (Only suggest reborrowing a moved value where the reborrow is valid) - rust-lang/rust#157230 (borrowck: avoid ICE describing fields on generic params) - rust-lang/rust#157288 (platform support: add SNaN erratum to MIPS targets) - rust-lang/rust#157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - rust-lang/rust#157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - rust-lang/rust#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - rust-lang/rust#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - rust-lang/rust#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - rust-lang/rust#157691 (Move symbol hiding code to a new file) - rust-lang/rust#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - rust-lang/rust#157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - rust-lang/rust#157699 (Arg splat experiment - hir FnDecl impl)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #68925. For now we can't do much better than just documenting this.