Skip to content

Emit error for unused target expression in glob and list delegations - #157601

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-glob-useless-target-expr-error
Jun 11, 2026
Merged

Emit error for unused target expression in glob and list delegations#157601
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
aerooneqq:delegation-glob-useless-target-expr-error

Conversation

@aerooneqq

@aerooneqqaerooneqq commented Jun 8, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

This PR emits error if unuse target expression is specified for glob delegation. Second part of #156798.

Part of #118212.
r? @petrochenkov

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aerooneqq
aerooneqqforce-pushed the delegation-glob-useless-target-expr-error branch from e6b6c5e to c967907CompareJune 8, 2026 08:36
aerooneqq
aerooneqq commented Jun 8, 2026
View reviewed changes
Comment threadcompiler/rustc_middle/src/hir/map.rs Outdated
@petrochenkovpetrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Jun 9, 2026
@aerooneqqaerooneqq mentioned this pull request Jun 9, 2026
Closed
petrochenkov
petrochenkov reviewed Jun 9, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2026
@aerooneqq

aerooneqq commented Jun 9, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2026
petrochenkov
petrochenkov reviewed Jun 9, 2026
View reviewed changes
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
Comment threadcompiler/rustc_passes/src/delegation.rs
Comment threadcompiler/rustc_passes/src/delegation.rs Outdated
Comment threadcompiler/rustc_passes/src/delegation.rs Outdated
Comment threadcompiler/rustc_passes/src/delegation.rs Outdated
Comment threadcompiler/rustc_hir/src/hir.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2026
@aerooneqq

aerooneqq commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2026
@aerooneqq

aerooneqq commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

Added support for list delegations too, changes are not that big and connected to this PR (I've used LocalExpnId to track list delegations), if you think that it should go as separate PR I can remove this commit.

petrochenkov
petrochenkov reviewed Jun 10, 2026
View reviewed changes
Comment threadcompiler/rustc_hir/src/hir.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/delegation.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2026
@aerooneqq

aerooneqq commented Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2026
@aerooneqqaerooneqq changed the title Emit error for unused target expression in glob delegationsEmit error for unused target expression in glob and list delegationsJun 10, 2026
petrochenkov
petrochenkov reviewed Jun 10, 2026
View reviewed changes
Comment threadcompiler/rustc_passes/src/delegation.rs Outdated
Comment threadcompiler/rustc_passes/src/delegation.rs Outdated
@petrochenkov

petrochenkov commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

r=me after squashing commits.
@rustbot author
@bors delegate+

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 10, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157601- aerooneqq:delegation-glob-useless-…
5c8f182
…target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of rust-lang#156798.
Part of rust-lang#118212.
r? @petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jun 10, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jun 10, 2026
@bors
Auto merge of#157708- JonathanBrouwer:rollup-FhlrVnc, r=JonathanBro…
0b6538b
…uwer
Rollup of 14 pull requests
Successful merges:
- #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- #157282 (Fix post-monomorphization error note race in the parallel frontend)
- #157352 (Make the retained dep graph deterministic under the parallel frontend)
- #157601 (Emit error for unused target expression in glob and list delegations)
- #157626 (Autogenerate unstable compiler flag stubs for unstable-book)
- #157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- #157013 (Ensure inferred let pattern types are well-formed)
- #157288 (platform support: add SNaN erratum to MIPS targets)
- #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust …)
- #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- #157691 (Move symbol hiding code to a new file)
- #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- #157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- #157699 (Arg splat experiment - hir FnDecl impl)
rust-borsBot pushed a commit that referenced this pull request Jun 10, 2026
@bors
Auto merge of#157708- JonathanBrouwer:rollup-FhlrVnc, r=JonathanBro…
f787c60
…uwer
Rollup of 14 pull requests
Successful merges:
- #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- #157282 (Fix post-monomorphization error note race in the parallel frontend)
- #157352 (Make the retained dep graph deterministic under the parallel frontend)
- #157601 (Emit error for unused target expression in glob and list delegations)
- #157626 (Autogenerate unstable compiler flag stubs for unstable-book)
- #157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- #157013 (Ensure inferred let pattern types are well-formed)
- #157288 (platform support: add SNaN erratum to MIPS targets)
- #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust …)
- #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- #157691 (Move symbol hiding code to a new file)
- #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- #157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- #157699 (Arg splat experiment - hir FnDecl impl)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 10, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157601- aerooneqq:delegation-glob-useless-…
296d098
…target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of rust-lang#156798.
Part of rust-lang#118212.
r? @petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jun 10, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 10, 2026
@jhpratt
Rollup merge ofrust-lang#157601- aerooneqq:delegation-glob-useless-…
446f02b
…target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of rust-lang#156798.
Part of rust-lang#118212.
r? @petrochenkov
@jhprattjhpratt mentioned this pull request Jun 10, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jun 10, 2026
@bors
Auto merge of#157726- jhpratt:rollup-UIfbKIF, r=jhpratt
08d9006
Rollup of 23 pull requests
Successful merges:
- #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- #157282 (Fix post-monomorphization error note race in the parallel frontend)
- #157352 (Make the retained dep graph deterministic under the parallel frontend)
- #157601 (Emit error for unused target expression in glob and list delegations)
- #157611 (Update `browser-ui-test` version to `0.24.0`)
- #157620 (Add a strategy FnMut to inject behavior into the flush cycle)
- #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded)
- #157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- #157719 (resolve: Partially revert "Remove a special case for dummy imports")
- #156497 (fix-155516: Don't suggest wrong unwrap expect)
- #156583 (Support defaults for static EIIs)
- #157013 (Ensure inferred let pattern types are well-formed)
- #157230 (borrowck: avoid ICE describing fields on generic params)
- #157288 (platform support: add SNaN erratum to MIPS targets)
- #157350 (compiletest: ignore SVG `y` offset in by-lines comparison)
- #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- #157384 (Add `#[rustc_dump_generics]` attribute)
- #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`)
- #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- #157691 (Move symbol hiding code to a new file)
- #157697 (Add more tests that exercise the well-formedness checking of lazy type aliases)
- #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- #157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- #157699 (Arg splat experiment - hir FnDecl impl)
rust-borsBot pushed a commit that referenced this pull request Jun 11, 2026
@bors
Auto merge of#157726- jhpratt:rollup-UIfbKIF, r=jhpratt
7c53a80
Rollup of 23 pull requests
Successful merges:
- #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- #157282 (Fix post-monomorphization error note race in the parallel frontend)
- #157352 (Make the retained dep graph deterministic under the parallel frontend)
- #157601 (Emit error for unused target expression in glob and list delegations)
- #157611 (Update `browser-ui-test` version to `0.24.0`)
- #157620 (Add a strategy FnMut to inject behavior into the flush cycle)
- #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded)
- #157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- #157719 (resolve: Partially revert "Remove a special case for dummy imports")
- #156497 (fix-155516: Don't suggest wrong unwrap expect)
- #156583 (Support defaults for static EIIs)
- #157013 (Ensure inferred let pattern types are well-formed)
- #157230 (borrowck: avoid ICE describing fields on generic params)
- #157288 (platform support: add SNaN erratum to MIPS targets)
- #157350 (compiletest: ignore SVG `y` offset in by-lines comparison)
- #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- #157384 (Add `#[rustc_dump_generics]` attribute)
- #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`)
- #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- #157691 (Move symbol hiding code to a new file)
- #157697 (Add more tests that exercise the well-formedness checking of lazy type aliases)
- #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- #157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- #157699 (Arg splat experiment - hir FnDecl impl)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 11, 2026
@jhpratt
Rollup merge ofrust-lang#157601- aerooneqq:delegation-glob-useless-…
581b77b
…target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of rust-lang#156798.
Part of rust-lang#118212.
r? @petrochenkov
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 11, 2026
@jhpratt
Rollup merge ofrust-lang#157601- aerooneqq:delegation-glob-useless-…
bda1f2e
…target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of rust-lang#156798.
Part of rust-lang#118212.
r? @petrochenkov
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 11, 2026
@jhpratt
Rollup merge ofrust-lang#157601- aerooneqq:delegation-glob-useless-…
216b03a
…target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of rust-lang#156798.
Part of rust-lang#118212.
r? @petrochenkov
@jhprattjhpratt mentioned this pull request Jun 11, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 11, 2026
@jhpratt
Rollup merge ofrust-lang#157601- aerooneqq:delegation-glob-useless-…
e4e14b3
…target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of rust-lang#156798.
Part of rust-lang#118212.
r? @petrochenkov
@jhprattjhpratt mentioned this pull request Jun 11, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jun 11, 2026
@bors
Auto merge of#157739- jhpratt:rollup-i0yIAZ9, r=jhpratt
32cfe53
Rollup of 31 pull requests
Successful merges:
- #141030 (Expand free alias types during variance computation)
- #154853 (mgca: Register `ConstArgHasType` when normalizing projection consts)
- #155527 (Replace printables table with `unicode_data.rs` tables)
- #156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`)
- #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- #157282 (Fix post-monomorphization error note race in the parallel frontend)
- #157352 (Make the retained dep graph deterministic under the parallel frontend)
- #157601 (Emit error for unused target expression in glob and list delegations)
- #157611 (Update `browser-ui-test` version to `0.24.0`)
- #157620 (Add a strategy FnMut to inject behavior into the flush cycle)
- #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded)
- #157646 (Keep rename-imported main alive in dead-code analysis under `--test`)
- #157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- #157719 (resolve: Partially revert "Remove a special case for dummy imports")
- #155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os})
- #155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args)
- #155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`)
- #156497 (fix-155516: Don't suggest wrong unwrap expect)
- #156583 (Support defaults for static EIIs)
- #157013 (Ensure inferred let pattern types are well-formed)
- #157196 (Only suggest reborrowing a moved value where the reborrow is valid)
- #157230 (borrowck: avoid ICE describing fields on generic params)
- #157288 (platform support: add SNaN erratum to MIPS targets)
- #157330 (remove `IsTypeConst` from `hir::TraitItemKind`)
- #157350 (compiletest: ignore SVG `y` offset in by-lines comparison)
- #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`)
- #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- #157691 (Move symbol hiding code to a new file)
- #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- #157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- #157699 (Arg splat experiment - hir FnDecl impl)
@rust-bors
rust-borsBot merged commit fbc2411 into rust-lang:mainJun 11, 2026
12 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 11, 2026
rust-timer added a commit that referenced this pull request Jun 11, 2026
@rust-timer
Unrolled build for#157601
02716aa
Rollup merge of #157601 - aerooneqq:delegation-glob-useless-target-expr-error, r=petrochenkov
Emit error for unused target expression in glob and list delegations
This PR emits error if unuse target expression is specified for glob delegation. Second part of #156798.
Part of #118212.
r? @petrochenkov
@aerooneqqaerooneqq mentioned this pull request Jun 11, 2026
Merged
LaneAsade pushed a commit to LaneAsade/rust that referenced this pull request Jun 11, 2026
@bors@LaneAsade
Auto merge ofrust-lang#157739- jhpratt:rollup-i0yIAZ9, r=jhpratt
e870f84
Rollup of 31 pull requests
Successful merges:
- rust-lang#141030 (Expand free alias types during variance computation)
- rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts)
- rust-lang#155527 (Replace printables table with `unicode_data.rs` tables)
- rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`)
- rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend)
- rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend)
- rust-lang#157601 (Emit error for unused target expression in glob and list delegations)
- rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`)
- rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle)
- rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded)
- rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`)
- rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports")
- rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os})
- rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args)
- rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`)
- rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect)
- rust-lang#156583 (Support defaults for static EIIs)
- rust-lang#157013 (Ensure inferred let pattern types are well-formed)
- rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid)
- rust-lang#157230 (borrowck: avoid ICE describing fields on generic params)
- rust-lang#157288 (platform support: add SNaN erratum to MIPS targets)
- rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`)
- rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison)
- rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`)
- rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- rust-lang#157691 (Move symbol hiding code to a new file)
- rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- rust-lang#157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- rust-lang#157699 (Arg splat experiment - hir FnDecl impl)
LaneAsade pushed a commit to LaneAsade/rust that referenced this pull request Jun 11, 2026
@bors@LaneAsade
Auto merge ofrust-lang#157739- jhpratt:rollup-i0yIAZ9, r=jhpratt
3ab7882
Rollup of 31 pull requests
Successful merges:
- rust-lang#141030 (Expand free alias types during variance computation)
- rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts)
- rust-lang#155527 (Replace printables table with `unicode_data.rs` tables)
- rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`)
- rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend)
- rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend)
- rust-lang#157601 (Emit error for unused target expression in glob and list delegations)
- rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`)
- rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle)
- rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded)
- rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`)
- rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports")
- rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os})
- rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args)
- rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`)
- rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect)
- rust-lang#156583 (Support defaults for static EIIs)
- rust-lang#157013 (Ensure inferred let pattern types are well-formed)
- rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid)
- rust-lang#157230 (borrowck: avoid ICE describing fields on generic params)
- rust-lang#157288 (platform support: add SNaN erratum to MIPS targets)
- rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`)
- rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison)
- rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`)
- rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- rust-lang#157691 (Move symbol hiding code to a new file)
- rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- rust-lang#157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- rust-lang#157699 (Arg splat experiment - hir FnDecl impl)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157763- aerooneqq:delegation-pass-move-err…
9897647
…or, r=petrochenkov
Move unused target expression error to appropriate place and rename it
Small cleanup after rust-lang#157601.
r? @petrochenkov
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#157763- aerooneqq:delegation-pass-move-err…
c926a93
…or, r=petrochenkov
Move unused target expression error to appropriate place and rename it
Small cleanup after rust-lang#157601.
r? @petrochenkov
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 12, 2026
@jhpratt
Rollup merge ofrust-lang#157763- aerooneqq:delegation-pass-move-err…
26ae769
…or, r=petrochenkov
Move unused target expression error to appropriate place and rename it
Small cleanup after rust-lang#157601.
r? @petrochenkov
rust-timer added a commit that referenced this pull request Jun 12, 2026
@rust-timer
Unrolled build for#157763
ffe531a
Rollup merge of #157763 - aerooneqq:delegation-pass-move-error, r=petrochenkov
Move unused target expression error to appropriate place and rename it
Small cleanup after #157601.
r? @petrochenkov
pullBot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jun 13, 2026
@jhpratt
Rollup merge of #157763 - aerooneqq:delegation-pass-move-error, r=pet…
92249c6
…rochenkov
Move unused target expression error to appropriate place and rename it
Small cleanup after rust-lang/rust#157601.
r? @petrochenkov
@petrochenkovpetrochenkov mentioned this pull request Jul 15, 2026
Open
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #157739 - jhpratt:rollup-i0yIAZ9, r=jhpratt
5e8b37c
Rollup of 31 pull requests
Successful merges:
- rust-lang/rust#141030 (Expand free alias types during variance computation)
- rust-lang/rust#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts)
- rust-lang/rust#155527 (Replace printables table with `unicode_data.rs` tables)
- rust-lang/rust#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`)
- rust-lang/rust#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty)
- rust-lang/rust#157282 (Fix post-monomorphization error note race in the parallel frontend)
- rust-lang/rust#157352 (Make the retained dep graph deterministic under the parallel frontend)
- rust-lang/rust#157601 (Emit error for unused target expression in glob and list delegations)
- rust-lang/rust#157611 (Update `browser-ui-test` version to `0.24.0`)
- rust-lang/rust#157620 (Add a strategy FnMut to inject behavior into the flush cycle)
- rust-lang/rust#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded)
- rust-lang/rust#157646 (Keep rename-imported main alive in dead-code analysis under `--test`)
- rust-lang/rust#157647 (Start using comptime for reflection intrinsics and their wrapper functions)
- rust-lang/rust#157719 (resolve: Partially revert "Remove a special case for dummy imports")
- rust-lang/rust#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os})
- rust-lang/rust#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args)
- rust-lang/rust#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`)
- rust-lang/rust#156497 (fix-155516: Don't suggest wrong unwrap expect)
- rust-lang/rust#156583 (Support defaults for static EIIs)
- rust-lang/rust#157013 (Ensure inferred let pattern types are well-formed)
- rust-lang/rust#157196 (Only suggest reborrowing a moved value where the reborrow is valid)
- rust-lang/rust#157230 (borrowck: avoid ICE describing fields on generic params)
- rust-lang/rust#157288 (platform support: add SNaN erratum to MIPS targets)
- rust-lang/rust#157330 (remove `IsTypeConst` from `hir::TraitItemKind`)
- rust-lang/rust#157350 (compiletest: ignore SVG `y` offset in by-lines comparison)
- rust-lang/rust#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs)
- rust-lang/rust#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`)
- rust-lang/rust#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
- rust-lang/rust#157691 (Move symbol hiding code to a new file)
- rust-lang/rust#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N))
- rust-lang/rust#157703 (Fix doc link to Instant sub in saturating caveat)
Failed merges:
- rust-lang/rust#157699 (Arg splat experiment - hir FnDecl impl)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

F-fn_delegation`#![feature(fn_delegation)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@aerooneqq@rust-log-analyzer@petrochenkov@rustbot