Skip to content

Rewrite target checking for #[link] - #157331

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
JonathanBrouwer:target-link
Jun 3, 2026
Merged

Rewrite target checking for #[link]#157331
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
JonathanBrouwer:target-link

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jun 2, 2026

Copy link
Copy Markdown
Member

@rustbot

rustbot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2026
mejrs
mejrs approved these changes Jun 2, 2026
View reviewed changes

@mejrsmejrs left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors

rust-borsBot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4cf41e6 has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026
mejrs
mejrs requested changes Jun 2, 2026
View reviewed changes

@mejrsmejrs left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r-

Add a test for use on macro calls please.

View changes since this review

@rust-bors

This comment was marked as outdated.

Sign in to view
@rustbotrustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 2, 2026
@rustbot

This comment was marked as outdated.

Sign in to view
@mejrs

This comment was marked as outdated.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 2, 2026
@rust-bors

rust-borsBot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@JonathanBrouwer

JonathanBrouwer commented Jun 2, 2026

Copy link
Copy Markdown
MemberAuthor

Good idea, done :)
@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2026
@mejrs

mejrs commented Jun 2, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit a7d2b20 has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer

JonathanBrouwer commented Jun 3, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r=mejrs

@rust-bors

rust-borsBot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d8698f5 has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 3, 2026
@jhpratt
Rollup merge ofrust-lang#157331- JonathanBrouwer:target-link, r=mejrs
200201f
Rewrite target checking for `#[link]`
r? @mejrs
@jhprattjhpratt mentioned this pull request Jun 3, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jun 3, 2026
@bors
Auto merge of#157361- jhpratt:rollup-ua6tt0N, r=jhpratt
86e387d
Rollup of 7 pull requests
Successful merges:
- #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2)
- #156928 (Remove -Zemscripten-wasm-eh)
- #157236 (Reorganize `tests/ui/issues` [3/N])
- #157294 (Split coroutine layout computation to its own file)
- #157328 (windows: Elide division-by-zero checks in Instant::now())
- #157331 (Rewrite target checking for `#[link]`)
- #157336 (Enable `clippy::mem_replace_with_default`)
This was referenced Jun 3, 2026
Closed
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Jun 3, 2026
@bors
Auto merge of#157376- JonathanBrouwer:rollup-rUrUphg, r=JonathanBro…
e164200
…uwer
Rollup of 15 pull requests
Successful merges:
- #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2)
- #156953 (delegation: emit error when there is an infer lifetime in user-specified args)
- #157248 (delegation: move statements out of the first arg)
- #157263 (rustc_codegen_ssa: Refactor `ArchiveEntry` to include entry kind)
- #157311 (Use weak linkage for EII defaults)
- #156089 (Fix unused_parens for pinned reference patterns)
- #156928 (Remove -Zemscripten-wasm-eh)
- #157236 (Reorganize `tests/ui/issues` [3/N])
- #157287 (Const generics: remove AliasTerm::kind(), and small fixes)
- #157294 (Split coroutine layout computation to its own file)
- #157328 (windows: Elide division-by-zero checks in Instant::now())
- #157331 (Rewrite target checking for `#[link]`)
- #157336 (Enable `clippy::mem_replace_with_default`)
- #157362 (Fix trivial wf module argument/doc comment name mismatches)
- #157364 (Rewrite target checking of `rustc_dummy`)
Failed merges:
- #157332 (Rewrite target checking for `#[sanitize]`)
@rust-bors
rust-borsBot merged commit 0b27d7b into rust-lang:mainJun 3, 2026
12 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 3, 2026
rust-timer added a commit that referenced this pull request Jun 3, 2026
@rust-timer
Unrolled build for#157331
2202953
Rollup merge of #157331 - JonathanBrouwer:target-link, r=mejrs
Rewrite target checking for `#[link]`
r? @mejrs
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #157376 - JonathanBrouwer:rollup-rUrUphg, r=JonathanBro…
70b7e35
…uwer
Rollup of 15 pull requests
Successful merges:
- rust-lang/rust#155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2)
- rust-lang/rust#156953 (delegation: emit error when there is an infer lifetime in user-specified args)
- rust-lang/rust#157248 (delegation: move statements out of the first arg)
- rust-lang/rust#157263 (rustc_codegen_ssa: Refactor `ArchiveEntry` to include entry kind)
- rust-lang/rust#157311 (Use weak linkage for EII defaults)
- rust-lang/rust#156089 (Fix unused_parens for pinned reference patterns)
- rust-lang/rust#156928 (Remove -Zemscripten-wasm-eh)
- rust-lang/rust#157236 (Reorganize `tests/ui/issues` [3/N])
- rust-lang/rust#157287 (Const generics: remove AliasTerm::kind(), and small fixes)
- rust-lang/rust#157294 (Split coroutine layout computation to its own file)
- rust-lang/rust#157328 (windows: Elide division-by-zero checks in Instant::now())
- rust-lang/rust#157331 (Rewrite target checking for `#[link]`)
- rust-lang/rust#157336 (Enable `clippy::mem_replace_with_default`)
- rust-lang/rust#157362 (Fix trivial wf module argument/doc comment name mismatches)
- rust-lang/rust#157364 (Rewrite target checking of `rustc_dummy`)
Failed merges:
- rust-lang/rust#157332 (Rewrite target checking for `#[sanitize]`)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejrsmejrsmejrs requested changes

Assignees

@mejrsmejrs

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JonathanBrouwer@rustbot@mejrs