Enable `clippy::mem_replace_with_default` by JarlEvanson · Pull Request #157336 · rust-lang/rust

JarlEvanson · 2026-06-02T20:48:27Z

Enables clippy::mem_replace_with_default and fixes the errors that occur as a result.

rustbot · 2026-06-02T20:48:31Z

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: codegen, compiler, incremental, query-system
codegen, compiler, incremental, query-system expanded to 73 candidates
Random selection from 18 candidates

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-06-02T21:16:10Z

📌 Commit 3dacac8 has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

…lt, r=JonathanBrouwer Enable `clippy::mem_replace_with_default` Enables `clippy::mem_replace_with_default` and fixes the errors that occur as a result. Closesrust-lang#157245.

Rollup of 2 pull requests Successful merges: - #157328 (windows: Elide division-by-zero checks in Instant::now()) - #157336 (Enable `clippy::mem_replace_with_default`)

…hanBrouwer Enable `clippy::mem_replace_with_default` Enables `clippy::mem_replace_with_default` and fixes the errors that occur as a result. Closes#157245.

rust-bors · 2026-06-02T23:52:31Z

💔 Test for 153b697 failed: CI. Failed job:

auto - x86_64-gnu-aux (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-06-03T00:53:08Z

The job x86_64-gnu-aux failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING:end] compile::StdLink { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, crates: [], force_recompile: false } -- 0.001
##[group]Building stage1 compiler artifacts (stage0 -> stage1, x86_64-unknown-linux-gnu)
error: process didn't exit successfully: `sccache /checkout/obj/build/bootstrap/debug/rustc -vV` (exit status: 2)
--- stderr
sccache: error: Timed out waiting for server startup. Maybe the remote service is unreachable?
Run with SCCACHE_LOG=debug SCCACHE_NO_DAEMON=1 to get more information
Bootstrap failed while executing `test --stage 2 src/tools/cargo src/tools/cargotest src/tools/test-float-parse`
Build completed unsuccessfully in 0:00:36
make: *** [Makefile:51: check-aux] Error 1
local time: Tue Jun 2 23:51:55 UTC 2026
network time: Tue, 02 Jun 2026 23:51:56 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

jhpratt · 2026-06-03T03:37:28Z

@bors retry

…lt, r=JonathanBrouwer Enable `clippy::mem_replace_with_default` Enables `clippy::mem_replace_with_default` and fixes the errors that occur as a result. Closesrust-lang#157245.

Rollup of 7 pull requests Successful merges: - #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2) - #156928 (Remove -Zemscripten-wasm-eh) - #157236 (Reorganize `tests/ui/issues` [3/N]) - #157294 (Split coroutine layout computation to its own file) - #157328 (windows: Elide division-by-zero checks in Instant::now()) - #157331 (Rewrite target checking for `#[link]`) - #157336 (Enable `clippy::mem_replace_with_default`)

…lt, r=JonathanBrouwer Enable `clippy::mem_replace_with_default` Enables `clippy::mem_replace_with_default` and fixes the errors that occur as a result. Closesrust-lang#157245.

…uwer Rollup of 15 pull requests Successful merges: - #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2) - #156953 (delegation: emit error when there is an infer lifetime in user-specified args) - #157248 (delegation: move statements out of the first arg) - #157263 (rustc_codegen_ssa: Refactor `ArchiveEntry` to include entry kind) - #157311 (Use weak linkage for EII defaults) - #156089 (Fix unused_parens for pinned reference patterns) - #156928 (Remove -Zemscripten-wasm-eh) - #157236 (Reorganize `tests/ui/issues` [3/N]) - #157287 (Const generics: remove AliasTerm::kind(), and small fixes) - #157294 (Split coroutine layout computation to its own file) - #157328 (windows: Elide division-by-zero checks in Instant::now()) - #157331 (Rewrite target checking for `#[link]`) - #157336 (Enable `clippy::mem_replace_with_default`) - #157362 (Fix trivial wf module argument/doc comment name mismatches) - #157364 (Rewrite target checking of `rustc_dummy`) Failed merges: - #157332 (Rewrite target checking for `#[sanitize]`)

Rollup merge of #157336 - JarlEvanson:mem-replace-with-default, r=JonathanBrouwer Enable `clippy::mem_replace_with_default` Enables `clippy::mem_replace_with_default` and fixes the errors that occur as a result. Closes#157245.

…uwer Rollup of 15 pull requests Successful merges: - rust-lang/rust#155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2) - rust-lang/rust#156953 (delegation: emit error when there is an infer lifetime in user-specified args) - rust-lang/rust#157248 (delegation: move statements out of the first arg) - rust-lang/rust#157263 (rustc_codegen_ssa: Refactor `ArchiveEntry` to include entry kind) - rust-lang/rust#157311 (Use weak linkage for EII defaults) - rust-lang/rust#156089 (Fix unused_parens for pinned reference patterns) - rust-lang/rust#156928 (Remove -Zemscripten-wasm-eh) - rust-lang/rust#157236 (Reorganize `tests/ui/issues` [3/N]) - rust-lang/rust#157287 (Const generics: remove AliasTerm::kind(), and small fixes) - rust-lang/rust#157294 (Split coroutine layout computation to its own file) - rust-lang/rust#157328 (windows: Elide division-by-zero checks in Instant::now()) - rust-lang/rust#157331 (Rewrite target checking for `#[link]`) - rust-lang/rust#157336 (Enable `clippy::mem_replace_with_default`) - rust-lang/rust#157362 (Fix trivial wf module argument/doc comment name mismatches) - rust-lang/rust#157364 (Rewrite target checking of `rustc_dummy`) Failed merges: - rust-lang/rust#157332 (Rewrite target checking for `#[sanitize]`)

JarlEvanson added 2 commits June 2, 2026 19:55

bootstrap: enable clippy::mem_replace_with_default
3a850de

compiler: fix clippy::mem_replace_with_default warnings
3dacac8

rustbot assigned mu001999 Jun 2, 2026

JarlEvanson changed the title ~~Mem replace with default~~Enable clippy::mem_replace_with_defaultJun 2, 2026

JonathanBrouwer assigned JonathanBrouwer and unassigned mu001999 Jun 2, 2026

JonathanBrouwer approved these changes Jun 2, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2026

jhpratt mentioned this pull request Jun 2, 2026
Rollup of 2 pull requests #157340
Closed

This comment has been minimized.
Sign in to view

rust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 2, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026

jhpratt mentioned this pull request Jun 3, 2026
Rollup of 7 pull requests #157361
Closed

JonathanBrouwer mentioned this pull request Jun 3, 2026
Rollup of 9 pull requests #157372
Closed

This was referenced Jun 3, 2026
Rollup of 15 pull requests #157375
Closed
Rollup of 15 pull requests #157376
Merged

rust-borsBot merged commit f764d7c into rust-lang:mainJun 3, 2026
12 of 13 checks passed

rustbot added this to the 1.98.0 milestone Jun 3, 2026

Navigation Menu

Uh oh!

Uh oh!

Enable `clippy::mem_replace_with_default` - #157336

Enable `clippy::mem_replace_with_default`#157336
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
JarlEvanson:mem-replace-with-default

JarlEvanson commented Jun 2, 2026

Uh oh!

rustbot commented Jun 2, 2026

Uh oh!

JonathanBrouwer left a comment •
edited by rustbot
Loading

Uh oh!

rust-borsBot commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Jun 2, 2026

Uh oh!

rust-log-analyzer commented Jun 3, 2026

Uh oh!

jhpratt commented Jun 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

JarlEvanson commented Jun 2, 2026

Uh oh!

rustbot commented Jun 2, 2026

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented Jun 2, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Jun 2, 2026

Uh oh!

rust-log-analyzer commented Jun 3, 2026

Uh oh!

jhpratt commented Jun 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JonathanBrouwer left a comment •
edited by rustbot
Loading