Skip to content

Enable Enzyme on x86_64-apple - #157385

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
sgasho:x86-mac-enzyme
Jul 8, 2026
Merged

Enable Enzyme on x86_64-apple#157385
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
sgasho:x86-mac-enzyme

Conversation

@sgasho

@sgashosgasho commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

View all comments

Enable Enzyme for x86_64-apple

similar PR: #157240

r? @ZuseZ4

@rustbot

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc labels Jun 3, 2026
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 3, 2026
@ZuseZ4

Copy link
Copy Markdown
Member

@bors try=dist-x86_64-apple

@rust-bors

rust-borsBot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Unknown command "try". Run @bors help to see available commands.

@ZuseZ4

Copy link
Copy Markdown
Member

@bors try jobs=dist-x86_64-apple

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Jun 3, 2026
Enable Enzyme for x86_64-apple
try-job: dist-x86_64-apple
@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2026
@rust-bors

rust-borsBot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 22079c4 failed: CI

@sgasho

Copy link
Copy Markdown
ContributorAuthor

Cancelled due to timeout. Maybe we can try it again?

@ZuseZ4

Copy link
Copy Markdown
Member

@bors try jobs=dist-x86_64-apple

@ZuseZ4

Copy link
Copy Markdown
Member

@bors delegate=try

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Jun 4, 2026
Enable Enzyme for x86_64-apple
try-job: dist-x86_64-apple
@rust-bors

rust-borsBot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

✌️ @sgasho, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

@rust-bors

rust-borsBot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 709244e failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@sgasho

Copy link
Copy Markdown
ContributorAuthor

I reproduced the error locally on my M4 Mac by running:

./x.py dist enzyme --host=x86_64-apple-darwin --target=x86_64-apple-darwin

Since dist-x86_64-apple runs on macOS 15 "arm64", I think I can investigate this issue on my local machine.

I'll push some changes and run CI once I confirm the fix works on my Mac.

@ZuseZ4ZuseZ4 changed the title Enable Enzyme for x86_64-appleLink LLVM dynamically on x86_64-apple and enable EnzymeJun 5, 2026
@ZuseZ4

Copy link
Copy Markdown
Member

cc @madsmtm just for visibility. We moved over aarch64 to dynamic linking in #157205, and with this we'll also move x86_64 so they will still be similar, going forward.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/enzyme

cc @ZuseZ4

@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@sgasho

Copy link
Copy Markdown
ContributorAuthor

dist ok

スクリーンショット 2026-06-29 23 26 08

@sgashosgasho changed the title Link LLVM dynamically on x86_64-apple and enable EnzymeEnable Enzyme on x86_64-appleJun 29, 2026
@jieyouxu

Copy link
Copy Markdown
Member

@bors try jobs=dist-x86_64-apple

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Jun 30, 2026
Enable Enzyme on x86_64-apple
try-job: dist-x86_64-apple
@jieyouxujieyouxu self-assigned this Jun 30, 2026
@rust-bors

rust-borsBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 54a22f2 (54a22f27ea7ae152f010d7fc7da8012656693414)
Base parent: 0966944 (096694416a41840709140eb0fd0ca193d1a3e6ba)

@jieyouxujieyouxu removed their assignment Jun 30, 2026
@sgasho

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2026
@ZuseZ4

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-borsBot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 34e0561 has been approved by ZuseZ4

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
Enable Enzyme on x86_64-apple
Enable Enzyme for x86_64-apple
similar PR: rust-lang#157240
r? @ZuseZ4
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
Enable Enzyme on x86_64-apple
Enable Enzyme for x86_64-apple
similar PR: rust-lang#157240
r? @ZuseZ4
rust-borsBot pushed a commit that referenced this pull request Jul 7, 2026
…uwer
Rollup of 18 pull requests
Successful merges:
- #157385 (Enable Enzyme on x86_64-apple)
- #157561 (rustdoc: do not include extra stuff in span)
- #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158621 (disallow `extern "custom"` on wasm and spirv targets)
- #158690 (delegation: support mapping of all arguments with `Self` type)
- #158696 (Rename some `body_id` to `body_def_id`)
- #158697 (Fixes for QNX SDP 8)
- #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
- #157801 (Rewrite safety requirements for `Allocator` impls)
- #158333 (Fix typetree generation for differentiated functions)
- #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
- #158791 (Avoid unused braces lint for macro generated arguments)
- #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- #158841 (Avoid final override ICE for RPITIT associated types)
- #158889 (tests: catch up with LLVM returning f128 on the stack)
- #158905 (delegation: add constraints to new generic args)
rust-borsBot pushed a commit that referenced this pull request Jul 7, 2026
…uwer
Rollup of 19 pull requests
Successful merges:
- #156016 (view-types: store view types in the AST)
- #157385 (Enable Enzyme on x86_64-apple)
- #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
- #158621 (disallow `extern "custom"` on wasm and spirv targets)
- #158690 (delegation: support mapping of all arguments with `Self` type)
- #158696 (Rename some `body_id` to `body_def_id`)
- #158697 (Fixes for QNX SDP 8)
- #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
- #157801 (Rewrite safety requirements for `Allocator` impls)
- #158085 (rustdoc: Fix sidebar heading order)
- #158333 (Fix typetree generation for differentiated functions)
- #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
- #158791 (Avoid unused braces lint for macro generated arguments)
- #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- #158841 (Avoid final override ICE for RPITIT associated types)
- #158889 (tests: catch up with LLVM returning f128 on the stack)
- #158905 (delegation: add constraints to new generic args)
- #158922 (tests: clean up over-constraint on LLVM feature count)
Failed merges:
- #158617 (allow mGCA const arguments to fall back to anon consts)
@rust-bors
rust-borsBot merged commit d82ce7d into rust-lang:mainJul 8, 2026
14 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 8, 2026
rust-timer added a commit that referenced this pull request Jul 8, 2026
Rollup merge of #157385 - sgasho:x86-mac-enzyme, r=ZuseZ4
Enable Enzyme on x86_64-apple
Enable Enzyme for x86_64-apple
similar PR: #157240
r? @ZuseZ4
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 19 pull requests
Successful merges:
- rust-lang/rust#156016 (view-types: store view types in the AST)
- rust-lang/rust#157385 (Enable Enzyme on x86_64-apple)
- rust-lang/rust#158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
- rust-lang/rust#158621 (disallow `extern "custom"` on wasm and spirv targets)
- rust-lang/rust#158690 (delegation: support mapping of all arguments with `Self` type)
- rust-lang/rust#158696 (Rename some `body_id` to `body_def_id`)
- rust-lang/rust#158697 (Fixes for QNX SDP 8)
- rust-lang/rust#158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
- rust-lang/rust#157801 (Rewrite safety requirements for `Allocator` impls)
- rust-lang/rust#158085 (rustdoc: Fix sidebar heading order)
- rust-lang/rust#158333 (Fix typetree generation for differentiated functions)
- rust-lang/rust#158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- rust-lang/rust#158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
- rust-lang/rust#158791 (Avoid unused braces lint for macro generated arguments)
- rust-lang/rust#158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- rust-lang/rust#158841 (Avoid final override ICE for RPITIT associated types)
- rust-lang/rust#158889 (tests: catch up with LLVM returning f128 on the stack)
- rust-lang/rust#158905 (delegation: add constraints to new generic args)
- rust-lang/rust#158922 (tests: clean up over-constraint on LLVM feature count)
Failed merges:
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-testsuiteArea: The testsuite used to check the correctness of rustcF-autodiff`#![feature(autodiff)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sgasho@rustbot@ZuseZ4@rust-log-analyzer@jieyouxu