Skip to content

powerpc64le_unknown_freebsd.rs: link with -lgcc - #158646

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
pkubaj:patch-1
Jul 8, 2026
Merged

powerpc64le_unknown_freebsd.rs: link with -lgcc#158646
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
pkubaj:patch-1

Conversation

@pkubaj

Copy link
Copy Markdown
Contributor

Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.

@rustbot

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @camelid

rustbot has assigned @camelid.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 16 candidates

@rust-log-analyzer

This comment has been minimized.

Comment threadcompiler/rustc_target/src/spec/targets/powerpc64le_unknown_freebsd.rs Outdated
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double.
128 bit arithmetics are implemented in LLVM's compiler_rt, which is
FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0
succeeds - noop for earlier releases.
@bjorn3

Copy link
Copy Markdown
Member

LGTM, but let's cc @asomers@MikaelUrankar as target maintainers

@MikaelUrankar

Copy link
Copy Markdown
Contributor

lgtm

@bjorn3

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf03fc3 has been approved by bjorn3

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jul 7, 2026
powerpc64le_unknown_freebsd.rs: link with -lgcc
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.
@m-ou-sem-ou-se mentioned this pull request Jul 7, 2026
rust-borsBot pushed a commit that referenced this pull request Jul 7, 2026
Rollup of 8 pull requests
Successful merges:
- #156968 (diagnostics: suggest generic_const_args for const ops)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158690 (delegation: support mapping of all arguments with `Self` type)
- #158696 (Rename some `body_id` to `body_def_id`)
- #158333 (Fix typetree generation for differentiated functions)
- #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- #158905 (delegation: add constraints to new generic args)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
powerpc64le_unknown_freebsd.rs: link with -lgcc
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
powerpc64le_unknown_freebsd.rs: link with -lgcc
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.
rust-borsBot pushed a commit that referenced this pull request Jul 7, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158621 (disallow `extern "custom"` on wasm and spirv targets)
- #158690 (delegation: support mapping of all arguments with `Self` type)
- #158696 (Rename some `body_id` to `body_def_id`)
- #158333 (Fix typetree generation for differentiated functions)
- #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- #158791 (Avoid unused braces lint for macro generated arguments)
- #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- #158889 (tests: catch up with LLVM returning f128 on the stack)
- #158905 (delegation: add constraints to new generic args)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 7, 2026
powerpc64le_unknown_freebsd.rs: link with -lgcc
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.
rust-borsBot pushed a commit that referenced this pull request Jul 7, 2026
…uwer
Rollup of 18 pull requests
Successful merges:
- #157385 (Enable Enzyme on x86_64-apple)
- #157561 (rustdoc: do not include extra stuff in span)
- #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
- #158617 (allow mGCA const arguments to fall back to anon consts)
- #158621 (disallow `extern "custom"` on wasm and spirv targets)
- #158690 (delegation: support mapping of all arguments with `Self` type)
- #158696 (Rename some `body_id` to `body_def_id`)
- #158697 (Fixes for QNX SDP 8)
- #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
- #157801 (Rewrite safety requirements for `Allocator` impls)
- #158333 (Fix typetree generation for differentiated functions)
- #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
- #158791 (Avoid unused braces lint for macro generated arguments)
- #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- #158841 (Avoid final override ICE for RPITIT associated types)
- #158889 (tests: catch up with LLVM returning f128 on the stack)
- #158905 (delegation: add constraints to new generic args)
rust-borsBot pushed a commit that referenced this pull request Jul 7, 2026
…uwer
Rollup of 19 pull requests
Successful merges:
- #156016 (view-types: store view types in the AST)
- #157385 (Enable Enzyme on x86_64-apple)
- #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
- #158621 (disallow `extern "custom"` on wasm and spirv targets)
- #158690 (delegation: support mapping of all arguments with `Self` type)
- #158696 (Rename some `body_id` to `body_def_id`)
- #158697 (Fixes for QNX SDP 8)
- #158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
- #157801 (Rewrite safety requirements for `Allocator` impls)
- #158085 (rustdoc: Fix sidebar heading order)
- #158333 (Fix typetree generation for differentiated functions)
- #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
- #158791 (Avoid unused braces lint for macro generated arguments)
- #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- #158841 (Avoid final override ICE for RPITIT associated types)
- #158889 (tests: catch up with LLVM returning f128 on the stack)
- #158905 (delegation: add constraints to new generic args)
- #158922 (tests: clean up over-constraint on LLVM feature count)
Failed merges:
- #158617 (allow mGCA const arguments to fall back to anon consts)
@rust-bors
rust-borsBot merged commit 2b2a45c into rust-lang:mainJul 8, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 8, 2026
rust-timer added a commit that referenced this pull request Jul 8, 2026
Rollup merge of #158646 - pkubaj:patch-1, r=bjorn3
powerpc64le_unknown_freebsd.rs: link with -lgcc
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 19 pull requests
Successful merges:
- rust-lang/rust#156016 (view-types: store view types in the AST)
- rust-lang/rust#157385 (Enable Enzyme on x86_64-apple)
- rust-lang/rust#158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS)
- rust-lang/rust#158621 (disallow `extern "custom"` on wasm and spirv targets)
- rust-lang/rust#158690 (delegation: support mapping of all arguments with `Self` type)
- rust-lang/rust#158696 (Rename some `body_id` to `body_def_id`)
- rust-lang/rust#158697 (Fixes for QNX SDP 8)
- rust-lang/rust#158760 (Clarify that `LocalKey::try_with` may return `AccessError`)
- rust-lang/rust#157801 (Rewrite safety requirements for `Allocator` impls)
- rust-lang/rust#158085 (rustdoc: Fix sidebar heading order)
- rust-lang/rust#158333 (Fix typetree generation for differentiated functions)
- rust-lang/rust#158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
- rust-lang/rust#158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
- rust-lang/rust#158791 (Avoid unused braces lint for macro generated arguments)
- rust-lang/rust#158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts)
- rust-lang/rust#158841 (Avoid final override ICE for RPITIT associated types)
- rust-lang/rust#158889 (tests: catch up with LLVM returning f128 on the stack)
- rust-lang/rust#158905 (delegation: add constraints to new generic args)
- rust-lang/rust#158922 (tests: clean up over-constraint on LLVM feature count)
Failed merges:
- rust-lang/rust#158617 (allow mGCA const arguments to fall back to anon consts)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@pkubaj@rustbot@rust-log-analyzer@bjorn3@MikaelUrankar@camelid