Add field-wise CoerceShared reborrow tests by P8L1 · Pull Request #157490 · rust-lang/rust

P8L1 · 2026-06-05T16:33:18Z

P8L1 · 2026-06-05T16:33:41Z

@rustbot label F-Reborrow

aapoalas

Sorry, I must've mistyped the crashes path from memory and led you astray: there is an existing tests/crashes folder that we should put the currently-crashing tests into. At the same time the README.md change become unnecessary.

View changes since this review

rustbot · 2026-06-05T17:57:09Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-06-08T19:46:12Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

rustbot · 2026-06-08T19:46:14Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

P8L1 · 2026-06-08T19:50:20Z

Sorry, I must've mistyped the crashes path from memory and led you astray: there is an existing tests/crashes folder that we should put the currently-crashing tests into. At the same time the README.md change become unnecessary.
View changes since this review

I suspected something like that but ended up using the path you gave me just to be sure anyway. Thanks for the clarification.

P8L1 · 2026-06-08T19:50:33Z

@rustbot ready

P8L1 · 2026-06-09T10:22:07Z

I just noticed I have not yet removed all of the "//@ normalize-stderr: "\n\n\z" -> "\n"" will make a commit to remove those now 😅

aapoalas

You forgot to bless a little, I think :) Other than that, looks good to me.

View changes since this review

aapoalas · 2026-06-11T18:04:22Z

r=me after blessing

@bors delegate+

rust-bors · 2026-06-11T18:04:25Z

✌️ @P8L1, you can now approve this pull request!

If @aapoalas told you to "r=me" after making some further change, then please make that change and post @bors r=aapoalas.

View changes since this delegation.

P8L1 · 2026-06-12T08:20:57Z

@bors r=aapoalas

rust-bors · 2026-06-12T08:21:01Z

📌 Commit 602df86 has been approved by aapoalas

It is now in the queue for this repository.

rust-bors · 2026-06-12T08:21:28Z

⚠️ A new commit 602df86846ad6edfaae145a1bca7a8108af45dab was pushed.

This pull request was unapproved.

P8L1 · 2026-06-12T08:21:39Z

r=me after blessing
@bors delegate+

I did indeed, thanks so much for the swift reviews!

P8L1 · 2026-06-12T08:23:25Z

@bors r=aapoalas

rust-bors · 2026-06-12T08:30:39Z

📌 Commit 602df86 has been approved by aapoalas

It is now in the queue for this repository.

@aapoalas

…rrow-tests, r=aapoalas Add field-wise CoerceShared reborrow tests Title. Split from rust-lang#157101 r? @aapoalas

@aapoalas

…rrow-tests, r=aapoalas Add field-wise CoerceShared reborrow tests Title. Split from rust-lang#157101 r? @aapoalas

@aapoalas

…rrow-tests, r=aapoalas Add field-wise CoerceShared reborrow tests Title. Split from rust-lang#157101 r? @aapoalas

…uwer Rollup of 17 pull requests Successful merges: - #156950 (Staticlib rename internal symbols) - #157322 (test pre-stabilization items on CI) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N)) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))

@aapoalas

…rrow-tests, r=aapoalas Add field-wise CoerceShared reborrow tests Title. Split from rust-lang#157101 r? @aapoalas

…uwer Rollup of 23 pull requests Successful merges: - #144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - #153238 (debuginfo: slices are DW_TAG_array_type's) - #157112 (Update aarch64-unknown-freebsd target description) - #157322 (test pre-stabilization items on CI) - #157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157672 (Region inference: Simplify initialisation of region values) - #157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157818 (miri subtree update) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157079 (Don't recover `&raw EXPR` as a missing comma) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

@aapoalas

Rollup merge of #157490 - P8L1:split/coerceshared-field-reborrow-tests, r=aapoalas Add field-wise CoerceShared reborrow tests Title. Split from #157101 r? @aapoalas

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - rust-lang/rust#153238 (debuginfo: slices are DW_TAG_array_type's) - rust-lang/rust#157112 (Update aarch64-unknown-freebsd target description) - rust-lang/rust#157322 (test pre-stabilization items on CI) - rust-lang/rust#157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - rust-lang/rust#157490 (Add field-wise CoerceShared reborrow tests) - rust-lang/rust#157655 (Make Share::share final and improve docs) - rust-lang/rust#157672 (Region inference: Simplify initialisation of region values) - rust-lang/rust#157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - rust-lang/rust#157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - rust-lang/rust#157796 (rustdoc: Some more lazy formatting) - rust-lang/rust#157818 (miri subtree update) - rust-lang/rust#157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - rust-lang/rust#157079 (Don't recover `&raw EXPR` as a missing comma) - rust-lang/rust#157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - rust-lang/rust#157622 (Disable retagging for variadic arguments in const-eval) - rust-lang/rust#157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - rust-lang/rust#157695 (Extend capabilities of `TypeFoldable_Generic`) - rust-lang/rust#157766 (interpret: avoid computing layout of sized raw pointee) - rust-lang/rust#157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - rust-lang/rust#157795 (revert 157013) - rust-lang/rust#157798 (Prevent approving PRs that wait for Crater or formal decisions) - rust-lang/rust#157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - rust-lang/rust#157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

rustbot assigned aapoalas Jun 5, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 5, 2026

rustbot added the F-reborrow `#![feature(reborrow)]`; see #145612 label Jun 5, 2026

P8L1 mentioned this pull request Jun 5, 2026
Support field-wise CoerceShared reborrows #157101
Closed

This comment has been minimized.
Sign in to view

aapoalas requested changes Jun 5, 2026
View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 5, 2026

aapoalas mentioned this pull request Jun 5, 2026
Add CoerceShared field-wise reborrow WF checks #157489
Merged

P8L1 force-pushed the split/coerceshared-field-reborrow-tests branch from ba7b0f0 to 2c51b3aCompare June 8, 2026 19:46

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 8, 2026

P8L1 requested a review from aapoalas June 8, 2026 19:50

Add missing tests and adress concerns
e789c33

P8L1 force-pushed the split/coerceshared-field-reborrow-tests branch from 2c51b3a to e789c33Compare June 8, 2026 19:52

This comment has been minimized.
Sign in to view

Remove redundant normalize-stderr directives
16e2fd2

P8L1 force-pushed the split/coerceshared-field-reborrow-tests branch from 50db5e5 to 16e2fd2Compare June 9, 2026 11:24

This comment has been minimized.
Sign in to view

aapoalas requested changes Jun 11, 2026
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2026

Bless reborrow UI tests
602df86

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2026

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 12, 2026
Rollup merge ofrust-lang#157490- P8L1:split/coerceshared-field-rebo…
60ff131
…rrow-tests, r=aapoalas Add field-wise CoerceShared reborrow tests Title. Split from rust-lang#157101 r? @aapoalas

GuillaumeGomez mentioned this pull request Jun 12, 2026
Rollup of 9 pull requests #157804
Closed

JonathanBrouwer mentioned this pull request Jun 12, 2026
Rollup of 14 pull requests #157809
Closed

JonathanBrouwer mentioned this pull request Jun 12, 2026
Rollup of 17 pull requests #157815
Closed

This was referenced Jun 12, 2026
Rollup of 23 pull requests #157827
Closed
Rollup of 23 pull requests #157828
Merged

rust-borsBot merged commit 264355d into rust-lang:mainJun 12, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 12, 2026

rust-timer added a commit that referenced this pull request Jun 13, 2026
Unrolled build for#157490
418f09e
Rollup merge of #157490 - P8L1:split/coerceshared-field-reborrow-tests, r=aapoalas Add field-wise CoerceShared reborrow tests Title. Split from #157101 r? @aapoalas

Uh oh!

Uh oh!

Conversation

P8L1 commented Jun 5, 2026

Uh oh!

P8L1 commented Jun 5, 2026

Uh oh!

This comment has been minimized.

aapoalas left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jun 5, 2026

Uh oh!

rustbot commented Jun 8, 2026

Uh oh!

rustbot commented Jun 8, 2026

Uh oh!

P8L1 commented Jun 8, 2026

Uh oh!

P8L1 commented Jun 8, 2026

Uh oh!

P8L1 commented Jun 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

aapoalas left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aapoalas commented Jun 11, 2026

Uh oh!

rust-borsBot commented Jun 11, 2026

Uh oh!

P8L1 commented Jun 12, 2026

Uh oh!

rust-borsBot commented Jun 12, 2026

Uh oh!

rust-borsBot commented Jun 12, 2026

Uh oh!

P8L1 commented Jun 12, 2026

Uh oh!

P8L1 commented Jun 12, 2026

Uh oh!

rust-borsBot commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aapoalas left a comment •
edited by rustbot
Loading

P8L1 commented Jun 9, 2026•
edited
Loading

aapoalas left a comment •
edited by rustbot
Loading