Uh oh!
There was an error while loading. Please reload this page.
-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver - #157684
Merged
rust-bors[bot] merged 1 commit intoJun 12, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
matthiaskrgr
commented
Jun 10, 2026
Member
cyrgani dropped a more minimal version since the pr was opened: |
BoxyUwUforce-pushed
the
empty_assumptions_in_solver_relating
branch
from
June 11, 2026 21:51
7d54dc5 to
67cb81eCompareBoxyUwUforce-pushed
the
empty_assumptions_in_solver_relating
branch
from
June 11, 2026 21:53
67cb81e to
390c6a4CompareBoxyUwU
marked this pull request as ready for review
June 11, 2026 21:54
lcnr
commented
Jun 12, 2026
Contributor
@bors r+ rollup |
Contributor
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 12, 2026
…r_relating, r=lcnr -Zassumptions-on-binders: insert empty assumptions when entering binders in the solver r? lcnr fixesrust-lang#157678 computing assumptions in solver relating seems annoying/generally cant move that onto `InferCtxtLike` because no trait solving is possible there (not that we currently do any when computing assumptions.. thinky.. need to think more :3)
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 12, 2026
…r_relating, r=lcnr -Zassumptions-on-binders: insert empty assumptions when entering binders in the solver r? lcnr fixesrust-lang#157678 computing assumptions in solver relating seems annoying/generally cant move that onto `InferCtxtLike` because no trait solving is possible there (not that we currently do any when computing assumptions.. thinky.. need to think more :3)
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 12, 2026
…r_relating, r=lcnr -Zassumptions-on-binders: insert empty assumptions when entering binders in the solver r? lcnr fixesrust-lang#157678 computing assumptions in solver relating seems annoying/generally cant move that onto `InferCtxtLike` because no trait solving is possible there (not that we currently do any when computing assumptions.. thinky.. need to think more :3)
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 12, 2026
…uwer Rollup of 17 pull requests Successful merges: - #156950 (Staticlib rename internal symbols) - #157322 (test pre-stabilization items on CI) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N)) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 12, 2026
…uwer Rollup of 17 pull requests Successful merges: - #156950 (Staticlib rename internal symbols) - #157322 (test pre-stabilization items on CI) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N)) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 12, 2026
…r_relating, r=lcnr -Zassumptions-on-binders: insert empty assumptions when entering binders in the solver r? lcnr fixesrust-lang#157678 computing assumptions in solver relating seems annoying/generally cant move that onto `InferCtxtLike` because no trait solving is possible there (not that we currently do any when computing assumptions.. thinky.. need to think more :3)
This was referenced Jun 12, 2026
rust-borsBot
pushed a commit
that referenced
this pull request
Jun 12, 2026
…uwer Rollup of 23 pull requests Successful merges: - #144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - #153238 (debuginfo: slices are DW_TAG_array_type's) - #157112 (Update aarch64-unknown-freebsd target description) - #157322 (test pre-stabilization items on CI) - #157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157672 (Region inference: Simplify initialisation of region values) - #157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157818 (miri subtree update) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157079 (Don't recover `&raw EXPR` as a missing comma) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Jun 12, 2026
Rollup merge of #157684 - BoxyUwU:empty_assumptions_in_solver_relating, r=lcnr -Zassumptions-on-binders: insert empty assumptions when entering binders in the solver r? lcnr fixes#157678 computing assumptions in solver relating seems annoying/generally cant move that onto `InferCtxtLike` because no trait solving is possible there (not that we currently do any when computing assumptions.. thinky.. need to think more :3)
pullBot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jun 13, 2026
…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - rust-lang/rust#153238 (debuginfo: slices are DW_TAG_array_type's) - rust-lang/rust#157112 (Update aarch64-unknown-freebsd target description) - rust-lang/rust#157322 (test pre-stabilization items on CI) - rust-lang/rust#157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - rust-lang/rust#157490 (Add field-wise CoerceShared reborrow tests) - rust-lang/rust#157655 (Make Share::share final and improve docs) - rust-lang/rust#157672 (Region inference: Simplify initialisation of region values) - rust-lang/rust#157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - rust-lang/rust#157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - rust-lang/rust#157796 (rustdoc: Some more lazy formatting) - rust-lang/rust#157818 (miri subtree update) - rust-lang/rust#157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - rust-lang/rust#157079 (Don't recover `&raw EXPR` as a missing comma) - rust-lang/rust#157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - rust-lang/rust#157622 (Disable retagging for variadic arguments in const-eval) - rust-lang/rust#157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - rust-lang/rust#157695 (Extend capabilities of `TypeFoldable_Generic`) - rust-lang/rust#157766 (interpret: avoid computing layout of sized raw pointee) - rust-lang/rust#157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - rust-lang/rust#157795 (revert 157013) - rust-lang/rust#157798 (Prevent approving PRs that wait for Crater or formal decisions) - rust-lang/rust#157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - rust-lang/rust#157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? lcnr
fixes#157678
computing assumptions in solver relating seems annoying/generally cant move that onto
InferCtxtLikebecause no trait solving is possible there (not that we currently do any when computing assumptions.. thinky.. need to think more :3)