Skip to content

unstable book: Document diagnostic_on_unknown feature - #159155

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mejrs:doc_on_unknown
Jul 15, 2026
Merged

unstable book: Document diagnostic_on_unknown feature#159155
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mejrs:doc_on_unknown

Conversation

@mejrs

@mejrsmejrs commented Jul 11, 2026

Copy link
Copy Markdown
Member

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2026
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

r? @khyperia

rustbot has assigned @khyperia.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 16 candidates

@khyperia

khyperia commented Jul 13, 2026

Copy link
Copy Markdown
Member

apologies, I've fallen ill and probably won't get around to reviewing this for a while, so I'm rerolling

r? compiler

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 13, 2026
@rustbotrustbot assigned nnethercote and unassigned khyperiaJul 13, 2026
nnethercote
nnethercote reviewed Jul 14, 2026
View reviewed changes
Comment threadsrc/doc/unstable-book/src/language-features/diagnostic-on-unknown.md Outdated

### Edition differences

> In the 2015 edition, use paths are relative to the crate root. For example, `use empty` will be resolved relative to the crate root and resolution will not encounter the `mod empty {}` declaration.

@nnethercotennethercoteJul 14, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear to me why this section has the > in front of each line?

View changes since the review

@nnethercote

nnethercote commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Looks good except for the > quoting in the last section. r=me with that fixed or if there's a good reason for it.

@mejrs

mejrs commented Jul 14, 2026

Copy link
Copy Markdown
MemberAuthor

use paths are relative to the crate root

A vestigial from an attempt to style it like the reference does, I'll go ahead and remove it.

@nnethercote

nnethercote commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 60d5c32 has been approved by nnethercote

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 14, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#159155- mejrs:doc_on_unknown, r=nnethercote
a93a303
unstable book: Document `diagnostic_on_unknown` feature
Rendered: https://github.com/mejrs/rust/blob/9476366e0b027db32ff1edfad52312b4cdf4ef07/src/doc/unstable-book/src/language-features/diagnostic-on-unknown.md
cc @weiznich
This was referenced Jul 14, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 14, 2026
@bors
Auto merge of#159293- JonathanBrouwer:rollup-bZ1e8vF, r=JonathanBro…
4eab515
…uwer
Rollup of 22 pull requests
Successful merges:
- #156047 (Fix trait method resolution on an adjusted never type)
- #157824 (Comptime inherent impls)
- #158235 (Store `DefId` instead of `EiiDecl` in `EiiImplResolution::Known`)
- #158723 (Support EII on Windows MSVC)
- #158993 (rerun in original typing mode if we meet any opaques in post analysis)
- #159160 (Make `HasTokens` a sub-trait of `HasAttrs`.)
- #159183 (Introduce InstanceKind::LlvmIntrinsic)
- #159251 (Bump rustc-perf submodule)
- #155013 (Suggest the `[const] Destruct` bound for type parameters in const functions when missing)
- #159155 (unstable book: Document `diagnostic_on_unknown` feature)
- #159235 (Add regression test for #95719)
- #159243 (inline Once wait and wait_force)
- #159255 (Replace shortened type with `_` instead of `...` as placeholder)
- #159259 (Add regression test for #144033)
- #159265 (bootstrap: skip intrinsic-test when rustfmt is unavailable)
- #159269 (disable range-len-try-from.rs on s390x)
- #159272 (slice: make swap delegate to swap_unchecked)
- #159274 (bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run`)
- #159275 (remove obsolete comment)
- #159277 (Construct `tokens` for attrs made by `mk_attr_word` and other variants)
- #159283 (Remove obsolete verbose flag from deref/ref suggestions)
- #159290 (rustc-dev-guide subtree update)
rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of#159293- JonathanBrouwer:rollup-bZ1e8vF, r=JonathanBro…
38a0576
…uwer
Rollup of 22 pull requests
Successful merges:
- #156047 (Fix trait method resolution on an adjusted never type)
- #157824 (Comptime inherent impls)
- #158235 (Store `DefId` instead of `EiiDecl` in `EiiImplResolution::Known`)
- #158723 (Support EII on Windows MSVC)
- #158993 (rerun in original typing mode if we meet any opaques in post analysis)
- #159160 (Make `HasTokens` a sub-trait of `HasAttrs`.)
- #159183 (Introduce InstanceKind::LlvmIntrinsic)
- #159251 (Bump rustc-perf submodule)
- #155013 (Suggest the `[const] Destruct` bound for type parameters in const functions when missing)
- #159155 (unstable book: Document `diagnostic_on_unknown` feature)
- #159235 (Add regression test for #95719)
- #159243 (inline Once wait and wait_force)
- #159255 (Replace shortened type with `_` instead of `...` as placeholder)
- #159259 (Add regression test for #144033)
- #159265 (bootstrap: skip intrinsic-test when rustfmt is unavailable)
- #159269 (disable range-len-try-from.rs on s390x)
- #159272 (slice: make swap delegate to swap_unchecked)
- #159274 (bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run`)
- #159275 (remove obsolete comment)
- #159277 (Construct `tokens` for attrs made by `mk_attr_word` and other variants)
- #159283 (Remove obsolete verbose flag from deref/ref suggestions)
- #159290 (rustc-dev-guide subtree update)
@rust-bors
rust-borsBot merged commit 91d73e9 into rust-lang:mainJul 15, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 15, 2026
rust-timer added a commit that referenced this pull request Jul 15, 2026
@rust-timer
Unrolled build for#159155
15d74cf
Rollup merge of #159155 - mejrs:doc_on_unknown, r=nnethercote
unstable book: Document `diagnostic_on_unknown` feature
Rendered: https://github.com/mejrs/rust/blob/9476366e0b027db32ff1edfad52312b4cdf4ef07/src/doc/unstable-book/src/language-features/diagnostic-on-unknown.md
cc @weiznich
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jul 15, 2026
@bors
Auto merge of #159293 - JonathanBrouwer:rollup-bZ1e8vF, r=JonathanBro…
b83abd8
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#156047 (Fix trait method resolution on an adjusted never type)
- rust-lang/rust#157824 (Comptime inherent impls)
- rust-lang/rust#158235 (Store `DefId` instead of `EiiDecl` in `EiiImplResolution::Known`)
- rust-lang/rust#158723 (Support EII on Windows MSVC)
- rust-lang/rust#158993 (rerun in original typing mode if we meet any opaques in post analysis)
- rust-lang/rust#159160 (Make `HasTokens` a sub-trait of `HasAttrs`.)
- rust-lang/rust#159183 (Introduce InstanceKind::LlvmIntrinsic)
- rust-lang/rust#159251 (Bump rustc-perf submodule)
- rust-lang/rust#155013 (Suggest the `[const] Destruct` bound for type parameters in const functions when missing)
- rust-lang/rust#159155 (unstable book: Document `diagnostic_on_unknown` feature)
- rust-lang/rust#159235 (Add regression test for rust-lang/rust#95719)
- rust-lang/rust#159243 (inline Once wait and wait_force)
- rust-lang/rust#159255 (Replace shortened type with `_` instead of `...` as placeholder)
- rust-lang/rust#159259 (Add regression test for rust-lang/rust#144033)
- rust-lang/rust#159265 (bootstrap: skip intrinsic-test when rustfmt is unavailable)
- rust-lang/rust#159269 (disable range-len-try-from.rs on s390x)
- rust-lang/rust#159272 (slice: make swap delegate to swap_unchecked)
- rust-lang/rust#159274 (bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run`)
- rust-lang/rust#159275 (remove obsolete comment)
- rust-lang/rust#159277 (Construct `tokens` for attrs made by `mk_attr_word` and other variants)
- rust-lang/rust#159283 (Remove obsolete verbose flag from deref/ref suggestions)
- rust-lang/rust#159290 (rustc-dev-guide subtree update)
@weiznich

weiznich commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Thanks for pushing this documentation. This covers what I had in mind while writing the initial implementation.

github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 20, 2026
@bors
Auto merge of #159293 - JonathanBrouwer:rollup-bZ1e8vF, r=JonathanBro…
0dec64c
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#156047 (Fix trait method resolution on an adjusted never type)
- rust-lang/rust#157824 (Comptime inherent impls)
- rust-lang/rust#158235 (Store `DefId` instead of `EiiDecl` in `EiiImplResolution::Known`)
- rust-lang/rust#158723 (Support EII on Windows MSVC)
- rust-lang/rust#158993 (rerun in original typing mode if we meet any opaques in post analysis)
- rust-lang/rust#159160 (Make `HasTokens` a sub-trait of `HasAttrs`.)
- rust-lang/rust#159183 (Introduce InstanceKind::LlvmIntrinsic)
- rust-lang/rust#159251 (Bump rustc-perf submodule)
- rust-lang/rust#155013 (Suggest the `[const] Destruct` bound for type parameters in const functions when missing)
- rust-lang/rust#159155 (unstable book: Document `diagnostic_on_unknown` feature)
- rust-lang/rust#159235 (Add regression test for rust-lang/rust#95719)
- rust-lang/rust#159243 (inline Once wait and wait_force)
- rust-lang/rust#159255 (Replace shortened type with `_` instead of `...` as placeholder)
- rust-lang/rust#159259 (Add regression test for rust-lang/rust#144033)
- rust-lang/rust#159265 (bootstrap: skip intrinsic-test when rustfmt is unavailable)
- rust-lang/rust#159269 (disable range-len-try-from.rs on s390x)
- rust-lang/rust#159272 (slice: make swap delegate to swap_unchecked)
- rust-lang/rust#159274 (bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run`)
- rust-lang/rust#159275 (remove obsolete comment)
- rust-lang/rust#159277 (Construct `tokens` for attrs made by `mk_attr_word` and other variants)
- rust-lang/rust#159283 (Remove obsolete verbose flag from deref/ref suggestions)
- rust-lang/rust#159290 (rustc-dev-guide subtree update)
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Jul 23, 2026
@bors
Auto merge of #159293 - JonathanBrouwer:rollup-bZ1e8vF, r=JonathanBro…
6553d41
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#156047 (Fix trait method resolution on an adjusted never type)
- rust-lang/rust#157824 (Comptime inherent impls)
- rust-lang/rust#158235 (Store `DefId` instead of `EiiDecl` in `EiiImplResolution::Known`)
- rust-lang/rust#158723 (Support EII on Windows MSVC)
- rust-lang/rust#158993 (rerun in original typing mode if we meet any opaques in post analysis)
- rust-lang/rust#159160 (Make `HasTokens` a sub-trait of `HasAttrs`.)
- rust-lang/rust#159183 (Introduce InstanceKind::LlvmIntrinsic)
- rust-lang/rust#159251 (Bump rustc-perf submodule)
- rust-lang/rust#155013 (Suggest the `[const] Destruct` bound for type parameters in const functions when missing)
- rust-lang/rust#159155 (unstable book: Document `diagnostic_on_unknown` feature)
- rust-lang/rust#159235 (Add regression test for rust-lang/rust#95719)
- rust-lang/rust#159243 (inline Once wait and wait_force)
- rust-lang/rust#159255 (Replace shortened type with `_` instead of `...` as placeholder)
- rust-lang/rust#159259 (Add regression test for rust-lang/rust#144033)
- rust-lang/rust#159265 (bootstrap: skip intrinsic-test when rustfmt is unavailable)
- rust-lang/rust#159269 (disable range-len-try-from.rs on s390x)
- rust-lang/rust#159272 (slice: make swap delegate to swap_unchecked)
- rust-lang/rust#159274 (bootstrap: Rename `std_crates_for_run_make` to `std_crates_for_make_run`)
- rust-lang/rust#159275 (remove obsolete comment)
- rust-lang/rust#159277 (Construct `tokens` for attrs made by `mk_attr_word` and other variants)
- rust-lang/rust#159283 (Remove obsolete verbose flag from deref/ref suggestions)
- rust-lang/rust#159290 (rustc-dev-guide subtree update)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercotennethercotennethercote approved these changes

Assignees

@nnethercotennethercote

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mejrs@rustbot@khyperia@nnethercote@weiznich