Uh oh!
There was an error while loading. Please reload this page.
Rollup of 22 pull requests - #159293
Merged
Merged
Conversation
…hat the ty vars are equal
Add autodiff support for x86_64 apple darwin
Add install notes for older rustup versions
Corrected a typo in the explanation of inferred arguments in ambig AST positions.
Fix typo in ambig AST positions description
Because that's what it is: any type with tokens must also have attrs. This simplifies some trait bounds.
…ctions When a const function drops a value whose type is a type parameter, suggest adding a `[const] Destruct` bound so the destructor can be evaluated at compile-time.
The suggested bound requires the unstable `const_destruct` feature, so it is not actionable on a stable compiler. Add a run-make test that verifies the suggestion is only emitted on nightly.
This way codegen backends don't have to check for a magic symbol name prefix to detect LLVM intrinsic calls and thus can more easily handle them separately as necessary.
This optimisation is currently broken on s390x[^1]. It looks like a big-endian issue in general. but as we only know about the test fails on s390x we only disable it there. Should be reenabled when the problem is fixed and llvm backend is updated. [^1]: llvm/llvm-project#208712
Contributor
💔 Test for 4eab515 failed: CI. Failed job:
|
JonathanBrouwer
commented
Jul 14, 2026
MemberAuthor
@bors retry |
This comment has been minimized.
This comment has been minimized.
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2f5253f (parent) -> 38a0576 (this PR) Test differencesShow 1295 test diffsStage 1
Stage 2
(and 5 additional test diffs) Additionally, 1190 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 38a0576951fb5f7209c892b030f40ac166ae86b4 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Jul 15, 2026
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 2f5253f008 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Jul 15, 2026
Collaborator
Finished benchmarking commit (38a0576): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.3%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 490.821s -> 489.951s (-0.18%) |
Kobzol
commented
Jul 21, 2026
Member
There seems to be a very tiny regression across the board, which is a bit larger (but still small) on some secondary benchmarks. The Given that this rollup contains a lot of PRs that might have caused the rest of the regressions, but I don't expect that we would revert the PRs because of this tiny regression, I don't think we have to dig deeper. @rustbot label: +perf-regression-triaged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
DefIdinstead ofEiiDeclinEiiImplResolution::Known#158235 (StoreDefIdinstead ofEiiDeclinEiiImplResolution::Known)HasTokensa sub-trait ofHasAttrs. #159160 (MakeHasTokensa sub-trait ofHasAttrs.)[const] Destructbound for type parameters in const functions when missing #155013 (Suggest the[const] Destructbound for type parameters in const functions when missing)diagnostic_on_unknownfeature #159155 (unstable book: Documentdiagnostic_on_unknownfeature)_instead of...as placeholder #159255 (Replace shortened type with_instead of...as placeholder)cannot relate bound region#144033)std_crates_for_run_maketostd_crates_for_make_run#159274 (bootstrap: Renamestd_crates_for_run_maketostd_crates_for_make_run)tokensfor attrs made bymk_attr_wordand other variants #159277 (Constructtokensfor attrs made bymk_attr_wordand other variants)r? @ghost
Create a similar rollup