Uh oh!
There was an error while loading. Please reload this page.
Minor TokenStream improvements - #159585
Merged
rust-bors[bot] merged 3 commits intoJul 20, 2026
Merged
Conversation
A slice is more general. Also remove the tail end of a comment that is inaccurate (this function doesn't have a variable named `stream`, but one of its callers does).
It currently doesn't include the length. It should. This change makes it more like other `StableHash` impls for vec-like types.
rustbot
commented
Jul 20, 2026
Collaborator
|
Kobzol
commented
Jul 20, 2026
Member
Looks simple enough. The change I'd really like to see is getting rid of those tokenstream modifications 😁 But I'm still trying to make them compatible with the arena approach. @bors r+ rollup |
Contributor
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 20, 2026
…ovements, r=Kobzol Minor `TokenStream` improvements I found these while attempting to improve the `TokenStream` representation in rust-lang#159048. r? @Kobzol
rust-borsBot
pushed a commit
that referenced
this pull request
Jul 20, 2026
…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)
rust-borsBot
pushed a commit
that referenced
this pull request
Jul 20, 2026
…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Jul 20, 2026
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Aug 17, 2026
…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found these while attempting to improve the
TokenStreamrepresentation in #159048.r? @Kobzol