Improve `AttrItem::span` by nnethercote · Pull Request #159587 · rust-lang/rust

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

r? @petrochenkov

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

r? @petrochenkov

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

r? @petrochenkov

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

r? @petrochenkov

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

r? @petrochenkov

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

r? @petrochenkov

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote · 2026-07-20T05:11:10Z

It has some shortcomings. Details in individual commits.

r? @petrochenkov

Just to improve coverage.

Currently the method computes the span from the path's span and the args' span. That used to be fine but then `unsafe(..)`/`safe(..)` were added without it being changed. So it doesn't account for those optional keywords and parentheses. The only way to handle those reliably is with a dedicated span for the entire `AttrItem`. Consequences: - `NormalAttr` grows from 72 bytes to 80. (It's the only AST node that contains an `AttrItem`.) Not ideal, but non-doc-comment attributes aren't that common (not compared to expressions, for example). Also, `NormalAttr` is always boxed and jemalloc will round up 72 byte allocations to 80 bytes anyway. - In `lint-unsafe-code.rs` various spans now point to `unsafe(foo)` rather than just `foo`. (It makes sense to include the `unsafe` keyword in the complaint about unsafety.)

rustbot · 2026-07-20T05:11:13Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

JonathanBrouwer · 2026-07-20T06:41:46Z

@bors try @rust-timer queue

Improve `AttrItem::span`

rust-bors · 2026-07-20T08:36:39Z

☀️ Try build successful (CI)
Build commit: a8ce121 (a8ce121c5d9b7781fed35525b58762bbcd5a3712)
Base parent: 730a6b5 (730a6b5dce9477b819de0ba79d6e7945e1248e3d)

rust-timer · 2026-07-20T09:17:08Z

Finished benchmarking commit (a8ce121): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 491.733s (1.21%)
Artifact size: 391.77 MiB -> 391.76 MiB (-0.00%)

petrochenkov · 2026-07-20T11:14:20Z

@bors r+ rollup=maybe

rust-bors · 2026-07-20T11:14:23Z

📌 Commit ea7bee7 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

…uwer Rollup of 10 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159449 (Enable single Location to issue multiple borrows) - #159587 (Improve `AttrItem::span`) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

…uwer Rollup of 18 pull requests Successful merges: - #159600 (`rust-analyzer` subtree update) - #158046 (proc_macro: preserve file module spans for inner attrs) - #159000 (Small cleanups to the incr comp session code) - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - #159449 (Enable single Location to issue multiple borrows) - #159544 (Suggest valid command-line crate names) - #159587 (Improve `AttrItem::span`) - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - #159597 (std: use `arc4random_buf` from libc) - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - #158061 (Make `pin!()` more foolproof.) - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - #159529 (Add regression test for nested replacement ranges in `collect_tokens`) - #159571 (Remove unused bundled library lookup for the local crate) - #159585 (Minor `TokenStream` improvements) - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - #159602 (Remove `ItemLike`) - #159603 (Clarify `push_stream`/`push_tree`) Failed merges: - #159590 (Remove some dead code)

@petrochenkov

Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

@JonathanBrouwer

…nathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #159633 - nnethercote:attr-suggestions, r=JonathanBrouwer Improve workings of attribute suggestions `AttrItem` span tracking improved in #159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

@JonathanBrouwer

…uwer Improve workings of attribute suggestions `AttrItem` span tracking improved in rust-lang/rust#159587, which lets us slightly simplify the workings of attribute suggestions. r? @JonathanBrouwer

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#159600 (`rust-analyzer` subtree update) - rust-lang/rust#158046 (proc_macro: preserve file module spans for inner attrs) - rust-lang/rust#159000 (Small cleanups to the incr comp session code) - rust-lang/rust#159189 (Account for type alias projections in E0308 "expected/found" shortening logic) - rust-lang/rust#159449 (Enable single Location to issue multiple borrows) - rust-lang/rust#159544 (Suggest valid command-line crate names) - rust-lang/rust#159587 (Improve `AttrItem::span`) - rust-lang/rust#159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures) - rust-lang/rust#159597 (std: use `arc4random_buf` from libc) - rust-lang/rust#159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.) - rust-lang/rust#158061 (Make `pin!()` more foolproof.) - rust-lang/rust#159460 (Do not mark unnormalized const aliases as rigid when normalizing param env) - rust-lang/rust#159529 (Add regression test for nested replacement ranges in `collect_tokens`) - rust-lang/rust#159571 (Remove unused bundled library lookup for the local crate) - rust-lang/rust#159585 (Minor `TokenStream` improvements) - rust-lang/rust#159586 (Separate `InterpCx` usage by `ConstAnalysis` phases) - rust-lang/rust#159602 (Remove `ItemLike`) - rust-lang/rust#159603 (Clarify `push_stream`/`push_tree`) Failed merges: - rust-lang/rust#159590 (Remove some dead code)

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

nnethercote added 2 commits July 20, 2026 14:42

Add an unsafe attribute example to a test
b6aa11a
Just to improve coverage.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026

rustbot assigned petrochenkov Jul 20, 2026

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Jul 20, 2026
Auto merge of#159587- nnethercote:AttrItem-span, r=<try>
a8ce121
Improve `AttrItem::span`

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 20, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
Rollup merge ofrust-lang#159587- nnethercote:AttrItem-span, r=petro…
5fdd7e5
…chenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 10 pull requests #159604
Closed

JonathanBrouwer mentioned this pull request Jul 20, 2026
Rollup of 18 pull requests #159610
Merged

rust-borsBot merged commit 152c269 into rust-lang:mainJul 20, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 20, 2026

rust-timer added a commit that referenced this pull request Jul 20, 2026
Unrolled build for#159587
90e32d4
Rollup merge of #159587 - nnethercote:AttrItem-span, r=petrochenkov Improve `AttrItem::span` It has some shortcomings. Details in individual commits. r? @petrochenkov

nnethercote deleted the AttrItem-span branch July 20, 2026 23:55

nnethercote mentioned this pull request Jul 21, 2026
Improve workings of attribute suggestions #159633
Merged

Uh oh!

Uh oh!

Conversation

nnethercote commented Jul 20, 2026

Uh oh!

rustbot commented Jul 20, 2026

Uh oh!

JonathanBrouwer commented Jul 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Jul 20, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 20, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

petrochenkov commented Jul 20, 2026

Uh oh!

rust-borsBot commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

nnethercote commented Jul 20, 2026

Uh oh!

rustbot commented Jul 20, 2026

Uh oh!

JonathanBrouwer commented Jul 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Jul 20, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 20, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

petrochenkov commented Jul 20, 2026

Uh oh!

rust-borsBot commented Jul 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

nnethercote commented Jul 20, 2026

Uh oh!

rustbot commented Jul 20, 2026

Uh oh!

JonathanBrouwer commented Jul 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Jul 20, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 20, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

petrochenkov commented Jul 20, 2026

Uh oh!

rust-borsBot commented Jul 20, 2026