Uh oh!
There was an error while loading. Please reload this page.
Improve interpolation of macro lhs and doc comments. Remove Matchers - #17830
Merged
Conversation
huonw
commented
Oct 7, 2014
Contributor
Does this handle the following? // other, so the result of the whole thing should be "let z_123 = 3; z_123macro_rules! g (($x:ident) =>
({macro_rules! f(($y:ident)=>({let $y=3;$x}));
f!($x)}))fna(){g!(z)}(If not, we probably shouldn't close #6994.) |
Merged
pczarnforce-pushed
the
interp_tt
branch
3 times, most recently
from
October 10, 2014 19:32
cd6acf6 to
ca86531Comparepnkfelix
commented
Oct 17, 2014
Contributor
cc me (I will try to review on Monday if no one else gets to it in the meantime). |
pnkfelix
commented
Oct 23, 2014
Contributor
@pczarn (okay, I'll try to avoid making comments about things that were addressed in later commits ... ) |
pczarnforce-pushed
the
interp_tt
branch
2 times, most recently
from
October 27, 2014 15:05
2bb45dd to
e3b0399Comparepczarnforce-pushed
the
interp_tt
branch
2 times, most recently
from
November 2, 2014 11:21
99a5f0e to
9f67980Comparealexcrichton
commented
Nov 3, 2014
Member
Feel free to ping the PR whenever you force-push it, sadly github doesn't send out notifications for that kind of event! |
pczarnforce-pushed
the
interp_tt
branch
2 times, most recently
from
November 5, 2014 23:04
d1606f2 to
2229754Compareadrientetar
commented
Nov 7, 2014
Contributor
@alexcrichton Look like it was updated |
pczarn
commented
Nov 7, 2014
ContributorAuthor
Yes, and this update actually works. I didn't have time to find mistakes after rebasing, previously |
bors added a commit
that referenced
this pull request
Nov 7, 2014
Closes#14197 Removes the `matchers` nonterminal. If you're using `$foo:matchers` in a macro, write `$foo:tt` instead. [breaking-change]
pczarn added a commit
to pczarn/rust
that referenced
this pull request
Jan 6, 2015
Prevents breaking down `$name` tokens into separate `$` and `name`. Reports unknown macro variables. Fixesrust-lang#18775Fixesrust-lang#18839Fixesrust-lang#15640
dlrobertson pushed a commit
to dlrobertson/rust
that referenced
this pull request
Nov 29, 2018
Prevents breaking down `$name` tokens into separate `$` and `name`. Reports unknown macro variables. Fixesrust-lang#18775Fixesrust-lang#18839Fixesrust-lang#15640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#14197
Removes the
matchersnonterminal.If you're using
$foo:matchersin a macro, write$foo:ttinstead.[breaking-change]