Skip to content

Cleanup and followup to PR #17830: parsing changes - #19430

Merged
alexcrichton merged 1 commit into
rust-lang:masterfrom
pczarn:interp_tt-cleanup
Jan 7, 2015
Merged

Cleanup and followup to PR #17830: parsing changes#19430
alexcrichton merged 1 commit into
rust-lang:masterfrom
pczarn:interp_tt-cleanup

Conversation

@pczarn

Copy link
Copy Markdown
Contributor

Followup to PR #17830. Prevents breaking down unquoted $name tokens into separate $ and name.
Reports unknown macro variables (with correct span).

Fixes#18775 (finally...)
Fixes#18839
Fixes#15640

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two checks fix #18775

@alexcrichton

Copy link
Copy Markdown
Member

r? @pnkfelix

@pczarn
pczarnforce-pushed the interp_tt-cleanup branch 2 times, most recently from 8f5bfaa to 02d60f4CompareDecember 10, 2014 14:36
@Gankra

Copy link
Copy Markdown
Contributor

Needs a rebase...

And an actual reviewer 😞

@pczarn

Copy link
Copy Markdown
ContributorAuthor

Rebased, updated the reference. Still waiting for review

@emberian

Copy link
Copy Markdown
Contributor

r=me with a rebase.

@emberian

Copy link
Copy Markdown
Contributor

Actually, should wait for macro reform to land first.

@pczarn
pczarnforce-pushed the interp_tt-cleanup branch 2 times, most recently from 26046d9 to 4ffa69fCompareJanuary 6, 2015 18:34
Prevents breaking down `$name` tokens into separate `$` and `name`.
Reports unknown macro variables.
Fixesrust-lang#18775Fixesrust-lang#18839Fixesrust-lang#15640
@pczarn

Copy link
Copy Markdown
ContributorAuthor

@cmr Tested, pushed with some changes

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 7, 2015
Conflicts:
src/libsyntax/parse/parser.rs
@alexcrichton
alexcrichton merged commit d85c017 into rust-lang:masterJan 7, 2015
@pczarn
pczarn deleted the interp_tt-cleanup branch January 14, 2015 16:55
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants

@pczarn@alexcrichton@Gankra@emberian@pnkfelix