Skip to content

Initial version of AArch64 support (build system, sources, tests). - #19790

Merged
bors merged 1 commit into
rust-lang:masterfrom
akosthekiss:aarch64-configure
Jan 3, 2015
Merged

Initial version of AArch64 support (build system, sources, tests).#19790
bors merged 1 commit into
rust-lang:masterfrom
akosthekiss:aarch64-configure

Conversation

@akosthekiss

@akosthekissakosthekiss commented Dec 12, 2014

Copy link
Copy Markdown
Contributor

Preparing AArch64 support, starting work at the build system.

@rust-highfive

rust-highfive commented Dec 12, 2014

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton

alexcrichton commented Dec 13, 2014

Copy link
Copy Markdown
Member

Awesome! Could you measure the before/after size of LLVM after enabling the AArch64 target? This will be included in basically all Rust compilers, so just want to make sure we're not tacking on a huge amount of data!

@akosthekiss

akosthekiss commented Dec 15, 2014

Copy link
Copy Markdown
ContributorAuthor

Certainly. Below are some before/after file sizes.

Before:
x86_64-unknown-linux-gnu/llvm/Release+Asserts/lib/libLLVMAArch64*.a: 0M
x86_64-unknown-linux-gnu/stage2/lib/librustc_llvm-4e7c5e5c.so: 36,259K
x86_64-unknown-linux-gnu/stage3/bin/rustc: 51,329K

After:
x86_64-unknown-linux-gnu/llvm/Release+Asserts/lib/libLLVMAArch64*.a: 5.6M
x86_64-unknown-linux-gnu/stage2/lib/librustc_llvm-4e7c5e5c.so: 39,214K
x86_64-unknown-linux-gnu/stage3/bin/rustc: 54,151K

@akosthekiss

akosthekiss commented Dec 18, 2014

Copy link
Copy Markdown
ContributorAuthor

It seems that because of the rebase, I've lost the r+. My bad. May I ask for it again? Sorry for the hassle.

This was referenced Dec 19, 2014
Closed
Closed
@alexcrichton

alexcrichton commented Dec 21, 2014

Copy link
Copy Markdown
Member

ping @brson, sorry I keep missing you on IRC, but I'm curious about your thoughts about adding AArch64 to the build.

@akosthekissakosthekiss changed the title Adding AArch64 knowledge to configure and the make files.Initial version of AArch64 support (build system, sources, tests).Dec 21, 2014
@vhbit

vhbit commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

I'd also like to push it further as want to move forward with arm64 support for iOS - in February all apps are required to have a binary compiled for arm64.

@vhbit

vhbit commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

@akiss77 needs a rebase

@akosthekiss
akosthekissforce-pushed the aarch64-configure branch 2 times, most recently from 31543fe to 70c423eCompareDecember 23, 2014 22:43
@akosthekiss

akosthekiss commented Dec 23, 2014

Copy link
Copy Markdown
ContributorAuthor

@vhbit did it - glad to see interest in aarch64/arm64 (although I'm not really familiar with iOS)

sanxiyn
sanxiyn reviewed Dec 24, 2014
View reviewed changes
Comment threadsrc/rt/arch/aarch64/_context.S Outdated

@sanxiynsanxiynDec 24, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context switching codes for other architectures were removed in #20135.

@akosthekiss
akosthekissforce-pushed the aarch64-configure branch 2 times, most recently from befc1fb to ae77605CompareDecember 28, 2014 00:15
@vhbit

vhbit commented Dec 29, 2014

Copy link
Copy Markdown
Contributor

@alexcrichton so what's status of this?

@alexcrichton

alexcrichton commented Dec 29, 2014

Copy link
Copy Markdown
Member

Ok, I've chatted with @brson about this and we'd like to move forward with this, thanks for being patient and sorry about the delay!

@alexcrichton

alexcrichton commented Dec 29, 2014

Copy link
Copy Markdown
Member

Ah yes I forgot! Could you also touch the src/rustllvm/llvm-auto-clean-trigger file to trigger an LLVM rebuild?

vhbit
vhbit reviewed Dec 31, 2014
View reviewed changes
Comment threadsrc/librustc_back/target/aarch64_unknown_linux_gnu.rs Outdated

@vhbitvhbitDec 31, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct format for aggregates data layout should be a:0:64 instead of a0:0:64, see here

@akosthekiss
akosthekissforce-pushed the aarch64-configure branch 2 times, most recently from a9d2e48 to 24cb7a4CompareJanuary 3, 2015 00:47
@akosthekiss

akosthekiss commented Jan 3, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks for the good news and sorry about the delay on my side (had some parties to survive...) Did all the requested updates. Happy New Year to all!

@akosthekiss

akosthekiss commented Jan 3, 2015

Copy link
Copy Markdown
ContributorAuthor

I've run into a syntax change (arrays) :/ Updated.

This was referenced Jan 3, 2015
Merged
Merged
Merged
@akosthekiss
Initial version of AArch64 support.
6e5fb8b
Adds AArch64 knowledge to:
* configure,
* make files,
* sources,
* tests, and
* documentation.
bors added a commit that referenced this pull request Jan 3, 2015
@bors
auto merge of#19790: akiss77/rust/aarch64-configure, r=alexcrichton
496dc4e
Preparing AArch64 support, starting work at the build system.
@bors
bors merged commit 6e5fb8b into rust-lang:masterJan 3, 2015
@akosthekiss

akosthekiss commented Jan 3, 2015

Copy link
Copy Markdown
ContributorAuthor

Oh, yes. Thanks for all the reviews, feedback & support!

@akosthekiss
akosthekiss deleted the aarch64-configure branch January 4, 2015 09:37
@alexcrichtonalexcrichton mentioned this pull request Jan 14, 2015
Merged
@AmanieuAmanieu mentioned this pull request Jan 2, 2016
Merged
bors added a commit that referenced this pull request Jan 12, 2016
@bors
Auto merge of#30678- Amanieu:no_elf_tls, r=alexcrichton
3246eae
I also re-enabled the use of `#[thread_local]` on AArch64. It was originally disabled in the PR that introduced AArch64 (#19790), but the reasons for this were not explained. `#[thread_local]` seems to work fine in my tests on AArch64, so I don't think this should be an issue.
cc @alexcrichton @akiss77
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akosthekiss@rust-highfive@alexcrichton@vhbit@sanxiyn@bors