Uh oh!
There was an error while loading. Please reload this page.
Initial version of AArch64 support. - #20017
Conversation
rust-highfive
commented
Dec 19, 2014
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
richo
commented
Dec 19, 2014
Thanks for this- I'm working on a power port and this is a pretty good todo list for things I have left! |
There was a problem hiding this comment.
Can't the 32-bit and 64-bit architectures reuse the same tests, one for each?
There was a problem hiding this comment.
It seems/seemed to me that they could. However, I didn't want/dare to go against the practice I found here: fn test_hash_uint() is already cloned for arm and x86 targets, that's why I added a new version for aarch64, cloning the x86_64 version. Shall the refactoring (merging the clones) be part of this patch (which will make it not purely aarch64-focused)?
598b6ef to
a50ed7eComparealexcrichton
commented
Dec 21, 2014
akosthekiss
commented
Dec 21, 2014
Rolled, so closing this PR as well. |
There are still some FIXMEs in the code (around thread locals and stack protection) but rustc already passes most of the tests on AArch64:
summary of 41 test runs: 8265 passed; 1 failed; 542 ignored; 0 measured.
Needs #19790 and rust-lang/compiler-rt#5 .