Skip to content

Syntax extensions on trait and impl items. - #21052

Merged
bors merged 1 commit into
rust-lang:masterfrom
nrc:methods-ext
Jan 16, 2015
Merged

Syntax extensions on trait and impl items.#21052
bors merged 1 commit into
rust-lang:masterfrom
nrc:methods-ext

Conversation

@nrc

@nrcnrc commented Jan 12, 2015

Copy link
Copy Markdown
Member

Allows modifiers to be used on methods, associated types, etc.

r? @sfackler

Comment threadsrc/libsyntax/ext/base.rs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not &[Attribute]?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! (Pretty impressed rustc is able to figure out the lifetimes with that)

Allows modifiers to be used on methods, associated types, etc.
@nrc

nrc commented Jan 14, 2015

Copy link
Copy Markdown
MemberAuthor

Fixed according to comment and rebased.

r? @sfackler

@sfackler

Copy link
Copy Markdown
Member

This seems okay for now, until we work out how we actually want to stabilize this stuff.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 15, 2015
Allows modifiers to be used on methods, associated types, etc.
r? @sfackler
bors added a commit that referenced this pull request Jan 15, 2015
Allows modifiers to be used on methods, associated types, etc.
r? @sfackler
@bors
bors merged commit 98d4711 into rust-lang:masterJan 16, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nrc@sfackler@bors