Avoid gated feature checking unconfigured expanded items by jseyfried · Pull Request #32846 · rust-lang/rust

jseyfried · 2016-04-08T23:50:21Z

Avoid gated feature checking unconfigured macro-expanded items (fixes#32840).
Unconfigured items that are not macro-expanded are already not gated feature checked.
r? @nrc

LeoTestard · 2016-04-08T23:58:47Z

+ *sess.features.borrow_mut() = features;
+ })
+ })?;
+


There is already a second feature gate checking pass just a bit later in the same function (“complete gated feature checking 2”). I'm not sure this first pass is necessary at all. I considered removing it as part of #32791 but then thought I'd do a separate PR.

Good point, I'll remove it.

jseyfried · 2016-04-09T05:45:46Z

- let it = expand_item_multi_modifier(Annotatable::Item(it), fld);
-
- expand_annotatable(it, fld)
+ expand_annotatable(Annotatable::Item(it), fld)


expand_annotatable begins with a call to expand_item_multi_modifier, which is idempotent (cf #21052).
This is unrelated to the rest of the PR.

nrc · 2016-04-12T02:23:18Z

Code looks fine, but @rust-lang/lang should discuss.

jseyfried · 2016-04-22T18:57:39Z

cf #25544

nikomatsakis · 2016-04-28T21:57:56Z

Finally discussed in lang-team meeting. We agree that feature-gated items which are "configured out" by should not generate warnings, whether they result from macro expansion or not. i.e., this PR seems good. :)

nrc · 2016-04-28T21:58:01Z

@bors: r+

bors · 2016-04-28T21:58:10Z

📌 Commit 86f069d has been approved by nrc

bors · 2016-04-28T23:48:13Z

⌛ Testing commit 86f069d with merge 8bd01ad...

bors · 2016-04-29T01:58:35Z

💔 Test failed - auto-win-msvc-64-opt

jseyfried · 2016-04-30T04:21:31Z

@bors retry

bors · 2016-04-30T04:29:25Z

⌛ Testing commit 86f069d with merge c5ec369...

bors · 2016-04-30T06:19:17Z

💔 Test failed - auto-mac-64-nopt-t

jseyfried · 2016-04-30T06:47:34Z

@bors retry

bors · 2016-04-30T09:07:34Z

⌛ Testing commit 86f069d with merge b0aefff...

@nrc

…ems, r=nrc Avoid gated feature checking unconfigured expanded items Avoid gated feature checking unconfigured macro-expanded items (fixes#32840). Unconfigured items that are not macro-expanded are already not gated feature checked. r? @nrc

bors · 2016-04-30T11:55:27Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

jseyfried added 2 commits April 8, 2016 22:47

Avoid gated feature checking unconfigured items
0ea66f3

Add regression test
417a6df

rust-highfive assigned nrc Apr 8, 2016

LeoTestard reviewed Apr 8, 2016
View reviewed changes

jseyfried added 2 commits April 9, 2016 00:16

Remove redundant gated feature checking pass
5eb775e

Remove redundant call to expand_item_multi_modifier
86f069d

jseyfried reviewed Apr 9, 2016
View reviewed changes

nrc added I-nominated T-lang Relevant to the language team labels Apr 12, 2016

jseyfried mentioned this pull request Apr 22, 2016
#[cfg_attr] doesn't work with path attribute #25544
Closed

nikomatsakis removed the I-nominated label Apr 28, 2016

bors merged commit 86f069d into rust-lang:masterApr 30, 2016

LeoTestard mentioned this pull request May 29, 2016
#[main] attribute on #[test] function does not error properly #33946
Closed

Uh oh!

Uh oh!

Conversation

jseyfried commented Apr 8, 2016

Uh oh!

LeoTestardApr 8, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfriedApr 9, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfriedApr 9, 2016

Choose a reason for hiding this comment

Uh oh!

nrc commented Apr 12, 2016

Uh oh!

jseyfried commented Apr 22, 2016

Uh oh!

nikomatsakis commented Apr 28, 2016

Uh oh!

nrc commented Apr 28, 2016

Uh oh!

bors commented Apr 28, 2016

Uh oh!

bors commented Apr 28, 2016

Uh oh!

bors commented Apr 29, 2016

Uh oh!

jseyfried commented Apr 30, 2016

Uh oh!

bors commented Apr 30, 2016

Uh oh!

bors commented Apr 30, 2016

Uh oh!

jseyfried commented Apr 30, 2016

Uh oh!

bors commented Apr 30, 2016

Uh oh!

bors commented Apr 30, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants