Use for instead of while in ascii.rs tests

[iKevinY]

While working on this PR, I also noticed that all of the tests iterate through values up to 500. Just out of curiosity, was the choice of 500 arbitrary? I was thinking that it might make more sense to iterate up to 127 due to ASCII's character range (or if non-ASCII characters are being tested intentionally, either 255 or 511 for a nice 2^n - 1 value).

[rust-highfive]

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

[brson]

@bors: r+ 00d1 thanks!

I don't know off hand the significance of the numbers here.

[bors]

⌛ Testing commit 00d1873 with merge 5368ab1...

[bors]

💔 Test failed - auto-win-64-nopt-t

[iKevinY]

💔 Test failed - auto-win-64-nopt-t

Gah. :( Though since this hasn't been merged in yet, I'm still curious about the 500 magic number. The loops seem to me like they're just testing ASCII values (the assert_eq! checks preceding the loops seem to cover Unicode characters). Do you think it be okay for me to push another commit to this PR changing the 501s to 128s? (Unless of course there actually is a significance behind it.)

[alexcrichton]

@bors: retry

[bors]

⌛ Testing commit 00d1873 with merge 4668f51...

[bors]

💔 Test failed - auto-mac-64-opt

[alexcrichton]

@bors: retry

[bors]

⌛ Testing commit 00d1873 with merge d57a571...

[bors]

💔 Test failed - auto-win-64-nopt-t

[iKevinY]

Are the build fails related to the changes I made in my PR? There seems to be an awful lot of fails. :/

[alexcrichton]

@bors: retry

Our automation is a ... little flaky sometimes :)

[iKevinY]

@alexcrichton Ah, I see; just wanted to make sure that I didn't break anything! Is a specific cause for the automation failure known? (Could the build infrastructure be improved or are there no practical fixes?)

[bors]

⌛ Testing commit 00d1873 with merge ec280bc...

[bors]

💔 Test failed - auto-win-64-nopt-t

[alexcrichton]

@bors: retry rollup