Uh oh!
There was an error while loading. Please reload this page.
Rollup of 22 pull requests - #22149
Closed
Manishearth wants to merge 45 commits into
Closed
Conversation
As per rust-lang/rfcs#601, replace `be` with `become` as reserved keyword for tail call optimization.
From Issue 21829 clarify equivalency of tuples
No point sending people to a page which just says "this is now part of the Rust book".
When self.start > self.end, these iterators simply return None, so we adjust the size_hint to just return zero in this case. Certain optimizations can be implemented in and outside libstd if we know we can trust the size_hint for all inputs to for example Range<usize>. This corrects the ExactSizeIterator implementations, which IMO were unsound and incorrect previously, since they allowed a range like (2..1) to return a size_hint of -1us in when debug assertions are turned off.
This was correct in the EBNF, but not in the prose (which seems to have been copied-and-pasted from regular string literals).
- c-link-to-rust-staticlib: use EXTRACFLAGS defined by tools.mk for choose the good libraries to link to. - no-stack-check: disabled for openbsd (no segmented stacks here) - symbols-are-reasonable: use portable grep pattern - target-specs: use POSIX form for options when invoking grep - use-extern-for-plugins: disable as OpenBSD only support x86_64 for now
Update reference.md: - derive() no longer supports Zero trait - derive() now supports Copy trait
Crate types from multiple sources appear to be deduplicated properly, but not deduplicated if they come from the command line arguments. At worst, this used to cause compiler failures when `--crate-type=lib,rlib` (the same as `--crate-type=rlib,rlib`, at least at the time of this commit) is provided and generate the output multiple times otherwise.
(with multiple impls to further exercise correct trait-matching.)
- add namespace - add function parens
like sending a raw pointer slice across thread boundaries.
When trying to build against a newer, local LLVM version it might be preferable to have a flag to disable the LLVM version check instead of having to modify the configure script. Fixesrust-lang#21998
I also noticed that all of the tests iterate through values up to 500. Just out of curiosity, was the choice of 500 arbitrary? I was thinking that it might make more sense to iterate up to 127 due to ASCII's character range (or if non-ASCII characters are being tested intentionally, either 255 or 511 for a nice `2^n - 1` value).
As per rust-lang/rfcs#601, replace `be` with `become` as reserved keyword for tail call optimization.
Add `QPath` construction support to `ExtCtxt`. Allows compiler plugins to generate calls with UFCS.
From rust-lang#21829 clarify equivalency of tuples
…-object-cast, r=eddyb Given `<expr> as Box<Trait>`, infer that `Box<_>` is expected type for `<expr>`.
…eklabnik No point sending people to a page which just says "this is now part of the Rust book" (that page being http://doc.rust-lang.org/rustdoc.html).
- add namespace - add function parens
When self.start > self.end, these iterators simply return None, so we adjust the size_hint to just return zero in this case. Certain optimizations can be implemented in and outside libstd if we know we can trust the size_hint for all inputs to for example Range<usize>. This corrects the ExactSizeIterator implementations, which IMO were unsound and incorrect previously, since they allowed a range like (2..1) to return a size_hint of -1us in when debug assertions are turned off.
…chton So many warnings
…mcallister This was correct in the EBNF, but not in the prose (which seems to have been copied-and-pasted from regular string literals).
- c-link-to-rust-staticlib: use `EXTRACFLAGS` defined by tools.mk for choose the good libraries to link to. tools.mk define a variable `EXTRACFLAGS` that contains the needed library per target. So it is better to use it, instead of duplicate the code here. I keep the `ifndef IS_WINDOWS` has tools.mk define something for WINDOWS... so I don't change things that I couldn't test. - no-stack-check: disabled for openbsd (no segmented stacks here) - symbols-are-reasonable: use portable grep pattern - target-specs: use POSIX form for options when invoking grep - use-extern-for-plugins: disable as OpenBSD only support x86_64 for now
…ichton Rename several remaining `Show`s to Debug, `String`s to Display (mostly in comments and docs). Update reference.md: - derive() no longer supports Zero trait - derive() now supports Copy trait
…abnik The fallback font for a serif font should also be serif, not sans serif.
…lexcrichton I started to write up some docs on this, and then realized I was just repeating http://huonw.github.io/blog/2015/01/peeking-inside-trait-objects/ but worse. @huonw previously said that we can use this content if we wanted, so I made some tweaks and integrated it into the book. Fixesrust-lang#21707
…chton Crate types from multiple sources appear to be deduplicated properly, but not deduplicated if they come from the command line arguments. At worst, this used to cause compiler failures when `--crate-type=lib,rlib` (the same as `--crate-type=rlib,rlib`, at least at the time of this commit) is provided and generate the output multiple times otherwise. r? @alexcrichton
…eklabnik Based off rust-lang#21843, it looks like the syntax in the Closures guide is outdated.
This is to allow for use cases like sending a raw pointer slice across thread boundaries.
When trying to build against a newer, local LLVM version it might be preferable to have a flag to disable the LLVM version check instead of having to modify the configure script. Fixesrust-lang#21998 r? @alexcrichton
rust-highfive
commented
Feb 10, 2015
Contributor
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
commented
Feb 10, 2015
MemberAuthor
Don't review yet. Still adding some more PRs (this was the autogen one) |
Manishearth
commented
Feb 10, 2015
MemberAuthor
Alex is doing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forinstead ofwhilein ascii.rs tests #21862, Replacebewithbecome#21918, Add QPath construction to ExtCtxt for UFCS support. #21943, Book Compound Data Types update #22007, Propagate container across object cast #22012, Link to rustdoc page in the Rust book directly #22049, Update deprecation notice. #22052, Fix std::ops::Range size_hint and ExactSizeIterator impls #22065, add missing features to libcollections tests #22067, reference.md: Byte string literals start with a 'b' #22072, adapt run-make test suite for openbsd #22088, Rename Show to Debug, String to Display #22094, Make docs fallback font 'serif', rather than 'sans-serif' #22097, Add documentation on trait objects. #22106, Deduplicate --crate-type arguments #22115, remove obsolete closure syntax from the guide #22120, Set up docs for missing core types #22128, Remove incorrect docs from mem::transmute #22129, Remove bottom from the reference #22130, Made theptr::Uniquetype accept unsized types #22142, Add a flag to skip the LLVM version check in configure #22147