Uh oh!
There was an error while loading. Please reload this page.
Make docs fallback font 'serif', rather than 'sans-serif' - #22097
Conversation
rust-highfive
commented
Feb 8, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
ce6f81c to
840be23Comparenagisa
commented
Feb 8, 2015
Why remove Helvetica, Arial and friends? |
cllns
commented
Feb 8, 2015
@nagisa because they're sans-serif fonts. If "Source Serif Pro" cannot load, we should load another serif font, not a sans-serif one. |
steveklabnik
commented
Feb 8, 2015
I agree with this conceptually, but the gap between "Source Serif Pro" and |
iKevinY
commented
Feb 8, 2015
If we were to remove the sans-serif fallbacks in favour of serif fonts, I think a Georgia-based stack would work pretty well. It supposedly has good compatibility and looks somewhat similar to Source Serif Pro. font-family:"Source Serif Pro", Georgia, Times, Times New Roman, serif; |
840be23 to
643600cComparecllns
commented
Feb 9, 2015
Good call! Just updated it to the Georgia stack as the fallback. |
643600c to
45f6672Comparealexcrichton
commented
Feb 10, 2015
steveklabnik
commented
Feb 10, 2015
…abnik The fallback font for a serif font should also be serif, not sans serif.
The fallback font for a serif font should also be serif, not sans serif.
The fallback font for a serif font should also be serif, not sans serif.