Uh oh!
There was an error while loading. Please reload this page.
Change span_help calls to fileline_help where appropriate so as not to duplicate code snippets - #22764
Change span_help calls to fileline_help where appropriate so as not to duplicate code snippets#22764ivanradanov wants to merge 2 commits into
Conversation
rust-highfive
commented
Feb 24, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
nagisa
commented
Feb 24, 2015
😍 |
huonw
commented
Feb 24, 2015
This looks great, thanks! However, it can't be merged, and so needs a rebase. (Be sure to ping/@huonw me once you update it, github doesn't provide automatic notifications.) |
9343edb to
1b70875Compareivanradanov
commented
Feb 25, 2015
@huonw I've rebased and pushed. |
1b70875 to
64581cfComparehuonw
commented
Feb 26, 2015
@bors r+ 6458 rollup |
When warnings and errors occur, the associated help message should not print the same code snippet. rust-lang#21938
Manishearth
commented
Feb 27, 2015
(removed from the rollup, I'm on a phone and can't attempt to fix it, sorry) |
bors
commented
Feb 28, 2015
☔ The latest upstream changes (presumably #22801) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
commented
Feb 28, 2015
Needs Manishearth@057aceb to pass tests |
ivanradanov
commented
Mar 3, 2015
@huonw I've rebased again, since it was unmergeable. |
huonw
commented
Mar 4, 2015
@bors r+ |
bors
commented
Mar 4, 2015
When warnings and errors occur, the associated help message should not print the same code snippet. rust-lang#21938
Manishearth
commented
Mar 4, 2015
@bors: r- |
Manishearth
commented
Mar 4, 2015
This still doesn't include the changes I listed above :/ Please ensure this passes Thanks! |
ivanradanov
commented
Mar 5, 2015
@Manishearth Sorry about that, should be fine now. |
When warnings and errors occur, the associated help message should not print the same code snippet. rust-lang#21938
alexcrichton
commented
Mar 5, 2015
@bors: r=huonw |
bors
commented
Mar 5, 2015
alexcrichton
commented
Mar 5, 2015
alexcrichton
commented
Mar 6, 2015
Rolled into #23031 |
…kxlxpos internal: Use expression parsing entrypoint in `make` constructor
When warnings and errors occur, the associated help message should not print the same code snippet.
#21938