[RFC] Entry API v3: replace Entry::get with Entry::default and Entry::default_with by Gankra · Pull Request #22930 · rust-lang/rust

Gankra · 2015-03-01T14:54:55Z

RFC pending, but this is the patch that does it.

Totally untested. Likely needs some removed imports. std::collections docs should also be updated to provide better examples.

Closes#23508

rust-highfive · 2015-03-01T14:55:05Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

apasel422 · 2015-03-01T16:03:43Z

s/self./self,

Gankra · 2015-03-02T12:53:14Z

RFC posted: rust-lang/rfcs#921

All imports/typos/missed-things fixed.

bors · 2015-03-07T06:02:13Z

☔ The latest upstream changes (presumably #23107) made this pull request unmergeable. Please resolve the merge conflicts.

aturon · 2015-03-19T06:26:41Z

Note: the RFC has now been merged (with updated names)

Gankra · 2015-03-20T17:43:52Z

Rebased with updated names. r? @aturon

alexcrichton · 2015-03-20T18:29:55Z

(added Closes #23508 to the description)

I'd also be fine insta-stabilizing these methods as they've been around for quite some time and we're just tweaking the naming here basically.

Gankra · 2015-03-20T18:35:28Z

I'm not comfortable stabilizing these quite yet. We could go one step further and just make these methods on the Map itself, for instance.

I also see no particular urgency to stabilize them; they are pure convenience (though very convenient indeed).

Gankra · 2015-03-20T18:39:16Z

Oh whoops I forgot to actually, you know, test the rebase/fix. Tidy error fixed; building now.

aturon · 2015-03-20T18:42:49Z

This is really, really nice! You've done great work with Entry, @gankro.

I also agree that there's no rush to stabilize these new methods, which are more than a rename.

aturon · 2015-03-20T18:43:03Z

r=me once tests are looking good locally

Gankra · 2015-03-20T22:42:34Z

looks good locally (had to make one update)

liigo · 2015-03-22T00:36:00Z

Good catch!

aturon · 2015-03-23T18:36:17Z

(r=me after nits)

bors · 2015-03-23T20:58:00Z

☔ The latest upstream changes (presumably #23593) made this pull request unmergeable. Please resolve the merge conflicts.

aturon · 2015-03-23T22:09:56Z

Given the proximity to beta, I'm thinking we should probably go ahead and mark these #[stable] within this PR as well. I know that this is more than a straight renaming, but I still think it's a relatively small change to the API with clear benefits, and stabilizing it now will enable a lot of ecosystem code to continue using it at beta.

Worst case, if we do find a problem, we can revise before 1.0.

Gankra · 2015-03-24T03:04:39Z

I'd really like to let this sit if possible. Although empirically it seems like we've played very fast and loose with stable vs unstable so far. Is it possible to stabilize things in the beta -> stable transition?

There's still (in my mind) open questions about whether this functionality should just be on the map directly. Although I suppose we can deprecate this in favour of that quite easily.

aturon · 2015-03-24T16:17:40Z

@gankro I'm happy to defer to your judgment here.

In terms of ongoing stabilization: we will be adding unstable APIs, and stabilizing existing ones, continuously. It is likely possible to stabilize a few APIs during the 1.0 beta and have those available at 1.0, but it's not entirely clear yet.

In terms of "fast and loose", I'm not sure exactly what you're referring to -- perhaps just that we've been willing to change #[stable] APIs in the past? This is entirely due to being in a pre-1.0 state, where it's been essential to use the markers to track progress in cleaning up APIs and signal preliminary confidence in them, while still retaining the freedom to change until the actual release. These kinds of changes have all but disappeared since the alpha release, though.

Gankra · 2015-03-24T16:34:46Z

Easy to stabilize later; let's land this unstable for now. Can review in coming weeks, perhaps with removal of deprecated API.

Gankra · 2015-03-24T16:34:52Z

@bors r=aturon

bors · 2015-03-24T16:34:53Z

📌 Commit d3d11b2 has been approved by aturon

bors · 2015-03-24T21:05:25Z

☔ The latest upstream changes (presumably #23654) made this pull request unmergeable. Please resolve the merge conflicts.

Gankra · 2015-03-27T01:21:13Z

Ugh what another rebase?

…lt_with

Gankra · 2015-03-27T01:40:28Z

@bors r=aturon

bors · 2015-03-27T01:40:28Z

📌 Commit 1132198 has been approved by aturon

RFC pending, but this is the patch that does it. Totally untested. Likely needs some removed imports. std::collections docs should also be updated to provide better examples. Closes#23508

bors · 2015-03-27T02:12:25Z

⌛ Testing commit 1132198 with merge 64a4e01...

bors · 2015-03-27T02:34:55Z

💔 Test failed - auto-linux-64-x-android-t

Gankra · 2015-03-27T11:42:35Z

@bors r=aturon

bors · 2015-03-27T11:42:35Z

📌 Commit 1b98f6d has been approved by aturon

bors · 2015-03-27T12:55:24Z

⌛ Testing commit 1b98f6d with merge 242ed0b...

RFC pending, but this is the patch that does it. Totally untested. Likely needs some removed imports. std::collections docs should also be updated to provide better examples. Closes#23508

bors · 2015-03-27T15:26:52Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

…c_on_a_qualified_path_whose_trait_is_not_a_trait fix: don't panic on a qualified path whose trait is not a trait

rust-highfive assigned brson Mar 1, 2015

Gankra force-pushed the entry_3 branch 3 times, most recently from d7782ad to 009f861Compare March 1, 2015 15:04

apasel422 reviewed Mar 1, 2015
View reviewed changes

Comment threadsrc/libcollections/btree/map.rs Outdated
apasel422Mar 1, 2015
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/self./self,

Gankra force-pushed the entry_3 branch from 9d52d3f to 9b8062aCompare March 2, 2015 12:44

Gankra force-pushed the entry_3 branch 2 times, most recently from c9b5258 to 0c4a120Compare March 20, 2015 17:43

rust-highfive assigned aturon and unassigned brson Mar 20, 2015

Gankra force-pushed the entry_3 branch from 0c4a120 to 40cc2ceCompare March 20, 2015 18:38

Gankra force-pushed the entry_3 branch from 6531253 to 201d923Compare March 20, 2015 22:42

liigo reviewed Mar 22, 2015
View reviewed changes

Gankra force-pushed the entry_3 branch from 201d923 to df4a27dCompare March 24, 2015 03:01

Gankra force-pushed the entry_3 branch from df4a27d to d3d11b2Compare March 24, 2015 03:05

Gankra added 2 commits March 26, 2015 21:36

entry API v3: replace Entry::get with Entry::default and Entry::defau…
1c35953
…lt_with

update everything to use Entry defaults
93cdf1f

Gankra force-pushed the entry_3 branch from d3d11b2 to 1132198Compare March 27, 2015 01:37

default => or_insert per RFC
1b98f6d

Gankra force-pushed the entry_3 branch from 1132198 to 1b98f6dCompare March 27, 2015 11:42

bors merged commit 1b98f6d into rust-lang:masterMar 27, 2015

matklad mentioned this pull request Sep 15, 2021
feat: caching LookupMap implementation near/near-sdk-rs#487
Merged

lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 3, 2026
Merge pull requestrust-lang#22930from shulaoda/07-27-fix_don_t_pani…
7d13615
…c_on_a_qualified_path_whose_trait_is_not_a_trait fix: don't panic on a qualified path whose trait is not a trait

Uh oh!

Uh oh!

Conversation

Gankra commented Mar 1, 2015

Uh oh!

rust-highfive commented Mar 1, 2015

Uh oh!

apasel422Mar 1, 2015

Choose a reason for hiding this comment

Uh oh!

Gankra commented Mar 2, 2015

Uh oh!

bors commented Mar 7, 2015

Uh oh!

aturon commented Mar 19, 2015

Uh oh!

Gankra commented Mar 20, 2015

Uh oh!

alexcrichton commented Mar 20, 2015

Uh oh!

Gankra commented Mar 20, 2015

Uh oh!

Gankra commented Mar 20, 2015

Uh oh!

aturon commented Mar 20, 2015

Uh oh!

aturon commented Mar 20, 2015

Uh oh!

Gankra commented Mar 20, 2015

Uh oh!

liigoMar 22, 2015

Choose a reason for hiding this comment

Uh oh!

GankraMar 22, 2015

Choose a reason for hiding this comment

Uh oh!

aturon commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

aturon commented Mar 23, 2015

Uh oh!

Gankra commented Mar 24, 2015

Uh oh!

aturon commented Mar 24, 2015

Uh oh!

Gankra commented Mar 24, 2015

Uh oh!

Gankra commented Mar 24, 2015

Uh oh!

bors commented Mar 24, 2015

Uh oh!

bors commented Mar 24, 2015

Uh oh!

Gankra commented Mar 27, 2015

Uh oh!

Gankra commented Mar 27, 2015

Uh oh!

bors commented Mar 27, 2015

Uh oh!

bors commented Mar 27, 2015

Uh oh!

bors commented Mar 27, 2015

Uh oh!

Gankra commented Mar 27, 2015

Uh oh!

bors commented Mar 27, 2015

Uh oh!

bors commented Mar 27, 2015

Uh oh!

bors commented Mar 27, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants