Rollup of PRs in the queue; Sunday by Manishearth · Pull Request #23593 · rust-lang/rust

Manishearth · 2015-03-21T20:15:31Z

(yay, no Saturday)

This allows github to render it with formatting.

@sanxiyn

As @sanxiyn says, rust-lang#23527 (comment)

This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in order to future-proof the API against the eventual inclusion of an `IndexSet` trait. Ideally, we would eventually be able to support: ```rust map[owned_key] = val; map[borrowed_key].mutating_method(arguments); &mut map[borrowed_key]; ``` but to keep the design space as unconstrained as possible, we do not currently want to support `IndexMut`, in case some other strategy will eventually be needed. Code currently using mutating index notation can use `get_mut` instead. [breaking-change] Closesrust-lang#23448

Rustbook already does this.

…eatures. Namely: * `box_syntax` * `box_patterns` * `simd_ffi` * `macro_reexport` cc rust-lang#22820

Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixesrust-lang#23550

Manishearth · 2015-03-21T20:16:00Z

@bors: r+ p=20

bors · 2015-03-21T20:16:01Z

📌 Commit e7d77cf has been approved by Manishearth

Manishearth · 2015-03-21T22:26:32Z

@bors: force

bors · 2015-03-21T22:59:39Z

⌛ Testing commit e7d77cf with merge 1d1f2c0...

bors · 2015-03-21T23:03:36Z

💔 Test failed - auto-mac-64-nopt-t

dotdash · 2015-03-21T23:26:18Z

@bors retry

bors · 2015-03-21T23:26:22Z

⌛ Testing commit e7d77cf with merge 1c15687...

bors · 2015-03-21T23:29:38Z

💔 Test failed - auto-mac-64-nopt-t

Manishearth · 2015-03-22T00:12:27Z

@bors: retry force

bors · 2015-03-22T00:12:36Z

⌛ Testing commit e7d77cf with merge 28a5342...

bors · 2015-03-22T00:12:37Z

⛄ The build was interrupted to prioritize another pull request.

Manishearth · 2015-03-22T00:12:45Z

@bors: retry force

bors · 2015-03-22T00:14:41Z

⌛ Testing commit e7d77cf with merge bd0881a...

(yay, no Saturday)

bors · 2015-03-22T00:16:41Z

💔 Test failed - auto-mac-32-opt

Manishearth · 2015-03-22T03:27:34Z

@bors: retry

bors · 2015-03-22T03:27:40Z

⌛ Testing commit e7d77cf with merge 34ead18...

bors · 2015-03-22T04:33:03Z

💔 Test failed - auto-mac-64-nopt-t

…nkro This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in order to future-proof the API against the eventual inclusion of an `IndexSet` trait. Ideally, we would eventually be able to support: ```rust map[owned_key] = val; map[borrowed_key].mutating_method(arguments); &mut map[borrowed_key]; ``` but to keep the design space as unconstrained as possible, we do not currently want to support `IndexMut`, in case some other strategy will eventually be needed. Code currently using mutating index notation can use `get_mut` instead. [breaking-change] Closesrust-lang#23448 r? @gankro

Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixesrust-lang#23550

…s1, r=alexcrichton ...ures. Namely: * `box_syntax` * `box_patterns` * `simd_ffi` * `macro_reexport` cc rust-lang#22820

@sanxiyn

As @sanxiyn says, rust-lang#23527 (comment)

…excrichton Rustbook already does this.

(yay, no Saturday)

bors · 2015-03-23T00:37:36Z

⌛ Testing commit b4e9106 with merge 809a554...

bors · 2015-03-23T02:32:11Z

💔 Test failed - auto-mac-64-nopt-t

Manishearth · 2015-03-23T02:45:54Z

@bors: retry force

bors · 2015-03-23T02:45:58Z

⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

bors · 2015-03-23T04:53:45Z

💔 Test failed - auto-win-64-nopt-t

barosl · 2015-03-23T11:41:34Z

Wow, this rollup is very, very unfortunate!

Manishearth · 2015-03-23T11:42:23Z

@bors: retry

Manishearth · 2015-03-23T13:06:21Z

@barosl Most of this is just because buildbot died over the weekend.

bors · 2015-03-23T13:11:04Z

⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

bors · 2015-03-23T15:23:08Z

💔 Test failed - auto-win-64-nopt-t

Manishearth · 2015-03-23T15:24:57Z

@bors: retry force

bors · 2015-03-23T15:25:01Z

⚡ Previous build results for auto-linux-64-nopt-t, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t...

bors · 2015-03-23T18:33:55Z

💔 Test failed - auto-win-32-nopt-t

alexcrichton · 2015-03-23T18:35:15Z

@bors: retry

bors · 2015-03-23T18:45:17Z

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt are reusable. Rebuilding only auto-win-32-nopt-t...

bors · 2015-03-23T20:52:24Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

bors · 2015-03-23T20:52:35Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

Ms2gerand others added 8 commits March 20, 2015 13:29

Update librustc's README.txt for some code changes and reformat it.
41a7177

Make librustc's markdown README.txt claim to be markdown.
3bdb5c3
This allows github to render it with formatting.

environment variables -> environment
8f0de74
As @sanxiyn says, rust-lang#23527 (comment)

Remove manual numbers from TRPL
9acdcba
Rustbook already does this.

Fix documentation for std::sync::mutex: into_guard -> into_inner
84b14c5

Add tests checking that a number of feature gates are gating their f…
c48bb85
…eatures. Namely: * `box_syntax` * `box_patterns` * `simd_ffi` * `macro_reexport` cc rust-lang#22820

Fix volatile / atomic ops on bools and small aggregates
d4ca1cf
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixesrust-lang#23550

bors added a commit that referenced this pull request Mar 22, 2015
Auto merge of#23593- Manishearth:rollup, r=Manishearth
bd0881a
(yay, no Saturday)

Manishearth added 8 commits March 23, 2015 04:54

Rollup merge ofrust-lang#23570- dotdash:issue23550, r=eddyb
d8baa01
Boolean values and small aggregates have a different type in args/allocas than in SSA values but the intrinsics for volatile and atomic ops were missing the necessary casts to handle that. Fixesrust-lang#23550

Rollup merge ofrust-lang#23578- fhahn:issue-22820-feature-gate-test…
718fe3d
…s1, r=alexcrichton ...ures. Namely: * `box_syntax` * `box_patterns` * `simd_ffi` * `macro_reexport` cc rust-lang#22820

Rollup merge ofrust-lang#23554- Ms2ger:readme-rustc, r=steveklabnik
420bf9d

Rollup merge ofrust-lang#23555- steveklabnik:environment, r=sanxiyn
78b61be
As @sanxiyn says, rust-lang#23527 (comment)

Rollup merge ofrust-lang#23562- steveklabnik:fix_book_numbers, r=al…
f5782fa
…excrichton Rustbook already does this.

Rollup merge ofrust-lang#23576- barosl:mutex-doc, r=alexcrichton
5b9e87b

Rollup merge ofrust-lang#23590- FuGangqiang:attr, r=alexcrichton
b4e9106

bors added a commit that referenced this pull request Mar 23, 2015
Auto merge of#23593- Manishearth:rollup, r=Manishearth
809a554
(yay, no Saturday)

bors merged commit b4e9106 into rust-lang:masterMar 23, 2015

This was referenced Mar 23, 2015
Convert index operator to be by value #23601
Merged
[RFC] Entry API v3: replace Entry::get with Entry::default and Entry::default_with #22930
Merged

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Uh oh!

Uh oh!

Conversation

Manishearth commented Mar 21, 2015

Uh oh!

Manishearth commented Mar 21, 2015

Uh oh!

bors commented Mar 21, 2015

Uh oh!

Manishearth commented Mar 21, 2015

Uh oh!

bors commented Mar 21, 2015

Uh oh!

bors commented Mar 21, 2015

Uh oh!

dotdash commented Mar 21, 2015

Uh oh!

bors commented Mar 21, 2015

Uh oh!

bors commented Mar 21, 2015

Uh oh!

Manishearth commented Mar 22, 2015

Uh oh!

bors commented Mar 22, 2015

Uh oh!

bors commented Mar 22, 2015

Uh oh!

Manishearth commented Mar 22, 2015

Uh oh!

bors commented Mar 22, 2015

Uh oh!

bors commented Mar 22, 2015

Uh oh!

Manishearth commented Mar 22, 2015

Uh oh!

bors commented Mar 22, 2015

Uh oh!

bors commented Mar 22, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

Manishearth commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

barosl commented Mar 23, 2015

Uh oh!

Manishearth commented Mar 23, 2015

Uh oh!

Manishearth commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

Manishearth commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

alexcrichton commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

bors commented Mar 23, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!