Uh oh!
There was an error while loading. Please reload this page.
syntax: Document the AST - #23428
Conversation
Munksgaard
commented
Mar 17, 2015
👍 |
169034f to
9d2ffabCompareThere was a problem hiding this comment.
Maybe "distinguishes between unsafe { ... } and { ... }.
huonw
commented
Mar 18, 2015
Looks great; just a few little nits. (r=me once fixed) |
ghost
commented
Mar 18, 2015
In the future it may be worth considering converting some of the variants into struct variants so that the types are more self-documenting. |
Manishearth
commented
Mar 18, 2015
@bors: r=huon |
bors
commented
Mar 18, 2015
📌 Commit a5828ff has been approved by |
I often have to run `ast-json` or look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff). r? @steveklabnik f? @eddyb
There was a problem hiding this comment.
you need a line break between these two unless you want them to get rendered all together
steveklabnik
commented
Mar 18, 2015
This is missing a ton of periods at the end of buches of summaries. other than that and the few other things I mentioned, looks pretty good. |
bors
commented
Mar 18, 2015
☔ The latest upstream changes (presumably #23473) made this pull request unmergeable. Please resolve the merge conflicts. |
I often have to run
ast-jsonor look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff).r? @steveklabnik
f? @eddyb