Uh oh!
There was an error while loading. Please reload this page.
Rollup of PRs in the queue; Wednesday - #23473
Merged
Merged
Conversation
Very minor fix: in `std::net::Ipv6Addr::new`, the documentation had an incomplete representation of the resulting address, missing the last two groups.
The alignment field is actually a "pointer sized" type instead of always i64, requiring that the size of the padding field is also calculated slightly differently. Closesrust-lang#23425
This commit clarifies some of the unstable features in the `str` module by moving them out of the blanket `core` and `collections` features. The following methods were moved to the `str_char` feature which generally encompasses decoding specific characters from a `str` and dealing with the result. It is unclear if any of these methods need to be stabilized for 1.0 and the most conservative route for now is to continue providing them but to leave them as unstable under a more specific name. * `is_char_boundary` * `char_at` * `char_range_at` * `char_at_reverse` * `char_range_at_reverse` * `slice_shift_char` The following methods were moved into the generic `unicode` feature as they are specifically enabled by the `unicode` crate itself. * `nfd_chars` * `nfkd_chars` * `nfc_chars` * `graphemes` * `grapheme_indices` * `width`
Closesrust-lang#23451. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Manishearth
commented
Mar 18, 2015
MemberAuthor
@bors: r+ p=20 |
bors
commented
Mar 18, 2015
Collaborator
📌 Commit 8827f9b has been approved by |
bors
commented
Mar 18, 2015
Collaborator
⌛ Testing commit 8827f9b with merge 31694ba... |
bors
commented
Mar 18, 2015
Collaborator
💔 Test failed - auto-mac-64-nopt-t |
Manishearth
commented
Mar 18, 2015
MemberAuthor
@bors: r+ p=20 force |
bors
commented
Mar 18, 2015
Collaborator
📌 Commit e4ac4a4 has been approved by |
bors
commented
Mar 18, 2015
Collaborator
⌛ Testing commit e4ac4a4 with merge 61b416d... |
bors
commented
Mar 18, 2015
Collaborator
💔 Test failed - auto-win-64-opt |
Manishearth
commented
Mar 18, 2015
MemberAuthor
@bors: r+ p=20 force |
bors
commented
Mar 18, 2015
Collaborator
📌 Commit baf7f18 has been approved by |
bors
commented
Mar 18, 2015
Collaborator
⌛ Testing commit baf7f18 with merge 1608432... |
bors
commented
Mar 18, 2015
Collaborator
💔 Test failed - auto-win-64-opt |
Manishearth
commented
Mar 18, 2015
MemberAuthor
@bors: r+ p=20 |
bors
commented
Mar 18, 2015
Collaborator
📌 Commit 2a106d6 has been approved by |
Manishearth
commented
Mar 18, 2015
MemberAuthor
@bors: force |
bors
commented
Mar 18, 2015
Collaborator
⌛ Testing commit 2a106d6 with merge 15bcda8... |
This commit clarifies some of the unstable features in the `str` module by moving them out of the blanket `core` and `collections` features. The following methods were moved to the `str_char` feature which generally encompasses decoding specific characters from a `str` and dealing with the result. It is unclear if any of these methods need to be stabilized for 1.0 and the most conservative route for now is to continue providing them but to leave them as unstable under a more specific name. * `is_char_boundary` * `char_at` * `char_range_at` * `char_at_reverse` * `char_range_at_reverse` * `slice_shift_char` The following methods were moved into the generic `unicode` feature as they are specifically enabled by the `unicode` crate itself. * `nfd_chars` * `nfkd_chars` * `nfc_chars` * `graphemes` * `grapheme_indices` * `width`
…r=Manishearth Since module `std::sync::mpsc` is stable now, fix the deprecated link `comm` with `sync::mpsc`.
…x, r=steveklabnik Very minor fix: in `std::net::Ipv6Addr::new`, the documentation had an incomplete representation of the resulting address, missing the last two groups.
…r=brson The alignment field is actually a \"pointer sized\" type instead of always i64, requiring that the size of the padding field is also calculated slightly differently. Closesrust-lang#23425
I often have to run `ast-json` or look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff). r? @steveklabnik f? @eddyb
alexcrichton
commented
Mar 18, 2015
Member
@bors: retry force |
bors added a commit
that referenced
this pull request
Mar 18, 2015
bors
commented
Mar 18, 2015
Collaborator
bors
commented
Mar 18, 2015
Collaborator
This was referenced Mar 18, 2015
alexcrichton
commented
Mar 18, 2015
Member
@bors falls again to the iron will of @Manishearth! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.