Uh oh!
There was an error while loading. Please reload this page.
Rollup of PRs in the queue; Friday - #24524
Merged
Merged
Conversation
It generates a warning that --outdir argument is ignored, which is captured and spoils the output Also ensure that test output is captured in a different file than the expected output file
Implement `Debug`, `Display` and `Error` for `FatalError` and `ExplicitBug`
The Debug impl was using quotes, which was inconsistent:
=> (.., 1.., 2..3, ..4)
("..", 1.., 2..3, ..4)
Fix to use just ..The document does not display properly if the link id contains a space.
This ensures that later when generating HTML, the JSON will be sorted aswell. We now have a deterministic build of sidebar-items.js
This seems to fix the test
Fixesrust-lang#24070 or rather, fixes it even though it's already been fixed: slices are before now. But the linking is nice anyway.
Manishearth
commented
Apr 17, 2015
MemberAuthor
@bors: r+ p=100 force |
bors
commented
Apr 17, 2015
Collaborator
📌 Commit 8df397d has been approved by |
bors
commented
Apr 17, 2015
Collaborator
⌛ Testing commit 8df397d with merge e720f88... |
Fix Debug impl for RangeFull The Debug impl was using quotes, which was inconsistent: => (.., 1.., 2..3, ..4) (\"..\", 1.., 2..3, ..4) Fix to use just ..
When emmitting a note, previously it was not known if the note was for an error or a
warning. If it was for a warning, then with `-Awarnings` it should not have been print.
The `emit_for` function allows someone to specify which level should determine its visibility.
An example:
```rust
extern crate \"std\" as std2;
fn main() {}
```
When compiling with `-Awarnings`, this would previously emit `note: use an identifier not in quotes instead` (and nothing else).
With this patch, it will be completely silent as expected.…steveklabnik The document does not display properly if the link id contains a space.
…xcrichton This ensures that later when generating HTML, the JSON will be sorted aswell. We now have a more deterministic build of sidebar-items.js Closesrust-lang#24473
Fix broken links in various parts of the docs. I also found a dead link [here](http://doc.rust-lang.org/nightly/alloc/boxed/) (the first link on the page), but the chapter of the book that it used to point at seems to be gone, and I'm not sure what should happen to that link.
Fixesrust-lang#24070 or rather, fixes it even though it's already been fixed: slices are before now. But the linking is nice anyway.
bors
commented
Apr 17, 2015
Collaborator
💔 Test failed - auto-mac-64-nopt-t |
Manishearth
commented
Apr 17, 2015
MemberAuthor
sigh can't repro locally on Linux :/ |
pnkfelix
commented
Apr 17, 2015
Contributor
@Manishearth I'll look to see if I can repro. |
Manishearth
commented
Apr 17, 2015
MemberAuthor
Thanks! |
pnkfelix
commented
Apr 17, 2015
Contributor
I cannot reproduce locally. :( |
alexcrichton
commented
Apr 17, 2015
Member
@bors: retry Looks like one of the git folders on the OSX builders got corrupted from a build cancelled-to-soon causing all future builds to fail. |
bors added a commit
that referenced
this pull request
Apr 17, 2015
bors
commented
Apr 17, 2015
Collaborator
bors
commented
Apr 17, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.