Uh oh!
There was an error while loading. Please reload this page.
Model lexer: Fix remaining issues - #24620
Merged
Merged
Conversation
Completed XID_Start and XID_Continue rules
pczarn
commented
Apr 20, 2015
ContributorAuthor
cc @fhahn |
rust-highfive
commented
Apr 20, 2015
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
fhahn
commented
Apr 20, 2015
Contributor
@ pczarn 👍, thanks for taking the time to complete this :) |
alexcrichton
commented
Apr 20, 2015
Member
cc @cmr Looks like there are some tidy errors, but nice work! |
pczarn
commented
Apr 21, 2015
ContributorAuthor
Updated |
emberian
commented
Apr 21, 2015
Contributor
Nice work! I'm pleased to see this :) @bors r+ rollup |
bors
commented
Apr 21, 2015
Collaborator
📌 Commit 13bc8af has been approved by |
bors
commented
Apr 21, 2015
Collaborator
Contributor
There was a problem hiding this comment.
bors
commented
Apr 21, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#15679
Fixes#15878
Fixes#15882
Closes#15883