Remove more deprecated functionality by alexcrichton · Pull Request #24636 · rust-lang/rust

alexcrichton · 2015-04-20T18:59:46Z

This removes a large amount of deprecated functionality (pre-1.0 beta). Mostly this cleans up std::num.

rust-highfive · 2015-04-20T18:59:58Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

brson · 2015-04-20T19:03:39Z

I tagged this with 'beta' so we don't forget this needs to go in.

brson · 2015-04-20T19:04:05Z

@bors r+

bors · 2015-04-20T19:04:07Z

📌 Commit cdaf880 has been approved by brson

tamird · 2015-04-20T23:16:58Z

this failed tidy

bors · 2015-04-21T03:57:45Z

☔ The latest upstream changes (presumably #24648) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2015-04-21T05:26:38Z

@bors: r=brson 92369da p=1

bors · 2015-04-21T07:20:03Z

⌛ Testing commit 92369da with merge 1860461...

bors · 2015-04-21T07:24:08Z

💔 Test failed - auto-linux-32-opt

bors · 2015-04-21T16:46:08Z

☔ The latest upstream changes (presumably #24620) made this pull request unmergeable. Please resolve the merge conflicts.

Cleaning out more deprecated items

This commit removes all the old casting/generic traits from `std::num` that are no longer in use by the standard library. This additionally removes the old `strconv` module which has not seen much use in quite a long time. All generic functionality has been supplanted with traits in the `num` crate and the `strconv` module is supplanted with the [rust-strconv crate][rust-strconv]. [rust-strconv]: https://github.com/lifthrasiir/rust-strconv This is a breaking change due to the removal of these deprecated crates, and the alternative crates are listed above. [breaking-change]

alexcrichton · 2015-04-21T18:38:52Z

@bors: r=brson 41dddce

bors · 2015-04-21T19:48:44Z

⌛ Testing commit 41dddce with merge db958b7...

bors · 2015-04-21T19:54:25Z

💔 Test failed - auto-win-64-nopt-t

alexcrichton · 2015-04-21T20:35:29Z

@bors: r+

On Tue, Apr 21, 2015 at 12:54 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/3105
—
Reply to this email directly or view it on GitHub
#24636 (comment).

bors · 2015-04-21T20:35:30Z

📌 Commit 1a10133 has been approved by alexcrichton

bors · 2015-04-21T21:13:25Z

⌛ Testing commit 1a10133 with merge 09e67cf...

bors · 2015-04-21T21:18:28Z

💔 Test failed - auto-win-64-nopt-t

alexcrichton · 2015-04-21T21:59:15Z

@bors: r+ 028aaaa

This API was exercised in a few tests and mirrors the `from_str_radix` functionality of the integer types.

alexcrichton · 2015-04-21T22:26:16Z

@bors: r+ a568a7f

Conflicts: src/libcore/result.rs

pnkfelix · 2015-04-23T21:57:00Z

going from nominated to (nominated, accepted)

rust-highfive assigned brson Apr 20, 2015

brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2015

tamird reviewed Apr 20, 2015
View reviewed changes

Comment threadsrc/libcoretest/num/mod.rs Outdated
tamirdApr 20, 2015
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this failed tidy

alexcrichton force-pushed the remove-deprecated branch 2 times, most recently from c1da532 to 92369daCompare April 21, 2015 05:26

alexcrichton added 4 commits April 21, 2015 11:37

std: Remove deprecated AsOsStr/Str/AsSlice traits
69ded69
Cleaning out more deprecated items

std: Remove deprecated AsPath trait
e091ba3

test: Fix fallout in tests
0791f9f

alexcrichton force-pushed the remove-deprecated branch 2 times, most recently from 3e5a4af to 41dddceCompare April 21, 2015 18:38

alexcrichton force-pushed the remove-deprecated branch from 41dddce to 1a10133Compare April 21, 2015 20:35

alexcrichton force-pushed the remove-deprecated branch from 1a10133 to 028aaaaCompare April 21, 2015 21:59

alexcrichton force-pushed the remove-deprecated branch 2 times, most recently from 8f0650e to 1a19c78Compare April 21, 2015 22:23

std: Bring back f32::from_str_radix as an unstable API
a568a7f
This API was exercised in a few tests and mirrors the `from_str_radix` functionality of the integer types.

alexcrichton force-pushed the remove-deprecated branch from 1a19c78 to a568a7fCompare April 21, 2015 22:24

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 21, 2015
rollup merge ofrust-lang#24636: alexcrichton/remove-deprecated
a1dd5ac
Conflicts: src/libcore/result.rs

bors merged commit a568a7f into rust-lang:masterApr 22, 2015

This was referenced Apr 22, 2015
Remove or unstabilize all deprecated items in 1.0.0 #24691
Closed
Cherry-picking beta-nominated in to beta #24708
Merged

pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 23, 2015

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 23, 2015

alexcrichton deleted the remove-deprecated branch April 30, 2015 02:12

cuviper mentioned this pull request Dec 21, 2017
Add rsqrt method to Float trait rust-num/num-traits#1
Open

Uh oh!

Uh oh!

Conversation

alexcrichton commented Apr 20, 2015

Uh oh!

rust-highfive commented Apr 20, 2015

Uh oh!

brson commented Apr 20, 2015

Uh oh!

brson commented Apr 20, 2015

Uh oh!

bors commented Apr 20, 2015

Uh oh!

tamirdApr 20, 2015

Choose a reason for hiding this comment

Uh oh!

bors commented Apr 21, 2015

Uh oh!

alexcrichton commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

alexcrichton commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

alexcrichton commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

bors commented Apr 21, 2015

Uh oh!

alexcrichton commented Apr 21, 2015

Uh oh!

alexcrichton commented Apr 21, 2015

Uh oh!

pnkfelix commented Apr 23, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants