Uh oh!
There was an error while loading. Please reload this page.
Style guidelines: Change name of unit test sub-module to "tests". - #24783
Conversation
Changes the style guidelines regarding unit tests to recommend using a sub-module named "tests" instead of "test" for unit tests as "test" might clash with imports of libtest.
rust-highfive
commented
Apr 24, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
steveklabnik
commented
Apr 24, 2015
Doc stuff is good, but I'm not sure if we want to actually change the whole standard library over. but maybe? Let's see what others think. (Oh, and thanks for the PR!) |
alexcrichton
commented
Apr 24, 2015
liigo
commented
Apr 25, 2015
Nice! |
Changes the style guidelines regarding unit tests to recommend using a sub-module named "tests" instead of "test" for unit tests as "test" might clash with imports of libtest (see #23870, #24030 and http://users.rust-lang.org/t/guidelines-naming-of-unit-test-module/1078 for previous discussions). r? @alexcrichton
bors
commented
Apr 25, 2015
bors
commented
Apr 25, 2015
steveklabnik
commented
Apr 25, 2015
marking for docs backport, but just the |
Only backporting the style portion, as changing the test suite is needless churn, and the book/reference are getting their own imports at the end.
Since rust-lang#24783, the style guidelines recommend that unit tests should live in a submodule `tests` rather than `test` to not clash with the possible use of libtest. This is especially important for benchmark tests as they require libtest. Fixesrust-lang#24923.
Since rust-lang#24783, the style guidelines recommend that unit tests should live in a submodule `tests` rather than `test` to not clash with the possible use of libtest. This is especially important for benchmark tests as they require libtest. Fixesrust-lang#24923.
Changes the style guidelines regarding unit tests to recommend using a sub-module named "tests" instead of "test" for unit tests as "test" might clash with imports of libtest (see #23870, #24030 and http://users.rust-lang.org/t/guidelines-naming-of-unit-test-module/1078 for previous discussions).
r? @alexcrichton