Skip to content

Add test for #15919 - #24987

Closed
bombless wants to merge 2 commits into
rust-lang:masterfrom
bombless:large-array
Closed

Add test for #15919#24987
bombless wants to merge 2 commits into
rust-lang:masterfrom
bombless:large-array

Conversation

@bombless

@bomblessbombless commented Apr 30, 2015

Copy link
Copy Markdown
Contributor

Closes#15919

@rust-highfive

rust-highfive commented Apr 30, 2015

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix

pnkfelix commented Apr 30, 2015

Copy link
Copy Markdown
Contributor

@bors r+ b60c3e2 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request May 1, 2015
@Manishearth
Rollup merge ofrust-lang#24987- bombless:large-array, r=pnkfelix
fe54be2
Closesrust-lang#15919
@ManishearthManishearth mentioned this pull request May 1, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 1, 2015
@Manishearth
Fixuprust-lang#24987
ac12fc8
@Manishearth

Manishearth commented May 1, 2015

Copy link
Copy Markdown
Member

@bors: r-

The test fails due to an unexpected warning. Manishearth@ac12fc8 fixes that, but the error disappears. Please fix these first, thanks!

bors added a commit that referenced this pull request May 1, 2015
@bors
Auto merge of#25025- Manishearth:rollup, r=Manishearth
1320c29
- Successful merges: #24979, #24980, #24981, #24982, #24983, #24987, #24988, #24991, #24992, #24994, #24998, #25002, #25010, #25014, #25020, #25021
- Failed merges:
@bombless

bombless commented May 1, 2015

Copy link
Copy Markdown
ContributorAuthor

Sorry, I'll reopen it once I fix it.

@bomblessbombless closed this May 1, 2015
@bombless

bombless commented May 1, 2015

Copy link
Copy Markdown
ContributorAuthor

Okay, fixed. Sorry for the trouble.
r? @pnkfelix

@bomblessbombless reopened this May 1, 2015
@bombless

bombless commented May 12, 2015

Copy link
Copy Markdown
ContributorAuthor

r? @pnkfelix

@rust-highfiverust-highfive assigned pnkfelix and unassigned brsonMay 12, 2015
@pnkfelix

pnkfelix commented May 12, 2015

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 12, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 4c8b813 has been approved by pnkfelix

@pnkfelix

pnkfelix commented May 12, 2015

Copy link
Copy Markdown
Contributor

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 12, 2015
@steveklabnik
Rollup merge ofrust-lang#24987- bombless:large-array, r=pnkfelix
6987900
Closesrust-lang#15919
@steveklabniksteveklabnik mentioned this pull request May 12, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 13, 2015
@steveklabnik
Rollup merge ofrust-lang#24987- bombless:large-array, r=pnkfelix
d3dd694
Closesrust-lang#15919
@steveklabniksteveklabnik mentioned this pull request May 13, 2015
Closed
@steveklabnik

steveklabnik commented May 13, 2015

Copy link
Copy Markdown
Contributor

This still doesn't work, and caused the rollup to fail http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4955/steps/test/logs/stdio

@steveklabnik

steveklabnik commented May 13, 2015

Copy link
Copy Markdown
Contributor

@bors: r-

@bombless

bombless commented May 13, 2015

Copy link
Copy Markdown
ContributorAuthor

Mac again... so the bug still exist on Mac OSX in a different form, closing this PR.

@Manishearth

Manishearth commented May 13, 2015

Copy link
Copy Markdown
Member

It's not a mac issue; it's a 32bit vs 64bit issue.

(mac is just the fastest builder and fails first)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fixed length array type with high un-suffixed count literal incorrectly treated as negative count

8 participants

@bombless@rust-highfive@pnkfelix@Manishearth@bors@steveklabnik@oli-obk@brson