Uh oh!
There was an error while loading. Please reload this page.
Mark the {min,max}_value functions on integers #[inline]. - #25010
Merged
Conversation
rust-highfive
commented
Apr 30, 2015
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Apr 30, 2015
Member
alexcrichton
commented
Apr 30, 2015
Member
@bors: rollup |
These compile down to `mov $CONSTANT, register; ret`, but the lack of `#[inline]` meant they have a full `call ...` when used from external crates.
huonw
commented
Apr 30, 2015
ContributorAuthor
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
May 1, 2015
…ichton These compile down to `mov $CONSTANT, register; ret`, but the lack of `#[inline]` meant they have a full `call ...` when used from external crates.
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
May 1, 2015
…ichton These compile down to `mov $CONSTANT, register; ret`, but the lack of `#[inline]` meant they have a full `call ...` when used from external crates.
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
May 1, 2015
…ichton These compile down to `mov $CONSTANT, register; ret`, but the lack of `#[inline]` meant they have a full `call ...` when used from external crates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These compile down to
mov $CONSTANT, register; ret, but the lack of#[inline]meant they have a fullcall ...when used from externalcrates.