Uh oh!
There was an error while loading. Please reload this page.
Rustdoc search: Increase relevance of primitive types - #25702
Conversation
There are more possible optimizations left (cached length in loops) as well as some possible bugs (shadowed variables) to fix. This is mostly syntactic.
rust-highfive
commented
May 22, 2015
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
bluss
commented
May 22, 2015
This is a great idea. What do you think about just a simpler phrase like (primitive type) for the highlight? |
killercup
commented
May 22, 2015
@bluss, I like that. Italic, too? |
Gankra
commented
May 22, 2015
r=me with the (primitive type) hint updated as discussed. |
1253c13 to
07b1994Comparekillercup
commented
May 22, 2015
@gankro thanks for the review. This is how it looks now: |
Gankra
commented
May 22, 2015
@bors r+ rollup Awesome, thanks! |
bors
commented
May 22, 2015
📌 Commit 07b1994 has been approved by |
07b1994 to
ec60d9fComparekillercup
commented
May 22, 2015
@gankro I think bors picked the commit I just replaced. (Doesn't matter though, I only changed the commit message.) |
Gankra
commented
May 22, 2015
@bors r- |
Gankra
commented
May 22, 2015
@bors r+ ec60d |
Gankra
commented
May 22, 2015
(we'll see if that worked... the PR is certainly still approved in the queue...) |
killercup
commented
May 22, 2015
Thanks! :) |
steveklabnik
commented
May 22, 2015
bluss
commented
May 22, 2015
Lol I didn't intend the italic. Either works. |
Gankra
commented
May 22, 2015
I liked the italic, and it's trivial to fiddle with later. |
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)
…, r=Gankro This minimally changes rustdoc's search as described in rust-lang#25167. Additionally, I also cleaned up some parts of the JS code. There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.  cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)

This minimally changes rustdoc's search as described in #25167.
Additionally, I also cleaned up some parts of the JS code.
There is one more change I made: After each result for a primitive type, I added "(Overview of primitive type)". This further differentiates the result from the module (previously, the only difference was that the module's link was blue). I'm not this is the way to go (this seems to be the only place where we do this) and it's no problem for me to remove that commit.
cc @steveklabnik (it concerns docs) and @alexcrichton (who made changes to rustdoc previously)