Uh oh!
There was an error while loading. Please reload this page.
Remove the unecessary ParamBounds struct - #26354
Merged
Merged
Conversation
ContributorAuthor
There was a problem hiding this comment.
For conventions sake I should probably change this back to parse_bounds_, didn't realize the convention until I was looking over the change set.
nikomatsakis
commented
Jun 18, 2015
Contributor
this looks good. r+ when travis is pacified. |
nikomatsakis
commented
Jun 18, 2015
Contributor
@bors r+ |
bors
commented
Jun 18, 2015
Collaborator
📌 Commit dfb2ee3 has been approved by |
bors
commented
Jun 19, 2015
Collaborator
☔ The latest upstream changes (presumably #26351) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Jun 21, 2015
Collaborator
🔒 Merge conflict |
nikomatsakis
commented
Jun 22, 2015
Contributor
@jroesch needs rebase... |
jroesch
commented
Jun 23, 2015
ContributorAuthor
@nikomatsakis sorry about the hold up had to integrate with huge patch from eddyb. I also slightly cleaned up the code due to some changes in master, did a rebase and squash as well. |
jroeschforce-pushed
the
remove-param-bounds-take-n
branch
from
June 23, 2015 07:10
dfb2ee3 to
81e5c1fComparenikomatsakis
commented
Jun 23, 2015
Contributor
@bors r+ |
bors
commented
Jun 23, 2015
Collaborator
📌 Commit 81e5c1f has been approved by |
bors
commented
Jun 23, 2015
Collaborator
bors added a commit
that referenced
this pull request
Jun 23, 2015
…akis This pull request removes `ParamBounds` a old holdover in the type checker that we (@nikomatsakis and I) had wanted to remove. I'm not sure if the current form is the best possible refactor but I figured we can use this as a place to discuss it. r? @nikomatsakis
bors
commented
Jun 23, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes
ParamBoundsa old holdover in the type checker that we (@nikomatsakis and I) had wanted to remove. I'm not sure if the current form is the best possible refactor but I figured we can use this as a place to discuss it.r? @nikomatsakis