Uh oh!
There was an error while loading. Please reload this page.
Rename AsPredicate to ToPredicate in order to match naming conventions - #26415
Conversation
rust-highfive
commented
Jun 19, 2015
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
commented
Jun 19, 2015
r+ (but needs rebase) |
a1612f8 to
4f441f9Comparenikomatsakis
commented
Jun 19, 2015
@bors r+ |
bors
commented
Jun 19, 2015
📌 Commit 4f441f9 has been approved by |
bors
commented
Jun 19, 2015
☔ The latest upstream changes (presumably #26351) made this pull request unmergeable. Please resolve the merge conflicts. |
4f441f9 to
af9e3b7Comparearielb1
commented
Jun 20, 2015
@bors r=nmatsakis |
bors
commented
Jun 20, 2015
📌 Commit af9e3b7 has been approved by |
bors
commented
Jun 20, 2015
⌛ Testing commit af9e3b7 with merge ac16fe3... |
bors
commented
Jun 20, 2015
💔 Test failed - auto-linux-64-nopt-t |
bors
commented
Jun 23, 2015
☔ The latest upstream changes (presumably #26435) made this pull request unmergeable. Please resolve the merge conflicts. |
af9e3b7 to
0914c52Comparealexcrichton
commented
Jun 23, 2015
@bors:r=nikomatsakis 0914c52 |
bluss
commented
Jun 23, 2015
I'm sorry but I don't see any fix to address the error bors found for you: |
bors
commented
Jun 23, 2015
☔ The latest upstream changes (presumably #26354) made this pull request unmergeable. Please resolve the merge conflicts. |
jroesch
commented
Jun 23, 2015
@bluss I built the wrong branch last night before pushing, should be fixed. |
0914c52 to
eab2895Comparealexcrichton
commented
Jun 23, 2015
@bors: r=nikomatsakis On Tue, Jun 23, 2015 at 8:49 AM Jared Roesch notifications@github.com
|
bors
commented
Jun 23, 2015
📌 Commit eab2895 has been approved by |
88631b3 to
8433801Compare8433801 to
44bccd8Comparealexcrichton
commented
Jun 26, 2015
@bors: r=nikomatsakis 44bccd8 |
@nikomatsakis and I ran into this earlier and I figured we should rename the trait and method to match the typical naming convention.
bors
commented
Jun 26, 2015
⌛ Testing commit 44bccd8 with merge b70d1c6... |
@nikomatsakis and I ran into this earlier and I figured we should rename the trait and method to match the typical naming convention.