Skip to content

add error diagnostics for E0437, E0438 - #27145

Merged
bors merged 1 commit into
rust-lang:masterfrom
apasel422:diagnostic-407-437-438
Jul 24, 2015
Merged

add error diagnostics for E0437, E0438#27145
bors merged 1 commit into
rust-lang:masterfrom
apasel422:diagnostic-407-437-438

Conversation

@apasel422

@apasel422apasel422 commented Jul 20, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jul 20, 2015

Copy link
Copy Markdown
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

tamird
tamird reviewed Jul 20, 2015
View reviewed changes
Comment threadsrc/librustc_resolve/diagnostics.rs Outdated

@tamirdtamirdJul 20, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: declare isn't quite right here. the trait itself "declares" the methods, and the impl implements them.

@apasel422apasel422Jul 20, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "implement" be used for each of the item types (not just methods)?

@apasel422

apasel422 commented Jul 20, 2015

Copy link
Copy Markdown
ContributorAuthor

Nits addressed.

@apasel422

apasel422 commented Jul 22, 2015

Copy link
Copy Markdown
ContributorAuthor

r? @Manishearth

Manishearth
Manishearth reviewed Jul 22, 2015
View reviewed changes
Comment threadsrc/librustc_resolve/diagnostics.rs

@ManishearthManishearthJul 22, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a trait method in this example

@apasel422

apasel422 commented Jul 22, 2015

Copy link
Copy Markdown
ContributorAuthor

@Manishearth Updated.

@bors

bors commented Jul 22, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #27219) made this pull request unmergeable. Please resolve the merge conflicts.

@apasel422apasel422 changed the title add error diagnostics for E0407, E0437, E0438add error diagnostics for E0437, E0438Jul 22, 2015
@apasel422

apasel422 commented Jul 23, 2015

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@Manishearth

Manishearth commented Jul 23, 2015

Copy link
Copy Markdown
Member

r=me with a trait method added

@apasel422

apasel422 commented Jul 23, 2015

Copy link
Copy Markdown
ContributorAuthor

To which one? This PR no longer addresses E0407.

@Manishearth

Manishearth commented Jul 23, 2015

Copy link
Copy Markdown
Member

@bors r+ rollup

oh, okay

@bors

bors commented Jul 23, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit cf8a163 has been approved by Manishearth

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 24, 2015
@steveklabnik
Rollup merge ofrust-lang#27145- apasel422:diagnostic-407-437-438, r…
3fa9090
…=Manishearth
@steveklabniksteveklabnik mentioned this pull request Jul 24, 2015
Merged
bors added a commit that referenced this pull request Jul 24, 2015
@bors
Auto merge of#27265- steveklabnik:rollup, r=steveklabnik
82d40cb
- Successful merges: #27137, #27145, #27177, #27193, #27212, #27220, #27229, #27235, #27238, #27244, #27251
- Failed merges:
@bors
bors merged commit cf8a163 into rust-lang:masterJul 24, 2015
@apasel422
apasel422 deleted the diagnostic-407-437-438 branch July 24, 2015 22:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ManishearthManishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@apasel422@rust-highfive@bors@Manishearth@tamird@pcwalton