Uh oh!
There was an error while loading. Please reload this page.
Add diagnostics for E0120 - #27220
Merged
Merged
Conversation
Manishearth
commented
Jul 22, 2015
Member
I think there are many use cases we should explore and give alternatives to:
|
AlisdairO
commented
Jul 22, 2015
ContributorAuthor
Alright, I'll have a look at that tomorrow. |
AlisdairO
commented
Jul 23, 2015
ContributorAuthor
I've had a stab at it, but would appreciate a review to make sure I'm going in the direction you were thinking of :-) |
Member
There was a problem hiding this comment.
leave a comment // or Box<MyTrait>, if you wanted an owned trait object
Manishearth
commented
Jul 23, 2015
Member
looks good to me! |
AlisdairO
commented
Jul 23, 2015
ContributorAuthor
Done, and squashed! |
Manishearth
commented
Jul 23, 2015
Member
@bors r+ rollup |
bors
commented
Jul 23, 2015
Collaborator
📌 Commit e668175 has been approved by |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 24, 2015
…arth As title! I should probably be bunching these up a bit more, but I'm not sure when my time is going to disappear on me. Once my schedule stabilises I'll try to start batching them into larger PRs. Part of rust-lang#24407. r? @Manishearth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title!
I should probably be bunching these up a bit more, but I'm not sure when my time is going to disappear on me. Once my schedule stabilises I'll try to start batching them into larger PRs.
Part of #24407.
r? @Manishearth