Skip to content

check upvars in closures that are in statics - #28131

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:static-upvars
Oct 1, 2015
Merged

check upvars in closures that are in statics#28131
bors merged 1 commit into
rust-lang:masterfrom
arielb1:static-upvars

Conversation

@arielb1

@arielb1arielb1 commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

Fixes#23057
Fixes#27890
Fixes#28099
Fixes#28113

r? @pnkfelix

arielb1
arielb1 reviewed Aug 31, 2015
View reviewed changes
Comment threadsrc/test/compile-fail/borrowck-in-static.rs

@arielb1arielb1Aug 31, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.

@alexcrichton

alexcrichton commented Sep 28, 2015

Copy link
Copy Markdown
Member

ping r? @pnkfelix

@pnkfelix

pnkfelix commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 30, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 565da72 has been approved by pnkfelix

@bors

bors commented Sep 30, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 565da72 with merge 7a78969...

@bors

bors commented Sep 30, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-msvc-64-opt

@arielb1

arielb1 commented Oct 1, 2015

Copy link
Copy Markdown
ContributorAuthor

@bors r=pnkfelix c01e050

@bors

bors commented Oct 1, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c01e050 with merge 24202c6...

bors added a commit that referenced this pull request Oct 1, 2015
@bors
Auto merge of#28131- arielb1:static-upvars, r=pnkfelix
24202c6
Fixes#23057Fixes#27890Fixes#28099Fixes#28113
r? @pnkfelix
@bors

bors commented Oct 1, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit c01e050 into rust-lang:masterOct 1, 2015
@arielb1arielb1 mentioned this pull request Oct 5, 2015
Closed
@alexcrichton

alexcrichton commented Oct 5, 2015

Copy link
Copy Markdown
Member

triage: beta-nominated

@arielb1 indicates that the regression reported in #28801 was fixed by this PR (e.g. working in 1.3, broken in 1.4 (beta), and working in 1.5), so nominating for a backport to beta.

@rust-highfiverust-highfive added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 5, 2015
@alexcrichtonalexcrichton added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 5, 2015
@pnkfelix

pnkfelix commented Oct 16, 2015

Copy link
Copy Markdown
Contributor

@rust-lang/compiler I'm in favor of backporting this PR to beta.

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 16, 2015
@nikomatsakis

nikomatsakis commented Oct 16, 2015

Copy link
Copy Markdown
Contributor

Accepted as fixes a regression.

@brsonbrson mentioned this pull request Oct 16, 2015
Merged
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 16, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arielb1@alexcrichton@pnkfelix@bors@nikomatsakis@rust-highfive