Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
check upvars in closures that are in statics by arielb1 · Pull Request #28131 · rust-lang/rust · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' check upvars in closures that are in statics by arielb1 · Pull Request #28131 · rust-lang/rust · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' check upvars in closures that are in statics by arielb1 · Pull Request #28131 · rust-lang/rust · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' check upvars in closures that are in statics by arielb1 · Pull Request #28131 · rust-lang/rust · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' check upvars in closures that are in statics by arielb1 · Pull Request #28131 · rust-lang/rust · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' check upvars in closures that are in statics by arielb1 · Pull Request #28131 · rust-lang/rust · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); check upvars in closures that are in statics by arielb1 · Pull Request #28131 · rust-lang/rust · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/librustc_typeck/check/mod.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -4124,8 +4124,13 @@ fn check_const_with_ty<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,

check_expr_with_hint(fcx, e, declty);
demand::coerce(fcx, e.span, declty, e);
fcx.select_all_obligations_or_error();

fcx.select_all_obligations_and_apply_defaults();
upvar::closure_analyze_const(&fcx, e);
fcx.select_obligations_where_possible();
fcx.check_casts();
fcx.select_all_obligations_or_error();

regionck::regionck_expr(fcx, e);
writeback::resolve_type_vars_in_expr(fcx, e);
}
Expand Down
14 changes: 14 additions & 0 deletions src/librustc_typeck/check/upvar.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,20 @@ pub fn closure_analyze_fn(fcx: &FnCtxt,
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

pub fn closure_analyze_const(fcx: &FnCtxt,
body: &hir::Expr)
{
let mut seed = SeedBorrowKind::new(fcx);
seed.visit_expr(body);
let closures_with_inferred_kinds = seed.closures_with_inferred_kinds;

let mut adjust = AdjustBorrowKind::new(fcx, &closures_with_inferred_kinds);
adjust.visit_expr(body);

// it's our job to process these.
assert!(fcx.inh.deferred_call_resolutions.borrow().is_empty());
}

///////////////////////////////////////////////////////////////////////////
// SEED BORROW KIND

Expand Down
22 changes: 22 additions & 0 deletions src/test/compile-fail/borrowck-in-static.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// check that borrowck looks inside consts/statics

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.


static FN : &'static (Fn() -> (Box<Fn()->Box<i32>>) + Sync) = &|| {
let x = Box::new(0);
Box::new(|| x) //~ ERROR cannot move out of captured outer variable
};

fn main() {
let f = (FN)();
f();
f();
}
15 changes: 15 additions & 0 deletions src/test/compile-fail/issue-28113.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

const X: u8 =
|| -> u8 { 5 }() //~ ERROR function calls in constants are limited
;

fn main() {}
16 changes: 16 additions & 0 deletions src/test/run-pass/issue-27890.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

static PLUS_ONE: &'static (Fn(i32) -> i32 + Sync) = (&|x: i32| { x + 1 })
as &'static (Fn(i32) -> i32 + Sync);

fn main() {
assert_eq!(PLUS_ONE(2), 3);
}