Skip to content

Use the correct mod name from the example - #28836

Merged
bors merged 1 commit into
rust-lang:masterfrom
id4ho:patch-6
Oct 8, 2015
Merged

Use the correct mod name from the example#28836
bors merged 1 commit into
rust-lang:masterfrom
id4ho:patch-6

Conversation

@id4ho

@id4hoid4ho commented Oct 4, 2015

Copy link
Copy Markdown
Contributor

@steveklabnik

steveklabnik commented Oct 4, 2015

Copy link
Copy Markdown
Contributor

Why is this change needed? "Cleanup" is too vague.

@id4hoid4ho changed the title Name cleanupUse the correct mod name from the exampleOct 5, 2015
@id4ho

id4ho commented Oct 5, 2015

Copy link
Copy Markdown
ContributorAuthor

@steveklabnik, you're right, sorry about that. I updated the title.

This change is not really a clean up so much as making the explanation match the state of the example.

In the first use statement (in the example above the change) we import the japanese::greetings module not the japanese::farewells module.

@steveklabnik

steveklabnik commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

Ah thanks! I see now. Would you mind doing a quick amend of the commit message too, so that the history reflects this info, not just the PR? Happy to merge this after.

@id4ho

id4ho commented Oct 7, 2015

Copy link
Copy Markdown
ContributorAuthor

@steveklabnik sure thing, commit message updated! Sorry for the delay.

@steveklabnik

steveklabnik commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Oct 7, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit d21b4f5 has been approved by steveklabnik

@steveklabnik

steveklabnik commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

No worries :) Thanks for the patch!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
@steveklabnik
Rollup merge ofrust-lang#28836- jackwilsonv:patch-6, r=steveklabnik
a5f3f89
r? @steveklabnik
@steveklabniksteveklabnik mentioned this pull request Oct 7, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
@steveklabnik
Rollup merge ofrust-lang#28836- jackwilsonv:patch-6, r=steveklabnik
18c66b5
r? @steveklabnik
@steveklabniksteveklabnik mentioned this pull request Oct 7, 2015
Merged
bors added a commit that referenced this pull request Oct 8, 2015
@bors
Auto merge of#28897- steveklabnik:rollup, r=steveklabnik
b75fe81
- Successful merges: #28836, #28856, #28874, #28876, #28878, #28880, #28882, #28885, #28889, #28896
- Failed merges:
@bors
bors merged commit d21b4f5 into rust-lang:masterOct 8, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@id4ho@steveklabnik@bors