Skip to content

rustfmt some submodules of libcore - #28896

Merged
bors merged 3 commits into
rust-lang:masterfrom
mkpankov:core-fmt
Oct 8, 2015
Merged

rustfmt some submodules of libcore#28896
bors merged 3 commits into
rust-lang:masterfrom
mkpankov:core-fmt

Conversation

@mkpankov

@mkpankovmkpankov commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

Review on Reviewable

@rust-highfive

rust-highfive commented Oct 7, 2015

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@mkpankov

mkpankov commented Oct 7, 2015

Copy link
Copy Markdown
ContributorAuthor

r? @nrc

@rust-highfiverust-highfive assigned nrc and unassigned brsonOct 7, 2015
nrc
nrc reviewed Oct 7, 2015
View reviewed changes
Comment threadsrc/libcore/fmt/num.rs Outdated

@nrcnrcOct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manually fix the above change but not this one? If not then it is probably a weird bug in rustfmt. In any case, could you fixup this comment too please?

@nrc

nrc commented Oct 7, 2015

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Oct 7, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 11a7773 has been approved by nrc

@nrc

nrc commented Oct 7, 2015

Copy link
Copy Markdown
Member

Thanks for the PR!

@mkpankov

mkpankov commented Oct 7, 2015

Copy link
Copy Markdown
ContributorAuthor

😃

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 7, 2015
@steveklabnik
Rollup merge ofrust-lang#28896- mkpankov:core-fmt, r=nrc
0fbf7ea
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/rust-lang/rust/28896)
<!-- Reviewable:end -->
@steveklabniksteveklabnik mentioned this pull request Oct 7, 2015
Merged
alexcrichton
alexcrichton reviewed Oct 7, 2015
View reviewed changes
Comment threadsrc/libcore/fmt/num.rs

@alexcrichtonalexcrichtonOct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nrc, perhaps rustfmt could auto-remove these semicolons?

@nrcnrcOct 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could and it should! https://github.com/nrc/rustfmt/issues/422

bors added a commit that referenced this pull request Oct 8, 2015
@bors
Auto merge of#28897- steveklabnik:rollup, r=steveklabnik
b75fe81
- Successful merges: #28836, #28856, #28874, #28876, #28878, #28880, #28882, #28885, #28889, #28896
- Failed merges:
@bors
bors merged commit 11a7773 into rust-lang:masterOct 8, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mkpankov@rust-highfive@nrc@bors@alexcrichton@brson