Uh oh!
There was an error while loading. Please reload this page.
Stricter doctests for corelibs - #29544
Conversation
3d1a605 to
956986aComparesteveklabnik
commented
Nov 10, 2015
This looks great, thanks! I love the idea of making these more strict, I just didn't take the time to do it myself. I'm going to merge as-is. I'm in the middle of going through the whole stdlib docs anyway, so if I want to make changes, I will do so then. This looks great for now. And keeping the commits split per library seems fine as well. |
steveklabnik
commented
Nov 10, 2015
@bors: r+ rollup |
bors
commented
Nov 10, 2015
📌 Commit 956986a has been approved by |
steveklabnik
commented
Nov 10, 2015
(sorry for the long review delay, as well :/) |
…labnik Did this alphabetically, so I didn't see [how `std` was doing things](https://dxr.mozilla.org/rust/source/src/libstd/lib.rs#215) till I was nearly finished. If you prefer to add crate-level-whitelists like std instead of test-level, I can rebase with that strategy. A number of these commits can probably be dropped as the crates don't have much to test, and are deprecated. Let me know which if any to drop! (can also squash after review if desired) r? @steveklabnik
bors
commented
Nov 10, 2015
☔ The latest upstream changes (presumably #29546) made this pull request unmergeable. Please resolve the merge conflicts. |
steveklabnik
commented
Nov 11, 2015
@Ryman you sent me a message on IRC, but you're not on now. Just a rebase is fine :) |
956986a to
5ae1937CompareRyman
commented
Nov 12, 2015
@steveklabnik rebased (and removed liblibc commit as it should be done on crates.io repo now)! |
steveklabnik
commented
Nov 12, 2015
@bors: r+ p=1 |
bors
commented
Nov 12, 2015
📌 Commit 5ae1937 has been approved by |
bors
commented
Nov 12, 2015
Did this alphabetically, so I didn't see [how `std` was doing things](https://dxr.mozilla.org/rust/source/src/libstd/lib.rs#215) till I was nearly finished. If you prefer to add crate-level-whitelists like std instead of test-level, I can rebase with that strategy. A number of these commits can probably be dropped as the crates don't have much to test, and are deprecated. Let me know which if any to drop! (can also squash after review if desired) r? @steveklabnik
steveklabnik
commented
Nov 12, 2015
(giving priority since this touches a lot of things) |
steveklabnik
commented
Nov 12, 2015
(but i guess the queue is already empty so) |
Did this alphabetically, so I didn't see how
stdwas doing things till I was nearly finished. If you prefer to add crate-level-whitelists like std instead of test-level, I can rebase with that strategy.A number of these commits can probably be dropped as the crates don't have much to test, and are deprecated. Let me know which if any to drop! (can also squash after review if desired)
r? @steveklabnik