Replace the in-tree libc with the external copy by alexcrichton · Pull Request #29546 · rust-lang/rust

alexcrichton · 2015-11-03T18:48:07Z

This commit replaces the in-tree liblibc with the external clone which has no evolved beyond the in-tree version in light of its recent redesign.

The primary changes here are:

src/liblibc/lib.rs was deleted
src/liblibc is now a submodule pointing at the external repository
src/libstd/sys/unix/{c.rs,sync.rs} were both deleted having all bindings folded into the external liblibc.
Many ad-hoc extern blocks in the standard library were removed in favor of bindings now being in the external liblibc.
Many functions/types were added to src/libstd/sys/windows/c.rs, and the scattered definitions throughout the standard library were consolidated here.

At the API level this commit is not a breaking change, although it is only very lightly tested on the *BSD variants and is probably going to break almost all of their builds! Follow-up commits to liblibc should in theory be all that's necessary to get the build working on the *BSDs again.

rust-highfive · 2015-11-03T18:48:20Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-11-03T18:49:45Z

cc @dhuseby, @semarie, @mneumann -- this is likely to break BSD builds, but if you want to test out I'd be more than willing to fix things up before it lands!

cc @rust-lang/libs -- fallout from the libc transition, especially on the Windows side of thing

r? @brson

brson · 2015-11-03T19:01:47Z

r=me

brson · 2015-11-03T19:02:13Z

Tagging this with relnotes to remind myself to mention the libc rewrite in the notes.

semarie · 2015-11-04T09:18:37Z

@alexcrichton thanks to cc me

yes, it seems to break openbsd, but it seems related to new-libc code. I will take a look.

semarie · 2015-11-04T15:10:04Z

I have made a PR for make openbsd (and bitrig, I hope) be able to build libc rust-lang/libc#39

But I still have a weird error while trying to build rustc with my PR (stop in stage1 libstd building):

../src/libstd/lib.rs:268:12: 268:25 error: unused or unknown feature, #[deny(unused_features)] on by default
../src/libstd/lib.rs:268 #![feature(drop_in_place)]

whereas a version with "plain" liblibc build fine.

semarie · 2015-11-04T18:37:54Z

@alexcrichton why this ? it breaks at least the openbsd build.
src/libstd/lib.rs has drop_in_place feature, but it used only on some targets. So removing unused_attributes will break stage1/stage2 for others.

Hm, I'll look into fixing, I'm not a huge fan of allowing lints like this which are intentionally here to help clean up some code!

alexcrichton · 2015-11-04T21:30:53Z

@bors: r=brson c30a40d

bors · 2015-11-04T22:29:30Z

⌛ Testing commit c30a40d with merge 4c0cd18...

bors · 2015-11-04T22:33:09Z

💔 Test failed - auto-mac-64-nopt-t

alexcrichton · 2015-11-04T22:54:05Z

@bors: r=brson 29ddae2

bors · 2015-11-04T23:39:05Z

⌛ Testing commit 29ddae2 with merge 8ace105...

bors · 2015-11-09T20:18:01Z

💔 Test failed - auto-linux-musl-64-opt

alexcrichton · 2015-11-09T21:08:10Z

@bors: r=brson 615c345

bors · 2015-11-09T21:23:54Z

⌛ Testing commit 615c345 with merge 7612930...

bors · 2015-11-09T21:56:02Z

💔 Test failed - auto-linux-cross-opt

alexcrichton · 2015-11-10T01:37:07Z

@bors: r=brson 9da29e0813aa051b15cfd97874bd163ee52ac859

bors · 2015-11-10T03:55:49Z

⌛ Testing commit 9da29e0 with merge 31ae76d...

bors · 2015-11-10T05:45:44Z

💔 Test failed - auto-linux-64-x-android-t

* Delete `sys::unix::{c, sync}` as these are now all folded into libc itself * Update all references to use `libc` as a result. * Update all references to the new flat namespace. * Moves all windows bindings into sys::c

alexcrichton · 2015-11-10T06:56:17Z

@bors: r=brson 3d28b8b

This commit replaces the in-tree liblibc with the [external clone](https://github.com/rust-lang-nursery/libc) which has no evolved beyond the in-tree version in light of its [recent redesign](rust-lang/rfcs#1291). The primary changes here are: * `src/liblibc/lib.rs` was deleted * `src/liblibc` is now a submodule pointing at the external repository * `src/libstd/sys/unix/{c.rs,sync.rs}` were both deleted having all bindings folded into the external liblibc. * Many ad-hoc `extern` blocks in the standard library were removed in favor of bindings now being in the external liblibc. * Many functions/types were added to `src/libstd/sys/windows/c.rs`, and the scattered definitions throughout the standard library were consolidated here. At the API level this commit is **not a breaking change**, although it is only very lightly tested on the *BSD variants and is probably going to break almost all of their builds! Follow-up commits to liblibc should in theory be all that's necessary to get the build working on the *BSDs again.

bors · 2015-11-10T06:56:31Z

⌛ Testing commit 3d28b8b with merge 6aee7c5...

bors · 2015-11-10T08:38:48Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

dhuseby · 2015-11-11T18:30:04Z

I've been in London at MozFest. I'm trying to catch up now.

mneumann · 2015-11-13T10:43:59Z

@dhuseby : One thing you have to fix for FreeBSD is to define SIGSTKSZ. I did it for DragonFly (rust-lang/libc#60), but didn't know the exact value for FreeBSD.

dhuseby · 2015-12-30T17:15:24Z

@mneumann thanks, i believe it's fixed now.

rust-highfive assigned nikomatsakis Nov 3, 2015

rust-highfive assigned brson and unassigned nikomatsakis Nov 3, 2015

alexcrichton force-pushed the new-libc branch from 15b73e3 to ac14743Compare November 3, 2015 18:54

brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 3, 2015

alexcrichton force-pushed the new-libc branch 8 times, most recently from f08e189 to fafb135Compare November 4, 2015 01:56

semarie reviewed Nov 4, 2015
View reviewed changes

alexcrichton force-pushed the new-libc branch 2 times, most recently from 586481d to c30a40dCompare November 4, 2015 21:30

alexcrichton force-pushed the new-libc branch from c30a40d to 29ddae2Compare November 4, 2015 22:53

alexcrichton force-pushed the new-libc branch from ecd4a29 to 615c345Compare November 9, 2015 21:07

libc: Replace liblibc with crates.io libc
c8a29c2

alexcrichton force-pushed the new-libc branch from 615c345 to 9da29e0Compare November 10, 2015 01:36

std: Migrate to the new libc
3d28b8b
* Delete `sys::unix::{c, sync}` as these are now all folded into libc itself * Update all references to use `libc` as a result. * Update all references to the new flat namespace. * Moves all windows bindings into sys::c

alexcrichton force-pushed the new-libc branch from 9da29e0 to 3d28b8bCompare November 10, 2015 06:55

bors merged commit 3d28b8b into rust-lang:masterNov 10, 2015

This was referenced Nov 10, 2015
Rollup of 7 pull requests #29736
Closed
Rustfmt libterm #28907
Merged
Add a numeric ID to threads #29448
Closed
Stricter doctests for corelibs #29544
Merged

tamird mentioned this pull request Nov 10, 2015
check-stage1: improper_ctypes in compiletest/raise_fd_limit on OSX #29751
Closed

This was referenced Nov 16, 2015
Prefer raw::c_char or libc::c_char and fix arm #29775
Merged
c_char has changed on ARM in 1.6 #29867
Closed

alexcrichton deleted the new-libc branch January 21, 2016 01:31

Uh oh!

Uh oh!

Conversation

alexcrichton commented Nov 3, 2015

Uh oh!

rust-highfive commented Nov 3, 2015

Uh oh!

alexcrichton commented Nov 3, 2015

Uh oh!

brson commented Nov 3, 2015

Uh oh!

brson commented Nov 3, 2015

Uh oh!

semarie commented Nov 4, 2015

Uh oh!

semarie commented Nov 4, 2015

Uh oh!

semarieNov 4, 2015

Choose a reason for hiding this comment

Uh oh!

alexcrichtonNov 4, 2015

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Nov 4, 2015

Uh oh!

bors commented Nov 4, 2015

Uh oh!

bors commented Nov 4, 2015

Uh oh!

alexcrichton commented Nov 4, 2015

Uh oh!

bors commented Nov 4, 2015

Uh oh!

bors commented Nov 9, 2015

Uh oh!

alexcrichton commented Nov 9, 2015

Uh oh!

bors commented Nov 9, 2015

Uh oh!

bors commented Nov 9, 2015

Uh oh!

alexcrichton commented Nov 10, 2015

Uh oh!

bors commented Nov 10, 2015

Uh oh!

bors commented Nov 10, 2015

Uh oh!

alexcrichton commented Nov 10, 2015

Uh oh!

bors commented Nov 10, 2015

Uh oh!

bors commented Nov 10, 2015

Uh oh!

dhuseby commented Nov 11, 2015

Uh oh!

mneumann commented Nov 13, 2015

Uh oh!

dhuseby commented Dec 30, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants