Uh oh!
There was an error while loading. Please reload this page.
Move built-in syntax extensions to a separate crate - #30300
Merged
Conversation
rust-highfive
commented
Dec 10, 2015
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
sanxiyn
commented
Dec 11, 2015
ContributorAuthor
Fixed all tests. |
bors
commented
Dec 14, 2015
Collaborator
☔ The latest upstream changes (presumably #29735) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
commented
Dec 14, 2015
Contributor
This looks good to me, though it needs a rebase. |
sanxiyn
commented
Dec 15, 2015
ContributorAuthor
Rebased and marked the crate unstable. |
nikomatsakis
commented
Dec 15, 2015
Contributor
@bors r+ |
bors
commented
Dec 15, 2015
Collaborator
📌 Commit 0883f10 has been approved by |
bors
commented
Dec 16, 2015
Collaborator
bors added a commit
that referenced
this pull request
Dec 16, 2015
This reduces iteration time (`make rustc-stage1`) for moved syntax extensions from 11 minutes to 3 minutes on my machine. Because of the signature change, this is a [breaking-change] for people directly calling `expand_crate`. I think it is rare: from GitHub search, only case I found is [glassful](https://github.com/kmcallister/glassful).
bors
commented
Dec 16, 2015
Collaborator
bors
commented
Dec 16, 2015
Collaborator
This was referenced Dec 16, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces iteration time (
make rustc-stage1) for moved syntax extensions from 11 minutes to 3 minutes on my machine.Because of the signature change, this is a [breaking-change] for people directly calling
expand_crate. I think it is rare: from GitHub search, only case I found is glassful.