Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #30409
Closed
Manishearth wants to merge 15 commits into
Closed
Conversation
Manishearth
commented
Dec 16, 2015
Member
- Successful merges: Make name resolution errors non-fatal #30320, Improve detection of unused imports (fixes #30078) #30325, fix dropck performance regression #30368, Add links in BTreeSet docs #30376, Generated code spans now point to callsite parameters (where applicable) #30388, Stop re-exporting RestrictionResult variants. #30392, add tests for #26873 #30408
- Failed merges: Make RFC 1214 warnings into errors #30389
…ed as used when checking for unused qualifications in resolve_path (fixesrust-lang#30078)
Turns out that calling `resolve_type_variables_if_possible` in a O(n^2) loop is a bad idea. Now we just resolve each copy of the region variable to its lowest name each time (we resolve the region variable to its lowest name, rather than to its unify-table name to avoid the risk of the unify-table name changing infinitely many times. That may be not a problem in practice, but I am not sure of it).
We can now handle name resolution errors and get past type checking (if we're a bit lucky). This is the first step towards doing code completion for partial programs (we need error recovery in the parser and early access to save-analysis).
This fixes a bug in which unused imports can get wrongly marked as used when checking for unused qualifications in `resolve_path` (issue rust-lang#30078), and it removes unused imports that were previously undetected because of the bug.
…omatsakis Turns out that calling `resolve_type_variables_if_possible` in a O(n^2) loop is a bad idea. Now we just resolve each copy of the region variable to its lowest name each time (we resolve the region variable to its lowest name, rather than to its unify-table name to avoid the risk of the unify-table name changing infinitely many times. That may be not a problem in practice, but I am not sure of it).
…hton The BtreeSet main description mentions `BTreeMap`, `Ord`, `Cell`, `RefCell`. This patch adds links to their documentation.
I think we can closerust-lang#26873 with these tests.
rust-highfive
commented
Dec 16, 2015
Contributor
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
commented
Dec 16, 2015
MemberAuthor
@bors r+ p=20 |
bors
commented
Dec 16, 2015
Collaborator
📌 Commit 89fe2e3 has been approved by |
bors
commented
Dec 16, 2015
Collaborator
☔ The latest upstream changes (presumably #30300) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.